Regression: Wrong colors editing list items in dark theme #112032

New Issue

Closed

opened 2023-09-06 15:39:17 +02:00 by Hamed-Nasrollahi-Majid · 11 comments

Hamed-Nasrollahi-Majid commented

2023-09-06 15:39:17 +02:00

System Information
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 850M/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 537.13

Blender Version
Broken: version: 4.0.0 Alpha, branch: main, commit date: 2023-09-06 00:49, hash: 8caec75f2cc9
Worked: (3.6)

Short description of error

It's same problem that I mentioned here:

but in dark theme. highlighting(selecting) text to rename it in dark theme is wrong color. I upload an image and compare it to 3.6 take a look at it.
the problem is that highlighting text is just same as selecting item and you will not notice that you are renaming it.

**System Information** Operating system: Windows-10-10.0.19045-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 850M/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 537.13 **Blender Version** Broken: version: 4.0.0 Alpha, branch: main, commit date: 2023-09-06 00:49, hash: `8caec75f2cc9` Worked: (3.6) **Short description of error** It's same problem that I mentioned here: https://projects.blender.org/blender/blender/issues/111942 but in dark theme. highlighting(selecting) text to rename it in dark theme is wrong color. I upload an image and compare it to 3.6 take a look at it. the problem is that highlighting text is just same as selecting item and you will not notice that you are renaming it.

dark theme color.png

103 KiB

dark theme color.png

Hamed-Nasrollahi-Majid added the

labels 2023-09-06 15:39:17 +02:00

Iliya Katushenock commented

2023-09-06 19:19:12 +02:00

Member

I not sure if this is bug or new feature (highlighting of list elements).

I not sure if this is bug or new feature (highlighting of list elements).

Iliya Katushenock added the

label 2023-09-06 19:19:18 +02:00

Iliya Katushenock changed title from ~~wrong colors editing list items in dark theme~~ to Regression: Wrong colors editing list items in dark theme

2023-09-06 19:19:26 +02:00

Hamed-Nasrollahi-Majid commented

2023-09-06 19:40:40 +02:00

Author

I not sure if this is bug or new feature (highlighting of list elements).

Thanks for reply
this is a bug caused by https://projects.blender.org/blender/blender/commit/9f4b28bb
Highlight Selected Enum is a great feature but it broke renaming list items in dark theme because default selection highlight is same blue as renaming highlight.

> I not sure if this is bug or new feature (highlighting of list elements). Thanks for reply this is a bug caused by https://projects.blender.org/blender/blender/commit/9f4b28bb Highlight Selected Enum is a great feature but it broke renaming list items in dark theme because default selection highlight is same blue as renaming highlight.

Pratik Borhade commented

2023-09-07 05:03:09 +02:00

Member

I can confirm
cc @pablovazquez

I can confirm cc @pablovazquez

Pratik Borhade added

and removed

labels 2023-09-07 05:03:25 +02:00

Pablo Vazquez referenced a pull request that will close this issue

2023-09-07 19:30:26 +02:00

UI: Theme: Allow transparency when editing text in widgets #112090

Pablo Vazquez self-assigned this 2023-09-11 16:53:02 +02:00

Pablo Vazquez closed this issue

2023-09-14 19:28:41 +02:00

Blender Bot added

and removed

labels 2023-09-14 19:28:43 +02:00

Pablo Vazquez commented

2023-09-14 19:31:31 +02:00

Member

The PR mentioning this task adds the ability to fix this but it doesn't fix it yet, that's another commit. So re-opening for now.

The PR mentioning this task adds the ability to fix this but it doesn't fix it yet, that's another commit. So re-opening for now.

Pablo Vazquez reopened this issue

2023-09-14 19:31:34 +02:00

Blender Bot added

and removed

labels 2023-09-14 19:31:36 +02:00

Pratik Borhade added

and removed

labels 2023-09-15 06:31:14 +02:00

Pablo Vazquez referenced this issue from a commit

2023-09-15 13:00:09 +02:00

Fix #112032: Theme: Wrong colors editing list items

Pablo Vazquez closed this issue

2023-09-15 13:00:11 +02:00

Blender Bot added

and removed

labels 2023-09-15 13:00:13 +02:00

Hamed-Nasrollahi-Majid commented

2023-09-19 23:09:16 +02:00

Author

Actually it is not fixed . Am I wrong?

Actually it is not fixed . Am I wrong?

Pratik Borhade commented

2023-09-20 06:49:04 +02:00

Member

Indeed not fixed.
Commits made by Pablo seems to handle the color of selected text (while renaming).
Maybe we could change the text background during renaming (similar to outliner)
Reopening for now.

Indeed not fixed. Commits made by Pablo seems to handle the color of selected text (while renaming). Maybe we could change the text background during renaming (similar to outliner) Reopening for now.

Pratik Borhade reopened this issue

2023-09-20 06:49:07 +02:00

Blender Bot added

and removed

labels 2023-09-20 06:49:08 +02:00

Pratik Borhade added

and removed

labels 2023-09-20 06:49:15 +02:00

Pablo Vazquez commented

2023-09-20 12:25:10 +02:00

Member

I thought I did, I may have missed versioning. Could you please go to the Preferences and reset the theme? It should work then. If that's the case then we should do versioning.

I thought I did, I may have missed versioning. Could you please go to the Preferences and reset the theme? It should work then. If that's the case then we should do versioning.

Pratik Borhade commented

2023-09-20 12:50:46 +02:00

Member

Nope, no difference in results after resetting the theme: image

Something like outliner would be good, I guess.

Nope, no difference in results after resetting the theme: [image](/attachments/52fe1f54-273f-4faa-868d-3a6914747d49) Something [like outliner](/attachments/a971afb8-d5a9-4cdd-ab87-47c8d27b0517) would be good, I guess.

16 KiB

22 KiB

Hamed-Nasrollahi-Majid commented

2023-10-03 21:18:40 +02:00

Author

I just tested latest Blender 4.0 Beta it seems to be fixed.
Can you check it again?
Thank you.

I just tested latest Blender 4.0 Beta it seems to be fixed. Can you check it again? Thank you.

Pablo Vazquez commented

2023-10-03 22:59:30 +02:00

Member

I just tested latest Blender 4.0 Beta it seems to be fixed.

I have fixed it a couple weeks ago. Would be nice if others can confirm so we can close this.

> I just tested latest Blender 4.0 Beta it seems to be fixed. I have fixed it a couple weeks ago. Would be nice if others can confirm so we can close this.

Pratik Borhade commented

2023-10-04 04:35:55 +02:00

Member

problem is that highlighting text is just same as selecting item

Yes, fixed indeed. I was talking about different UI problem. Closing.

> problem is that highlighting text is just same as selecting item Yes, fixed indeed. I was talking about different UI problem. Closing.

Pratik Borhade closed this issue

2023-10-04 04:35:58 +02:00

Blender Bot added

and removed

labels 2023-10-04 04:35:59 +02:00

Pratik Borhade referenced this issue

2023-10-14 13:32:29 +02:00

Blender Dark theme imported from 3.6.4 results in same colour for UIList active item and text selection #113683

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

4 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#112032

No description provided.