Assert loading Pets production files - invalid evaluated Mesh? #112035

New Issue

Bastien Montagne · 2023-09-06T16:27:06+02:00

Bastien Montagne commented

2023-09-06 16:27:06 +02:00

System Information
Operating system: Linux (debian testing)
Graphics card: N/A

Blender Version
Broken: current main (00a36cbf24)
Worked: 3.6

Short description of error

Loading several production files from Pets Project assert in debug builds, e.g. 010_0060.lighting.blend.

BLI_assert failed: source/blender/geometry/intern/mesh_split_edges.cc:595, split_edges(), at 'BKE_mesh_is_valid(&mesh)'

Exact steps for others to reproduce the error
Open one of the files mentioned above, or the file below (with the first failing object being appended), in a debug build.

**System Information** Operating system: Linux (debian testing) Graphics card: N/A **Blender Version** Broken: current main (00a36cbf242) Worked: 3.6 **Short description of error** Loading several production files from Pets Project assert in debug builds, e.g. `010_0060.lighting.blend`. ``` BLI_assert failed: source/blender/geometry/intern/mesh_split_edges.cc:595, split_edges(), at 'BKE_mesh_is_valid(&mesh)' ``` **Exact steps for others to reproduce the error** Open one of the files mentioned above, or the file below (with the first failing object being appended), in a debug build.

pets_OBGEO-body_append_from_10_0060.blend

2.2 MiB

Bastien Montagne added the

labels 2023-09-06 16:27:07 +02:00

Germano Cavalcante commented

2023-09-06 16:31:21 +02:00

@HooglyBoogly, if I'm not mistaken you worked on the split_edges code recently, right? Can you check?

EDIT: I'm not sure if it's really an error in the split_edges code.

@HooglyBoogly, if I'm not mistaken you worked on the split_edges code recently, right? Can you check? EDIT: I'm not sure if it's really an error in the split_edges code.

Hans Goudey commented

2023-09-06 16:47:04 +02:00

I looked into this last week, but I'm having trouble debugging because of a crash in bone collection versioning:

/home/hans/blender-git/blender/source/blender/animrig/intern/bone_collections.cc:242:14: runtime error: member access within null pointer of type 'struct Bone'
Writing: /tmp/blender.crash.txt

I brought this up in the animation module chat and there was some discussion about it. I thought there was a fix too, but I'm still getting the crash today.

EDIT: Ah, I see you appended a specific object, thanks.

I looked into this last week, but I'm having trouble debugging because of a crash in bone collection versioning: ``` /home/hans/blender-git/blender/source/blender/animrig/intern/bone_collections.cc:242:14: runtime error: member access within null pointer of type 'struct Bone' Writing: /tmp/blender.crash.txt ``` I brought this up in the animation module chat and there was some discussion about it. I thought there was a fix too, but I'm still getting the crash today. EDIT: Ah, I see you appended a specific object, thanks.

Hans Goudey commented

2023-09-06 17:10:36 +02:00

There isn't anything wrong with the split edges node other than it happens to have an assert for an invalid mesh. In this file the original mesh has invalid data for the bevel_weight_vert attribute which triggers an error in BKE_mesh_is_valid.

Without knowing how the original mesh was created, there's not much I can do in this case. I want to remove the BKE_mesh_is_valid assert soon anyway, maybe I can just remove it now.

There isn't anything wrong with the split edges node other than it happens to have an assert for an invalid mesh. In this file the original mesh has invalid data for the `bevel_weight_vert` attribute which triggers an error in `BKE_mesh_is_valid`. ![image](/attachments/090a697e-3edf-49b4-a94d-c0cbd06eb993) Without knowing how the original mesh was created, there's not much I can do in this case. I want to remove the `BKE_mesh_is_valid` assert soon anyway, maybe I can just remove it now.

image.png

58 KiB

Hans Goudey changed title from ~~Crash loading Pets production files - invalid evaluated Mesh?~~ to Assert loading Pets production files - invalid evaluated Mesh?

2023-09-06 17:33:03 +02:00

Bastien Montagne commented

2023-09-06 18:22:29 +02:00

RE bone versioning crash, fc02d5ee11 should fix it.

RE bone versioning crash, fc02d5ee111 should fix it.

Bastien Montagne commented

2023-09-06 18:23:33 +02:00

indeed, corrupted mesh data... we'll likely never know how it happened then :(

Bastien Montagne commented

2023-09-06 18:24:04 +02:00

But is it expected that 3.6 does not detect this issue?

Hans Goudey commented

2023-09-06 18:42:25 +02:00

But is it expected that 3.6 does not detect this issue?

Yeah, I just left the mesh validation assert in there for a bit to help detect issues in main after I refactored the code. I'll remove the assert soon, before I backport the rewrite to 3.6.

I'm very glad this wasn't an issue with the node itself.

> But is it expected that 3.6 does not detect this issue? Yeah, I just left the mesh validation assert in there for a bit to help detect issues in main after I refactored the code. I'll remove the assert soon, before I backport the rewrite to 3.6. I'm very glad this wasn't an issue with the node itself.

👍 1

Hans Goudey referenced this issue from a commit

2023-09-06 21:38:44 +02:00

Cleanup: Remove mesh validation assert in mesh code

Hans Goudey closed this issue

2023-09-06 21:38:45 +02:00

Blender Bot added

and removed