Pie menu with checkboxes (booleans) has dead-zones #112129

New Issue

Dalai Felinto · 2023-09-08T12:27:14+02:00

Dalai Felinto commented

2023-09-08 12:27:14 +02:00

Blender Version
Broken: version: 4.0.0 Alpha, branch: main, commit date: 2023-09-08 00:27, hash: 8d71e55d406d
Worked: Not sure, probably never.

Short description of error
Pie menus that have checkboxes present deadzones.

Exact steps for others to reproduce the error

Enabled Region Toggle Pie in the User Preferences: Keymap > Preferences
Use "N"
Note the ammount of deadzone

The red hatched zones are deadzones:

**Blender Version** Broken: version: 4.0.0 Alpha, branch: main, commit date: 2023-09-08 00:27, hash: `8d71e55d406d` Worked: Not sure, probably never. **Short description of error** Pie menus that have checkboxes present deadzones. **Exact steps for others to reproduce the error** * Enabled Region Toggle Pie in the User Preferences: `Keymap > Preferences` * Use "N" * Note the ammount of deadzone The red hatched zones are deadzones: ![image](/attachments/e3280eff-a988-4ddb-8110-7e0c76cda541)

image.png

142 KiB

Dalai Felinto added the

labels 2023-09-08 12:27:35 +02:00

Pablo Vazquez commented

2023-09-08 14:44:49 +02:00

Can confirm. I think it's a bug of all pies that have gaps or "invisible items" (often used for sorting items properly).

See the blue indicator in the center, in the Shading pie (Z) with 4 items, the indicator is one quarter.

In the Region Toggle pie, the blue indicator is smaller, as if there were 8 items instead of the 4 visible ones.

Can confirm. I think it's a bug of all pies that have gaps or "invisible items" (often used for sorting items properly). See the blue indicator in the center, in the Shading pie (Z) with 4 items, the indicator is one quarter. In the Region Toggle pie, the blue indicator is smaller, as if there were 8 items instead of the 4 visible ones. <video src="/attachments/ff1ceb76-e912-4d1d-8931-b7d9e4333144" title="2023-09-08_14.41.47.mp4" controls loop></video>

2023-09-08_14.41.47.mp4

279 KiB

DShot92 commented

2023-09-09 21:24:13 +02:00

Found the problem, but i not sure if it is the correct way.

On the commit message of the code it says "Experimental" so maybe that's not the final form of it.

Also there's still is the Pivot Pie Menu bugging me, with just 6 slot filled, there is one that still has dead space around.

Found the problem, but i not sure if it is the correct way. On the commit message of the code it says "Experimental" so maybe that's not the final form of it. Also there's still is the Pivot Pie Menu bugging me, with just 6 slot filled, there is one that still has dead space around.

Screenshot from 2023-09-09 21-20-46.png

102 KiB

pie_menu.diff

544 B

Harley Acheson self-assigned this 2023-09-09 23:57:56 +02:00

Harley Acheson commented

2023-09-10 00:01:26 +02:00

OMG that took far too long to track down.

Harley Acheson commented

2023-09-10 00:10:31 +02:00

@DShot92

You found the correct place to fix this and I wish I had noticed your post because it would have saved me a lot of time.

Unfortunately, your proposed diff won't always work. There are 6 different types of regions this script can toggle, so although we are almost always seeing only four items there could be more. And this script seems to be doing special things with the first half of that 8-item list from the second half.

I'll post a PR for this that removes empty items from the two lists. I'm hoping to mention you in that PR and you can comment if you feel that it is not correct.

@DShot92 You found the correct place to fix this and I wish I had noticed your post because it would have saved me a lot of time. Unfortunately, your proposed diff won't always work. There are 6 different types of regions this script can toggle, so although we are almost always seeing only four items there could be more. And this script seems to be doing special things with the first half of that 8-item list from the second half. I'll post a PR for this that removes empty items from the two lists. I'm hoping to mention you in that PR and you can comment if you feel that it is not correct.

Matt commented

2023-09-10 00:25:10 +02:00

Not sure what the fix is or will be, but. I often hit the WRONG pie menu item, because of that mid-way point / "snapping".

Would one of these options help solve that? Or is that another issue/related to this?

Not sure what the fix is or will be, but. I often hit the WRONG pie menu item, because of that mid-way point / "snapping". Would one of these options help solve that? Or is that another issue/related to this? ![image](/attachments/3b776f1b-8e16-407d-bbd6-8c713f2b0544)

image.png

10 KiB

DShot92 commented

2023-09-10 00:28:08 +02:00

Yes, my first try wat to set

item = [[] for _ in range(len(region_by_type))]

But after a second look it seems like this is a completely custom pie menu only for "Region Toggle".

I do not know the status of this button, as in the commit of that code the message says it's experimental, so maybe that' just a quick way to test it out.
Don't know.

And yes i feel the pain!

Yes, my first try wat to set `item = [[] for _ in range(len(region_by_type))]` But after a second look it seems like this is a completely custom pie menu only for "Region Toggle". I do not know the status of this button, as in the commit of that code the message says it's experimental, so maybe that' just a quick way to test it out. Don't know. And yes i feel the pain!

Harley Acheson referenced a pull request that will close this issue

2023-09-10 00:34:25 +02:00

Fix #112129: Remove Blank Items from "Region Toggle" Pie Menu #112193

Harley Acheson referenced this issue from a commit

2023-09-10 18:26:34 +02:00

Fix #112129: Remove Blank Items from "Region Toggle" Pie Menu

Harley Acheson closed this issue

2023-09-10 18:26:35 +02:00

Blender Bot added

and removed

labels 2023-09-10 18:26:37 +02:00

Campbell Barton referenced this issue

2023-09-13 04:42:56 +02:00

UI: remove unnecessarily dead zones for pie menus #112311

Campbell Barton commented

2023-09-13 04:44:53 +02:00

Empty items are needed to ensure the regions directions match the pie menu items (resolved 8167ad746c).

Submitted a separate PR !112311 to avoid the dead zones altogether.

Empty items are needed to ensure the regions directions match the pie menu items (resolved 8167ad746c19316eb6adada2b6a0872dd3a72311). Submitted a separate PR !112311 to avoid the dead zones altogether.

Campbell Barton referenced this issue from a commit

2023-09-18 08:07:53 +02:00

Cleanup: remove fix for #112129 which is no longer needed

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Pie menu with checkboxes (booleans) has dead-zones #112129