Noise nodes with high detail and lacunarity values outputs erratic values #112180

New Issue

Sun Kim · 2023-09-09T13:08:41+02:00

Sun Kim commented

2023-09-09 13:08:41 +02:00

System Information
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2060 SUPER/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 536.40

Blender Version
Broken: version: 4.0.0 Alpha, branch: main, commit date: 2023-09-08 19:35, hash: 967d49dba48e
Worked: ?

Lacunarity option was exposed with 0702c24a36. Not sure if that commit caused or exposed this issue because I don't think there was a way to change lacunarity value at user-level before that. Maybe the latter since Musgrave and Voronoi textures seem to have similar issues with high values.

Short description of error
Noise node with high detail and lacunarity values outputs erratic values (values outside of the expected range, nan, inf) in Geometry Nodes. It seems there's no issue in Shader nodes until you give them very high values (ex: detail 15.0, lacunarity: 500.0) but I'm not sure.

Notice that even with the Normalize option enabled it outputs values higher than 1.0 (see the spreadsheet).

Exact steps for others to reproduce the error

Test file: noise_node_values.blend

It seems this happens when combination of detail and lacunarity values are high.

The easiest way to trigger the error is set both values very high. It will probably outputs all nan values.

Detail: 10.0, Roughness: 1.0, Lacunarity: 10.0, Normalize enabled

With not so high values, it usually outputs values outside of the range.

Detail: 6.5, Roughness: 1.0, Lacunarity: 7.5, Normalize enabled

**System Information** Operating system: Windows-10-10.0.19045-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 2060 SUPER/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 536.40 **Blender Version** Broken: version: 4.0.0 Alpha, branch: main, commit date: 2023-09-08 19:35, hash: `967d49dba48e` Worked: ? Lacunarity option was exposed with 0702c24a36. Not sure if that commit caused or exposed this issue because I don't think there was a way to change lacunarity value at user-level before that. Maybe the latter since Musgrave and Voronoi textures seem to have similar issues with high values. **Short description of error** Noise node with high detail and lacunarity values outputs erratic values (values outside of the expected range, nan, inf) in Geometry Nodes. It seems there's no issue in Shader nodes until you give them very high values (ex: detail 15.0, lacunarity: 500.0) but I'm not sure. Notice that even with the Normalize option enabled it outputs values higher than 1.0 (see the spreadsheet). ![noise_node_values_erratic.png](/attachments/2b560dd5-5d18-4ca3-ac9c-d2455994fe2b) **Exact steps for others to reproduce the error** Test file: [noise_node_values.blend](/attachments/589915d8-ae57-4f68-954d-a82e55c1b33f) It seems this happens when combination of detail and lacunarity values are high. The easiest way to trigger the error is set both values very high. It will probably outputs all nan values. ### Detail: 10.0, Roughness: 1.0, Lacunarity: 10.0, Normalize enabled ![BmdXc58IgU.png](/attachments/a227e2e0-94ae-4da0-96fc-1d075d2ba6ea) With not so high values, it usually outputs values outside of the range. ### Detail: 6.5, Roughness: 1.0, Lacunarity: 7.5, Normalize enabled ![2lG2RollK4.png](/attachments/57bb844c-36bf-41b9-acdf-afb07557e199)

2lG2RollK4.png

339 KiB

noise_node_values.blend

1.1 MiB

noise_node_values_erratic.png

539 KiB

BmdXc58IgU.png

318 KiB

Sun Kim added the

labels 2023-09-09 13:08:42 +02:00

Iliya Katushenock commented

2023-09-09 14:02:32 +02:00

@Hoshinova /^

Jesse Yurkovich added

and removed

labels 2023-09-10 07:04:49 +02:00

Hoshinova commented

2023-09-22 16:37:53 +02:00

I'll take a look at it while merging the Noise and Musgrave Textures. Is this issue also present with Voronoi? @persun

Sun Kim commented

2023-09-23 10:33:30 +02:00

Is this issue also present with Voronoi?

Yes, but with much, much higher values.

Voronoi, Detail: 15.0, Roughness: 0.5, Lacunarity: 315.8, Normalize enabled

If the detail is set to over a value higher than the soft cap (15.0), it happens with a much lower lacunarity value. In my layman's eyes this seems to happen with a certain combination of detail and lacunarity values.

Voronoi, Detail: 30.0, Roughness: 0.5, Lacunarity: 17.9, Normalize enabled

> Is this issue also present with Voronoi? Yes, but with much, much higher values. ### Voronoi, Detail: 15.0, Roughness: 0.5, Lacunarity: 315.8, Normalize enabled ![noise_node_values1.png](/attachments/90f9def4-0b3b-42d0-a5b3-060f905ffca4) If the detail is set to over a value higher than the soft cap (15.0), it happens with a much lower lacunarity value. In my layman's eyes this seems to happen with a certain combination of detail and lacunarity values. ### Voronoi, Detail: 30.0, Roughness: 0.5, Lacunarity: 17.9, Normalize enabled ![noise_node_values2.png](/attachments/1431e93d-1d82-4093-af26-ac94d3b78131)

noise_node_values1.png

487 KiB

noise_node_values2.png

496 KiB

Hoshinova commented

2023-09-24 02:00:26 +02:00

@persun The Voronoi examples are all in Geometry nodes. Is shader nodes Voronoi also affected by this?

You also mentioned that Musgrave has similar issues. What input combinations cause Musgrave to experience those issues?

@persun The Voronoi examples are all in Geometry nodes. Is shader nodes Voronoi also affected by this? You also mentioned that Musgrave has similar issues. What input combinations cause Musgrave to experience those issues?

Sun Kim commented

2023-09-24 14:05:30 +02:00

Is shader nodes Voronoi also affected by this?

I think it does, but at much higher detail and lacunarity values. Not really sure because I don't know how to properly debug shader values.

Here, I did a simple test using the bloom threshold, to see if the values the shader emits are over a certain threshold. I've set the bloom threshold to 5000.0, and set Voronoi's detail and lacunarity values very high, with the normalize option enabled. The plane emits very, very bright light when it should not emit color brighter than 1.0.

You also mentioned that Musgrave has similar issues. What input combinations cause Musgrave to experience those issues?

Usually with a high detail value. But it happens with a lower detail value if lacunarity is small. Dimension also seems to affect it.

Detail: 15.0, Dimension: 0.01, Lacunarity: 0.0

Detail: 15.0, Dimension: 2.0, Lacunarity: 4.1

Detail: 6.82, Dimension: 2.0, Lacunarity: 0.49

> Is shader nodes Voronoi also affected by this? I *think* it does, but at much higher detail and lacunarity values. Not really sure because I don't know how to properly debug shader values. Here, I did a simple test using the bloom threshold, to see if the values the shader emits are over a certain threshold. I've set the bloom threshold to 5000.0, and set Voronoi's detail and lacunarity values very high, with the normalize option enabled. The plane emits very, very bright light when it should not emit color brighter than 1.0. ![noise_node_values_shader.png](/attachments/561c160e-04b6-4018-905d-a7b4d1aec5a6) > You also mentioned that Musgrave has similar issues. What input combinations cause Musgrave to experience those issues? Usually with a high detail value. But it happens with a lower detail value if lacunarity is small. Dimension also seems to affect it. ### Detail: 15.0, Dimension: 0.01, Lacunarity: 0.0 ![musgrave_detail-15.0_dimension-0.01_lacunarity-0.0.png](/attachments/e65dacdb-6e97-433e-9aab-318e520c62a5) ### Detail: 15.0, Dimension: 2.0, Lacunarity: 4.1 ![musgrave_detail-15.0_dimension-2.0_lacunarity-4.1.png](/attachments/1473f736-7d4c-4416-9085-f96194b78781) ### Detail: 6.82, Dimension: 2.0, Lacunarity: 0.49 ![musgrave_detail-6.82_dimension-2.0_lacunarity-0.49.png](/attachments/4e724a5a-6159-4ab0-836b-dd59886eab5d)

musgrave_detail-6.82_dimension-2.0_lacunarity-0.49.png

196 KiB

noise_node_values_shader.png

647 KiB

musgrave_detail-15.0_dimension-2.0_lacunarity-4.1.png

329 KiB

musgrave_detail-15.0_dimension-0.01_lacunarity-0.0.png

316 KiB

Hoshinova commented

2023-09-27 14:39:28 +02:00

For the noise and musgrave textures the issues seems to stem from an integer overflow in floor_fraction.

For the noise and musgrave textures the issues seems to stem from an integer overflow in [floor_fraction](https://projects.blender.org/blender/blender/src/commit/ab26ddc4555bf8cc0c310a46f3f657208940578e/source/blender/blenlib/intern/noise.cc#L384).

~~Hoshinova referenced this issue 2023-09-27 16:50:01 +02:00~~

Fix #112180. #112962

Iliya Katushenock referenced a pull request that will close this issue

2023-09-27 16:50:56 +02:00

Fix #112180. #112962

Sun Kim commented

2023-09-27 17:03:14 +02:00

@Hoshinova It's the same file with the one in the original report, just replaced the noise texture with musgrave one, and changed the values.

But just in case, the same conditions with the last image: noise_node_values_musgrave.blend

@Hoshinova It's the same file with the one in the original report, just replaced the noise texture with musgrave one, and changed the values. But just in case, the same conditions with the last image: [noise_node_values_musgrave.blend](/attachments/5a076e49-6cd2-4481-a838-c9ea764ef272)

noise_node_values_musgrave.blend

1.1 MiB

Hoshinova commented

2023-09-27 17:33:40 +02:00

Thanks!

Omar Emara referenced this issue from a commit

2023-09-27 18:01:26 +02:00

Fix #112180: Noise with high detail and lacunarity outputs erratic values

Omar Emara closed this issue

2023-09-27 18:01:27 +02:00

Blender Bot added

Status