Auto-Merging keyframes in the Driver Editor has unappropriate threshold (merges keyframes that shouldnt) #112316

New Issue

jeroenb · 2023-09-13T09:41:28+02:00

jeroenb commented

2023-09-13 09:41:28 +02:00

System Information
Operating system: windows 10 & Linux ubuntu
Graphics card: GTX 1070

Blender Version
Broken: 3.6.2
Worked: unknown

See att. blendfile and pictures; moving the base of the armature in the Y direction drives the shapekey of the torus.
If you edit a driver keyframe by just slightly moving it to the right, the keyframe next to it is removed

Exact steps for others to reproduce the error
Try editing keyframes in the driver f-curve editor

Note
Drivers editor has the driver value as the x-axis (this can be arbitrary low, e.g. in the report, this was the x location [in meters] so handling quite small values where "keyframes" where ~0.01 apart

BKE_fcurve_merge_duplicate_keys acts with a threshold of BEZT_BINARYSEARCH_THRESH 0.01f

**System Information** Operating system: windows 10 & Linux ubuntu Graphics card: GTX 1070 **Blender Version** Broken: 3.6.2 Worked: unknown See att. blendfile and pictures; moving the base of the armature in the Y direction drives the shapekey of the torus. If you edit a driver keyframe by just slightly moving it to the right, the keyframe next to it is removed **Exact steps for others to reproduce the error** Try editing keyframes in the driver f-curve editor **Note** Drivers editor has the driver value as the x-axis (this can be arbitrary low, e.g. in the report, this was the x location [in meters] so handling quite small values where "keyframes" where ~0.01 apart `BKE_fcurve_merge_duplicate_keys` acts with a threshold of `BEZT_BINARYSEARCH_THRESH 0.01f`

Driver problem.blend

1.1 MiB

Problem 01.jpg

172 KiB

Problem 02.jpg

154 KiB

jeroenb added the

labels 2023-09-13 09:41:29 +02:00

Philipp Oeser commented

2023-09-13 09:56:14 +02:00

Can confirm, will check.
Assume BKE_fcurve_merge_duplicate_keys does its job here (but probably shouldnt in the context of the drivers editor)

Can confirm, will check. Assume `BKE_fcurve_merge_duplicate_keys` does its job here (but probably shouldnt in the context of the drivers editor)

Philipp Oeser added

and removed

labels 2023-09-13 09:56:30 +02:00

jeroenb commented

2023-09-13 20:36:58 +02:00

Thank you Philipp for your respons.
Is there something that I can do myself, for instance editing something in the Blender data files on my PC that has to do with "BKE_fcurve_merge_duplicate_keys" that you mention?

Thank you Philipp for your respons. Is there something that I can do myself, for instance editing something in the Blender data files on my PC that has to do with "BKE_fcurve_merge_duplicate_keys" that you mention?

jeroenb closed this issue

2023-09-13 20:37:10 +02:00

Blender Bot added

and removed

labels 2023-09-13 20:37:12 +02:00

jeroenb reopened this issue

2023-09-13 20:37:20 +02:00

Blender Bot added

and removed

labels 2023-09-13 20:37:22 +02:00

jeroenb commented

2023-09-13 20:39:15 +02:00

Sorry, accidently closed this issue

Germano Cavalcante added

and removed

labels 2023-09-13 21:03:02 +02:00

Philipp Oeser commented

2023-09-15 10:31:43 +02:00

Thank you Philipp for your respons.
Is there something that I can do myself, for instance editing something in the Blender data files on my PC that has to do with "BKE_fcurve_merge_duplicate_keys" that you mention?

Well, for now, you can just turn this OFF

(I still think this should be OFF by default for the Drivers Editor, or we should be smarter about the threshold, for timebased fcurves this might make sense BEZT_BINARYSEARCH_THRESH 0.01f but for the drivers editor -- which can have arbitrary low values to handle as this report shows -- this should either be dynamic, or we should turn it OFF completely)

> Thank you Philipp for your respons. > Is there something that I can do myself, for instance editing something in the Blender data files on my PC that has to do with "BKE_fcurve_merge_duplicate_keys" that you mention? Well, for now, you can just turn this OFF ![image](/attachments/7209d7aa-42aa-4f60-b1d5-8ad208678343) (I still think this should be OFF by default for the Drivers Editor, or we should be smarter about the threshold, for timebased fcurves this might make sense `BEZT_BINARYSEARCH_THRESH 0.01f` but for the drivers editor -- which can have arbitrary low values to handle as this report shows -- this should either be dynamic, or we should turn it OFF completely)

image.png

68 KiB

Philipp Oeser changed title from ~~Editing driver f-curve results in losing keyframes~~ to Auto-Merging keyframes in the Driver Editor has unappropriate threshold (merges keyframes that shouldnt)

2023-09-15 10:33:20 +02:00

jeroenb commented

2023-09-15 15:08:11 +02:00

Wow!
I convinced myself before reporting this issue that there was nothing in the UI that could switch off this behaviour!
And it is right there in front of my face!
I must be getting senile (I admit I'm turning into a rather old blender monkey) LOL

Thanks for pointing this out to me Philipp.

About auto-merging keyframes; it would make more sence to me if (when enabled) it would show an adjustable margin setting or something like that.

Wow! I convinced myself before reporting this issue that there was nothing in the UI that could switch off this behaviour! And it is right there in front of my face! I must be getting senile (I admit I'm turning into a rather old blender monkey) LOL Thanks for pointing this out to me Philipp. About auto-merging keyframes; it would make more sence to me if (when enabled) it would show an adjustable margin setting or something like that.

Christoph Lendenfeld added

and removed

labels 2023-10-06 17:10:47 +02:00

Christoph Lendenfeld referenced this issue

2024-01-19 12:44:40 +01:00

Anim: Reorganize items in 'View' menus in animation and video editors #117162

Christoph Lendenfeld added

and removed

labels 2024-02-06 16:36:28 +01:00

Christoph Lendenfeld commented

2024-02-06 16:37:39 +01:00

putting this down as a known issue. I wanted to set the default of that setting to be enabled for the Graph Editor, but disabled for the driver editor.

Turns out they are the same thing so you can't modify one without modifying the other.

putting this down as a known issue. I wanted to set the default of that setting to be enabled for the Graph Editor, but disabled for the driver editor. Turns out they are the same thing so you can't modify one without modifying the other.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Auto-Merging keyframes in the Driver Editor has unappropriate threshold (merges keyframes that shouldnt) #112316