UI: Node Panels: Inconsistent margins for panel headers #112499

New Issue

Closed

opened 2023-09-18 09:14:59 +02:00 by Daybreak · 3 comments

Daybreak commented

2023-09-18 09:14:59 +02:00

Contributor

This isn't the biggest deal, but I did find it noticable and worth pointing out.

1. When a panel is expanded, the panel below it ends up with a shorter header margin on the top than the bottom.

It seems that expanding a panel 'eats' a bit of the margin for the following panel's header.

2. A collapsed panel at the bottom of a node has a significantly greater bottom header margin than top.

See the above image, where the Emission panel has a significantly greater bottom margin than top.

This is due to the node itself (I believe) having a bit of internal padding, and is only noticable due to the color difference between the panel header and the preceding panel's contents. I do not forsee this being changed.

An open panel looks fine, and the same is true for multiple collapsed panels in a row.

This isn't the biggest deal, but I did find it noticable and worth pointing out. **1. When a panel is expanded, the panel below it ends up with a shorter header margin on the top than the bottom.** It seems that expanding a panel 'eats' a bit of the margin for the following panel's header. ![image](/attachments/4180870b-b313-46ac-866a-9763ec78a98d) **2. A collapsed panel at the bottom of a node has a significantly greater bottom header margin than top.** See the above image, where the Emission panel has a significantly greater bottom margin than top. This is due to the node itself (I believe) having a bit of internal padding, and is only noticable due to the color difference between the panel header and the preceding panel's contents. I do not forsee this being changed. An open panel looks fine, and the same is true for multiple collapsed panels in a row. ![image](/attachments/469bdc2f-97b1-452d-b6b6-c2d44002e199)

26 KiB

59 KiB

Daybreak added the

labels 2023-09-18 09:15:00 +02:00

Pratik Borhade commented

2023-09-18 10:50:48 +02:00

Member

Hi, thanks for the report.

panel 'eats' a bit of the margin for the following panel's header.

I think @lone_noel has dealt with similar alignment/precision bugs. Can you check Leon? 🙂

A collapsed panel at the bottom of a node has a significantly greater bottom header margin than top.

Not sure any improvement is expected in this case. Padding might be intentional at the node borders.

Hi, thanks for the report. > panel 'eats' a bit of the margin for the following panel's header. I think @lone_noel has dealt with similar alignment/precision bugs. Can you check Leon? 🙂 > A collapsed panel at the bottom of a node has a significantly greater bottom header margin than top. Not sure any improvement is expected in this case. Padding might be intentional at the node borders.

Pratik Borhade added

Nodes & Physics

Needs Info from Developers

and removed

labels 2023-09-18 10:51:06 +02:00

Leon Schittek commented

2023-09-19 00:08:59 +02:00

Member

Thanks for the ping!

panel 'eats' a bit of the margin for the following panel's header.

I think @lone_noel has dealt with similar alignment/precision bugs. Can you check Leon? 🙂

The vertical alignment of the header text is definitely a bit odd. Usually the text is aligned to be centered without taking decenders into account (e.g. compare the 'Sheen' inside the number button compared to the one in the header in the report).

There's a lot (new stuff) going on in the node layout code so I haven't been able to make out if there is actually some kind of alignment error anywhere, but I think this should be adjusted to better match the other text either way.

A collapsed panel at the bottom of a node has a significantly greater bottom header margin than top.

Not sure any improvement is expected in this case. Padding might be intentional at the node borders.

Yeah, the little bit of padding at the bottom belongs to the body of the node and is intentional.

Thanks for the ping! > > panel 'eats' a bit of the margin for the following panel's header. > > I think @lone_noel has dealt with similar alignment/precision bugs. Can you check Leon? 🙂 The vertical alignment of the header text is definitely a bit odd. Usually the text is aligned to be centered without taking decenders into account (e.g. compare the 'Sheen' inside the number button compared to the one in the header in the report). There's a lot (new stuff) going on in the node layout code so I haven't been able to make out if there is actually some kind of alignment error anywhere, but I think this should be adjusted to better match the other text either way. > > A collapsed panel at the bottom of a node has a significantly greater bottom header margin than top. > > Not sure any improvement is expected in this case. Padding might be intentional at the node borders. Yeah, the little bit of padding at the bottom belongs to the body of the node and is intentional.

Leon Schittek added

and removed

Needs Info from Developers

labels 2023-09-19 00:09:14 +02:00

Iliya Katushenock referenced this issue

2023-09-19 19:13:17 +02:00

UI: improve vertical spacing in node panels #112593

Leon Schittek commented

2023-09-21 06:31:38 +02:00

Member

Now that #112593 is merged, I think we can consider this resolved.

Thanks again for the report!

Now that https://projects.blender.org/blender/blender/pulls/112593 is merged, I think we can consider this resolved. Thanks again for the report!

Leon Schittek closed this issue

2023-09-21 06:31:41 +02:00

Blender Bot added

and removed

labels 2023-09-21 06:31:44 +02:00

Pratik Borhade added

and removed

labels 2023-09-21 06:33:36 +02:00

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#112499

No description provided.