Node Panels Polishing #112506

Open
opened 2023-09-18 12:17:37 +02:00 by Dalai Felinto · 6 comments
  • Support Ctrl+click to isolate panel.
  • Support dragging all panels to collapse/expand them.
  • Improve horizontal padding (#112593)

  • Don't space out sockets when hiding the node
    image

  • Bug, hide panel when all its sockets are hidden with Ctrl+H
    image

- [ ] Support Ctrl+click to isolate panel. - [ ] Support dragging all panels to collapse/expand them. - [x] Improve horizontal padding (#112593) --- - [x] Don't space out sockets when hiding the node ![image](/attachments/d5fc1d47-d378-4b73-86fc-c1323cc05a8a) - [ ] Bug, hide panel when all its sockets are hidden with Ctrl+H ![image](/attachments/812ca882-0200-4599-bcd8-1e4627856284)
Dalai Felinto added the
Type
To Do
label 2023-09-18 12:17:37 +02:00
Dalai Felinto added this to the Nodes & Physics project 2023-09-18 12:17:39 +02:00
Member

Sounds good overall! I just have one concern with supporting A to toggle a panel when hovering over it. In the properties panel A doesn't serve any other purpose. In the node editor A is already used to select all nodes, which is independent of the cursor position.
Making this do something entirely different if you happen to hover your cursor over a panel would introduce a pretty annoying papercut imo.
I personally didn't even know this shortcut existed. It does seem useful, but I'm a bit surprised why it would be on a key like A that is already this loaded in most editors for selection. I guess the issue only appears now as we are mixing panel UI with selectable elements for the first time.

Sounds good overall! I just have one concern with supporting `A` to toggle a panel when hovering over it. In the properties panel `A` doesn't serve any other purpose. In the node editor `A` is already used to select all nodes, which is independent of the cursor position. Making this do something entirely different if you happen to hover your cursor over a panel would introduce a pretty annoying papercut imo. I personally didn't even know this shortcut existed. It does seem useful, but I'm a bit surprised why it would be on a key like `A` that is already this loaded in most editors for selection. I guess the issue only appears now as we are mixing panel UI with selectable elements for the first time.
Author
Owner

Maybe we can skip that one (@pablovazquez ) ^^

Maybe we can skip that one (@pablovazquez ) ^^
Contributor

Little bit more space between first panel and regular sockets would be nice to distinguish visually where panel is starting and other sockets end. Especially when zoomed out

Little bit more space between first panel and regular sockets would be nice to distinguish visually where panel is starting and other sockets end. Especially when zoomed out
Contributor

Yes, the A shortcut is not a good idea. It would mean the user needs to be aware if mouse cursor is over a node or not to anticipate if pressing A key will toggle all panels or select all nodes. That would probably just cause frustration.

Yes, the A shortcut is not a good idea. It would mean the user needs to be aware if mouse cursor is over a node or not to anticipate if pressing A key will toggle all panels or select all nodes. That would probably just cause frustration.
Contributor

I also agree that A changing functionality depending on if you're hovering over a node will get rather annoying.

Otherwise, I have nothing to add except that I agree with the proposals, especially the padding change. I've found that Principled BSDF with all panels expanded appears incredibly cluttered in its current state.

I also agree that `A` changing functionality depending on if you're hovering over a node will get rather annoying. Otherwise, I have nothing to add except that I agree with the proposals, especially the padding change. I've found that Principled BSDF with all panels expanded appears incredibly cluttered in its current state.

Sounds good overall! I just have one concern with supporting A to toggle a panel when hovering over it. In the properties panel A doesn't serve any other purpose. In the node editor A is already used to select all nodes, which is independent of the cursor position.
Making this do something entirely different if you happen to hover your cursor over a panel would introduce a pretty annoying papercut imo.
I personally didn't even know this shortcut existed. It does seem useful, but I'm a bit surprised why it would be on a key like A that is already this loaded in most editors for selection. I guess the issue only appears now as we are mixing panel UI with selectable elements for the first time.

Wouldn't it be Alt + H

> Sounds good overall! I just have one concern with supporting `A` to toggle a panel when hovering over it. In the properties panel `A` doesn't serve any other purpose. In the node editor `A` is already used to select all nodes, which is independent of the cursor position. > Making this do something entirely different if you happen to hover your cursor over a panel would introduce a pretty annoying papercut imo. > I personally didn't even know this shortcut existed. It does seem useful, but I'm a bit surprised why it would be on a key like `A` that is already this loaded in most editors for selection. I guess the issue only appears now as we are mixing panel UI with selectable elements for the first time. Wouldn't it be Alt + H
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
6 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#112506
No description provided.