Regression in 4.0, crash loading blend file without a scene collection #112649

New Issue

Campbell Barton · 2023-09-21T05:31:39+02:00

Campbell Barton commented

2023-09-21 05:31:39 +02:00

Broken: f6082a5042db7cfe6c4617387a04f216a1ba3f99
Working: 3.6 LTS.

This test from lib/ crashes on load:

blender ../lib/tests/depsgraph/deg_point_cache_transform.blend

This crashes in release builds, asserts in debug builds:

./blender.bin() ./source/blender/blenlib/intern/system.c:86: BLI_system_backtrace (0x2fa9abe)
./blender.bin() ./source/blender/blenlib/intern/BLI_assert.c:38: _BLI_assert_print_backtrace (0x29ca0f0)
./blender.bin() ./source/blender/blenkernel/intern/collection.cc:2101 (discriminator 2): scene_collections_array(Scene*, Collection***, int*) (0x35b760e)
./blender.bin() ./source/blender/blenkernel/intern/collection.cc:2124: BKE_scene_collections_iterator_begin (0x35b79ba)
./blender.bin() ./source/blender/blenkernel/intern/collection.cc:2182: scene_objects_iterator_begin(BLI_Iterator*, Scene*, GSet*) (0x35b7f87)
./blender.bin() ./source/blender/blenkernel/intern/collection.cc:2193: BKE_scene_objects_iterator_begin (0x35b8056)
./blender.bin() ./source/blender/blenkernel/intern/lib_override_proxy_conversion.cc:126: BKE_lib_override_library_main_proxy_convert(Main*, BlendFileReadReport*) (0x3f08530)
./blender.bin() ./source/blender/blenloader/intern/versioning_common.cc:522: do_versions_after_setup(Main*, BlendFileReadReport*) (0x4e43643)
./blender.bin() ./source/blender/blenloader/intern/readblenentry.cc:512: BLO_read_do_version_after_setup (0x4d1c740)
./blender.bin() ./source/blender/blenkernel/intern/blendfile.cc:880: setup_app_data(bContext*, BlendFileData*, BlendFileReadParams const*, BlendFileReadWMSetupData*, BlendFileReadReport*) (0x3520a67)
./blender.bin() ./source/blender/blenkernel/intern/blendfile.cc:956: setup_app_blend_file_data(bContext*, BlendFileData*, BlendFileReadParams const*, BlendFileReadWMSetupData*, BlendFileReadReport*) (0x3521081)
./blender.bin() ./source/blender/blenkernel/intern/blendfile.cc:994: BKE_blendfile_read_setup_readfile (0x35213c3)
./blender.bin() ./source/blender/windowmanager/intern/wm_files.cc:1067: WM_file_read(bContext*, char const*, ReportList*) (0x3033a5f)
./blender.bin() ./source/creator/creator_args.cc:2185 (discriminator 1): handle_load_file(bContext*, char const*, bool) (0x29c726d)
./blender.bin() ./source/creator/creator_args.cc:2256 (discriminator 1): main_args_handle_load_file (0x29c76c5)
./blender.bin() ./source/blender/blenlib/intern/BLI_args.c:322: BLI_args_parse (0x2fbfa62)
./blender.bin() ./source/creator/creator.cc:564: main (0x29bcaa4)
/usr/lib/libc.so.6(+0x27cd0) ??:0: ?? (0x7fdfca627cd0)
/usr/lib/libc.so.6(__libc_start_main+0x8a) ??:0: ?? (0x7fdfca627d8a)
./blender.bin() ??:?: _start (0x29bc125)
BLI_assert failed: source/blender/blenkernel/intern/collection.cc:2101, scene_collections_array(), at 'collection != nullptr'

Broken: `f6082a5042db7cfe6c4617387a04f216a1ba3f99` Working: 3.6 LTS. This test from `lib/` crashes on load: `blender ../lib/tests/depsgraph/deg_point_cache_transform.blend` This crashes in release builds, asserts in debug builds: ``` ./blender.bin() ./source/blender/blenlib/intern/system.c:86: BLI_system_backtrace (0x2fa9abe) ./blender.bin() ./source/blender/blenlib/intern/BLI_assert.c:38: _BLI_assert_print_backtrace (0x29ca0f0) ./blender.bin() ./source/blender/blenkernel/intern/collection.cc:2101 (discriminator 2): scene_collections_array(Scene*, Collection***, int*) (0x35b760e) ./blender.bin() ./source/blender/blenkernel/intern/collection.cc:2124: BKE_scene_collections_iterator_begin (0x35b79ba) ./blender.bin() ./source/blender/blenkernel/intern/collection.cc:2182: scene_objects_iterator_begin(BLI_Iterator*, Scene*, GSet*) (0x35b7f87) ./blender.bin() ./source/blender/blenkernel/intern/collection.cc:2193: BKE_scene_objects_iterator_begin (0x35b8056) ./blender.bin() ./source/blender/blenkernel/intern/lib_override_proxy_conversion.cc:126: BKE_lib_override_library_main_proxy_convert(Main*, BlendFileReadReport*) (0x3f08530) ./blender.bin() ./source/blender/blenloader/intern/versioning_common.cc:522: do_versions_after_setup(Main*, BlendFileReadReport*) (0x4e43643) ./blender.bin() ./source/blender/blenloader/intern/readblenentry.cc:512: BLO_read_do_version_after_setup (0x4d1c740) ./blender.bin() ./source/blender/blenkernel/intern/blendfile.cc:880: setup_app_data(bContext*, BlendFileData*, BlendFileReadParams const*, BlendFileReadWMSetupData*, BlendFileReadReport*) (0x3520a67) ./blender.bin() ./source/blender/blenkernel/intern/blendfile.cc:956: setup_app_blend_file_data(bContext*, BlendFileData*, BlendFileReadParams const*, BlendFileReadWMSetupData*, BlendFileReadReport*) (0x3521081) ./blender.bin() ./source/blender/blenkernel/intern/blendfile.cc:994: BKE_blendfile_read_setup_readfile (0x35213c3) ./blender.bin() ./source/blender/windowmanager/intern/wm_files.cc:1067: WM_file_read(bContext*, char const*, ReportList*) (0x3033a5f) ./blender.bin() ./source/creator/creator_args.cc:2185 (discriminator 1): handle_load_file(bContext*, char const*, bool) (0x29c726d) ./blender.bin() ./source/creator/creator_args.cc:2256 (discriminator 1): main_args_handle_load_file (0x29c76c5) ./blender.bin() ./source/blender/blenlib/intern/BLI_args.c:322: BLI_args_parse (0x2fbfa62) ./blender.bin() ./source/creator/creator.cc:564: main (0x29bcaa4) /usr/lib/libc.so.6(+0x27cd0) ??:0: ?? (0x7fdfca627cd0) /usr/lib/libc.so.6(__libc_start_main+0x8a) ??:0: ?? (0x7fdfca627d8a) ./blender.bin() ??:?: _start (0x29bc125) BLI_assert failed: source/blender/blenkernel/intern/collection.cc:2101, scene_collections_array(), at 'collection != nullptr' ```

Campbell Barton added the

labels 2023-09-21 05:31:39 +02:00

Pratik Borhade commented

2023-09-21 06:04:00 +02:00

I can confirm the crash

Pratik Borhade added

and removed

labels 2023-09-21 06:04:19 +02:00

Pratik Borhade commented

2023-09-21 07:31:43 +02:00

Caused by 30a25a42e6
@mod_moder ^

Caused by 30a25a42e64daf697d82e94174dd9311aee46ad4 @mod_moder ^

Iliya Katushenock self-assigned this 2023-09-25 09:29:33 +02:00

Iliya Katushenock commented

2023-09-25 16:18:53 +02:00

I can't reproduce crash in 98b973294b , i'll bisect this...

I can't reproduce crash in 98b973294b5f0b3e4ff60cc85611db737e6b03d5 , i'll bisect this...

Iliya Katushenock removed their assignment 2023-09-25 16:19:12 +02:00

Iliya Katushenock commented

2023-09-25 21:21:52 +02:00

In 30a25a42e6 was introduced few regression, i hope all of this was fixed until 98b973294b. At least, that bug can not be reproduced in 98b973294b .
After bisect in range 98b973294b -- f6082a5042 : Causer is: 23835a393c .
Or someone in range 7f34ad736a -- 23835a393c .

@mont29 /

In 30a25a42e64daf697d82e94174dd9311aee46ad4 was introduced few regression, i hope all of this was fixed until 98b973294b5f0b3e4ff60cc85611db737e6b03d5. At least, that bug can not be reproduced in 98b973294b5f0b3e4ff60cc85611db737e6b03d5 . After bisect in range 98b973294b5f0b3e4ff60cc85611db737e6b03d5 -- f6082a5042db7cfe6c4617387a04f216a1ba3f99 : Causer is: 23835a393c80d23018e645338418446bd691dd7d . Or someone in range 7f34ad736ac12e10a96c6bf045e3f64b67a29cdd -- 23835a393c80d23018e645338418446bd691dd7d . @mont29 /

Campbell Barton commented

2023-09-26 00:17:34 +02:00

For me the crash happens in 30a25a42e6 and not in the previous commit 30a25a42e6~1, although it's always possible this is a red-herring somehow as it does seem more likely this is related to changes to the scene collection handling.

For me the crash happens in 30a25a42e6 and not in the previous commit 30a25a42e6~1, although it's always possible this is a red-herring somehow as it does seem more likely this is related to changes to the scene collection handling.

Iliya Katushenock commented

2023-09-26 11:03:02 +02:00

They have a different stack and the older crash was later fixed (Check 98b973294b as time point of worked state).

They have a different stack and the older crash was later fixed (Check 98b973294b5f0b3e4ff60cc85611db737e6b03d5 as time point of worked state).

Bastien Montagne commented

2023-09-26 15:36:21 +02:00

As @mod_moder found, this compatibility with very old early 2.80 dev files was removed on purpose in 23835a393c .

This file is Version 280 sub 4 date 2018-02-07, the removed code affects all version from 2.80 sub 1 to 2.80 sub 14 afaik.

Will try to find a way to avoid crash by adding a default collection/viewlayer in these cases when am back from holidays. But this is definitely not a high prio issue!

As @mod_moder found, this compatibility with very old early 2.80 dev files was removed on purpose in 23835a393c . This file is `Version 280 sub 4 date 2018-02-07`, the removed code affects all version from `2.80 sub 1` to `2.80 sub 14` afaik. Will try to find a way to avoid crash by adding a default collection/viewlayer in these cases when am back from holidays. But this is definitely _not_ a high prio issue!

Bastien Montagne self-assigned this 2023-09-26 15:36:32 +02:00

Bastien Montagne added

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Regression in 4.0, crash loading blend file without a scene collection #112649