blender
/
blender
133
398
Fork 579
Code Issues 6.3k Pull Requests 745 Projects 19 Wiki Activity

When Render Single Layer is enabled, switching to another View Layer and rendering a different frame range, Compositing File Output saves a frame of the previous (unwanted) layer #112769

New Issue
Open
opened 2023-09-23 11:05:32 +02:00 by Kirill Buzmakov · 3 comments
Kirill Buzmakov commented 2023-09-23 11:05:32 +02:00
Copy Link

System Information
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3060 Ti/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 536.23

Blender Version
Broken: version: 4.0.0 Alpha, branch: main, commit date: 2023-09-22 23:32, hash: 7c636c170273
Worked: -

Short description of error
When Render Single Layer is enabled, switching to another View Layer and rendering a different frame range, Compositing File Output saves the first frame (in the new frame range) of the previous (unwanted) layer.

Exact steps for others to reproduce the error

Per attached .blend:

  • Enable "Render Single Layer" in the View Layer tab in Properties.

  • In the "Cube" view layer, render out a sequence of frames (for example 5 to 10) using Compositing node "File Output". Use a separate folder for simpler reference (e.g. "Cube/Cube_")

  • Switch to the "Sphere" view layer. Change the frame range so that it includes new frames compared to before - for example, use 0-10. Render to another folder, e.g. Sphere/Sphere.

  • You will now notice that, despite using "Render Single Layer" and switching to Sphere, a new frame appeared in the Cube folder: Cube_0000 (or whatever other frame was first in the new sequence). This is incorrect behavior, in my opinion. Moreover, if the Cube already had a rendered frame in that range, it will get replaced by this new, incorrect frame.

**System Information** Operating system: Windows-10-10.0.19045-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3060 Ti/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 536.23 **Blender Version** Broken: version: 4.0.0 Alpha, branch: main, commit date: 2023-09-22 23:32, hash: `7c636c170273` Worked: - **Short description of error** When Render Single Layer is enabled, switching to another View Layer and rendering a different frame range, Compositing File Output saves the first frame (in the new frame range) of the previous (unwanted) layer. **Exact steps for others to reproduce the error** Per attached .blend: - Enable "Render Single Layer" in the View Layer tab in Properties. - In the "Cube" view layer, render out a sequence of frames (for example 5 to 10) using Compositing node "File Output". Use a separate folder for simpler reference (e.g. "Cube/Cube_") - Switch to the "Sphere" view layer. Change the frame range so that it includes new frames compared to before - for example, use 0-10. Render to another folder, e.g. Sphere/Sphere. - You will now notice that, despite using "Render **Single** Layer" and switching to Sphere, a new frame appeared in the Cube folder: Cube_0000 (or whatever other frame was first in the new sequence). This is incorrect behavior, in my opinion. Moreover, if the Cube already had a rendered frame in that range, it will get replaced by this new, incorrect frame.
RenderSingleLayer.blend
983 KiB
Kirill Buzmakov added the
Priority
Normal
Type
Report
Status
Needs Triage
 labels 2023-09-23 11:05:33 +02:00
Pratik Borhade commented 2023-09-25 07:59:55 +02:00
Member
Copy Link

Thanks for the report. Can confirm. Looks like an old issue (persists in 3.0 too)

Thanks for the report. Can confirm. Looks like an old issue (persists in 3.0 too)
Jesse Yurkovich added the
Module
VFX & Video
 label 2023-10-04 04:42:16 +02:00
Philipp Oeser commented 2024-04-18 09:16:50 +02:00
Member
Copy Link

This is due to a weak design where the previous RenderResult gets remembered (called pushedresult in code), the new single layer rendered (possibly on a different frame -- and this is where it breaks easily [but it also breaks when the pass structure is different in the layers]) and then in render_result_single_layer_end the layers that should be unaffected are replaced by what is found in the remembered pushedresult...which like I said can be from a different frame or can have different pass structure).

#95615 is related

This is due to a weak design where the previous `RenderResult` gets remembered (called `pushedresult` in code), the new single layer rendered (possibly on a different frame -- and this is where it breaks easily [but it also breaks when the pass structure is different in the layers]) and then in `render_result_single_layer_end` the layers that should be unaffected are replaced by what is found in the remembered `pushedresult`...which like I said can be from a different frame or can have different pass structure). #95615 is related
Philipp Oeser commented 2024-04-18 10:27:04 +02:00
Member
Copy Link

This is due to a weak design where the previous RenderResult gets remembered (called pushedresult in code), the new single layer rendered (possibly on a different frame -- and this is where it breaks easily [but it also breaks when the pass structure is different in the layers]) and then in render_result_single_layer_end the layers that should be unaffected are replaced by what is found in the remembered pushedresult...which like I said can be from a different frame or can have different pass structure).

#95615 is related

To demonstrate the problem, here is a quick hack that would skip replacing the (unwanted) layer in case the framenumbers dont match.
I have done no further test in regards to causing issues elsewhere and this has the consequence that the "other" layer would just be blank in the RenderResult [which of course is unwanted as well], but this would at least solve the issue of the unwanted FileOutput node overwriting behavior:

diff --git a/source/blender/render/intern/render_result.cc b/source/blender/render/intern/render_result.cc
index b811e60cade..fff1aa6283e 100644
--- a/source/blender/render/intern/render_result.cc
+++ b/source/blender/render/intern/render_result.cc
@@ -846,6 +846,7 @@ void render_result_single_layer_begin(Render *re)
   RE_FreeRenderResult(re->pushedresult);
 
   re->pushedresult = re->result;
+  re->pushedresult->framenr = re->r.cfra;
   re->result = nullptr;
 }
 
@@ -866,19 +867,26 @@ void render_result_single_layer_end(Render *re)
     RenderLayer *rl = static_cast<RenderLayer *>(re->result->layers.first);
 
     /* render result should be empty after this */
+    printf("render_result_single_layer_end removing %s from re->result->layers\n", rl->name);
     BLI_remlink(&re->result->layers, rl);
 
     /* reconstruct render result layers */
     LISTBASE_FOREACH (ViewLayer *, view_layer, &re->scene->view_layers) {
       if (STREQ(view_layer->name, re->single_view_layer)) {
+        printf("  render_result_single_layer_end adding %s frame %i to re->result->layers\n", re->single_view_layer, re->r.cfra);
         BLI_addtail(&re->result->layers, rl);
       }
       else {
         RenderLayer *rlpush = RE_GetRenderLayer(re->pushedresult, view_layer->name);
-        if (rlpush) {
+        if (rlpush && re->r.cfra == re->pushedresult->framenr) {
+          printf("  render_result_single_layer_end removing rlpush %s frame %i from re->pushedresult->layers\n", rlpush->name, re->pushedresult->framenr);
           BLI_remlink(&re->pushedresult->layers, rlpush);
+          printf("  render_result_single_layer_end adding  rlpush %s frame %i to re->result->layers\n", rlpush->name, re->pushedresult->framenr);
           BLI_addtail(&re->result->layers, rlpush);
         }
+        else {
+          printf("  render_result_single_layer_end skipping rlpush %s (frame %i does not match current frame %i)\n", rlpush->name, re->pushedresult->framenr, re->r.cfra);
+        }
       }
     }
   }
> This is due to a weak design where the previous `RenderResult` gets remembered (called `pushedresult` in code), the new single layer rendered (possibly on a different frame -- and this is where it breaks easily [but it also breaks when the pass structure is different in the layers]) and then in `render_result_single_layer_end` the layers that should be unaffected are replaced by what is found in the remembered `pushedresult`...which like I said can be from a different frame or can have different pass structure). > > #95615 is related To demonstrate the problem, here is a quick hack that would skip replacing the (unwanted) layer in case the framenumbers dont match. I have done no further test in regards to causing issues elsewhere and this has the consequence that the "other" layer would just be blank in the RenderResult [which of course is unwanted as well], but this would at least solve the issue of the unwanted FileOutput node overwriting behavior: ```diff diff --git a/source/blender/render/intern/render_result.cc b/source/blender/render/intern/render_result.cc index b811e60cade..fff1aa6283e 100644 --- a/source/blender/render/intern/render_result.cc +++ b/source/blender/render/intern/render_result.cc @@ -846,6 +846,7 @@ void render_result_single_layer_begin(Render *re) RE_FreeRenderResult(re->pushedresult); re->pushedresult = re->result; + re->pushedresult->framenr = re->r.cfra; re->result = nullptr; } @@ -866,19 +867,26 @@ void render_result_single_layer_end(Render *re) RenderLayer *rl = static_cast<RenderLayer *>(re->result->layers.first); /* render result should be empty after this */ + printf("render_result_single_layer_end removing %s from re->result->layers\n", rl->name); BLI_remlink(&re->result->layers, rl); /* reconstruct render result layers */ LISTBASE_FOREACH (ViewLayer *, view_layer, &re->scene->view_layers) { if (STREQ(view_layer->name, re->single_view_layer)) { + printf(" render_result_single_layer_end adding %s frame %i to re->result->layers\n", re->single_view_layer, re->r.cfra); BLI_addtail(&re->result->layers, rl); } else { RenderLayer *rlpush = RE_GetRenderLayer(re->pushedresult, view_layer->name); - if (rlpush) { + if (rlpush && re->r.cfra == re->pushedresult->framenr) { + printf(" render_result_single_layer_end removing rlpush %s frame %i from re->pushedresult->layers\n", rlpush->name, re->pushedresult->framenr); BLI_remlink(&re->pushedresult->layers, rlpush); + printf(" render_result_single_layer_end adding rlpush %s frame %i to re->result->layers\n", rlpush->name, re->pushedresult->framenr); BLI_addtail(&re->result->layers, rlpush); } + else { + printf(" render_result_single_layer_end skipping rlpush %s (frame %i does not match current frame %i)\n", rlpush->name, re->pushedresult->framenr, re->r.cfra); + } } } } ```
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
brush-assets-project
universal-scene-description
fix-121021
blender-v4.1-release
blender-v3.3-release
blender-v3.6-release
blender-v3.6-temp_wmoss_animrig_public
temp-sculpt-dyntopo
gpencil-next
anim/animation-id-113594
blender-v4.0-release
blender-projects-basics
bridge-curves
sculpt-blender
asset-browser-frontend-split
asset-shelf
tmp-usd-python-mtl
tmp-usd-3.6
blender-v3.5-release
blender-v2.93-release
realtime-clock
sculpt-dev
bevelv2
xr-dev
v4.1.1
v3.6.11
v3.3.18
v4.1.0
v3.3.17
v3.6.10
v3.6.9
v3.3.16
v3.6.8
v3.6.7
v3.3.14
v4.0.2
v4.0.1
v4.0.0
v3.6.5
v3.3.12
v3.6.4
v3.6.3
v3.3.11
v3.6.2
v3.3.10
v3.6.1
v3.3.9
v3.6.0
v3.3.8
v3.3.7
v2.93.18
v3.5.1
v3.3.6
v2.93.17
v3.5.0
v2.93.16
v3.3.5
v3.3.4
v2.93.15
v2.93.14
v3.3.3
v2.93.13
v2.93.12
v3.4.1
v3.3.2
v3.4.0
v3.3.1
v2.93.11
v3.3.0
v3.2.2
v2.93.10
v3.2.1
v3.2.0
v2.83.20
v2.93.9
v3.1.2
v3.1.1
v3.1.0
v2.83.19
v2.93.8
v3.0.1
v2.93.7
v3.0.0
v2.93.6
v2.93.5
v2.83.18
v2.93.4
v2.93.3
v2.83.17
v2.93.2
v2.93.1
v2.83.16
v2.93.0
v2.83.15
v2.83.14
v2.83.13
v2.92.0
v2.83.12
v2.91.2
v2.83.10
v2.91.0
v2.83.9
v2.83.8
v2.83.7
v2.90.1
v2.83.6.1
v2.83.6
v2.90.0
v2.83.5
v2.83.4
v2.83.3
v2.83.2
v2.83.1
v2.83
v2.82a
v2.82
v2.81a
v2.81
v2.80
v2.80-rc3
v2.80-rc2
v2.80-rc1
v2.79b
v2.79a
v2.79
v2.79-rc2
v2.79-rc1
v2.78c
v2.78b
v2.78a
v2.78
v2.78-rc2
v2.78-rc1
v2.77a
v2.77
v2.77-rc2
v2.77-rc1
v2.76b
v2.76a
v2.76
v2.76-rc3
v2.76-rc2
v2.76-rc1
v2.75a
v2.75
v2.75-rc2
v2.75-rc1
v2.74
v2.74-rc4
v2.74-rc3
v2.74-rc2
v2.74-rc1
v2.73a
v2.73
v2.73-rc1
v2.72b
2.72b
v2.72a
v2.72
v2.72-rc1
v2.71
v2.71-rc2
v2.71-rc1
v2.70a
v2.70
v2.70-rc2
v2.70-rc
v2.69
v2.68a
v2.68
v2.67b
v2.67a
v2.67
v2.66a
v2.66
v2.65a
v2.65
v2.64a
v2.64
v2.63a
v2.63
v2.61
v2.60a
v2.60
v2.59
v2.58a
v2.58
v2.57b
v2.57a
v2.57
v2.56a
v2.56
v2.55
v2.54
v2.53
v2.52
v2.51
v2.50
v2.49b
v2.49a
v2.49
v2.48a
v2.48
v2.47
v2.46
v2.45
v2.44
v2.43
v2.42a
v2.42
v2.41
v2.40
v2.37a
v2.37
v2.36
v2.35a
v2.35
v2.34
v2.33a
v2.33
v2.32
v2.31a
v2.31
v2.30
v2.28c
v2.28a
v2.28
v2.27
v2.26
v2.25
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset Browser

  
Interest
Asset Browser Project Overview

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
This issue affects/is about backward or forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
EEVEE & Viewport

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Issues relating to Wayland windowing support.

  
Interest
Workbench

  
Interest: X11

Issues relating to Xorg/X11 support.

  
Legacy
Blender 2.8 Project

  
Legacy
Milestone 1: Basic, Local Asset Browser

  
Legacy
OpenGL Error

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
EEVEE & Viewport

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#112769
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?