Override mesh datablock add/remove/edit attributes #112791

Open
opened 2023-09-23 21:39:15 +02:00 by sanek122005 · 3 comments

System Information
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: NVIDIA GeForce MX230/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 531.79

Blender Version
Broken: version: 4.0.0 Alpha, branch: main, commit date: 2023-09-22 23:32, hash: 7c636c170273
Worked: (newest version of Blender that worked as expected)

Short description of error
when overriding the mesh datablock, it becomes possible to add and remove attributes. however, this is the only possibility, it is still impossible to change the name of attributes, add uv maps, vertex groups
is this exactly how it should work?

Exact steps for others to reproduce the error

  1. Link and override mesh object
  2. Override mesh datablock
**System Information** Operating system: Windows-10-10.0.19045-SP0 64 Bits Graphics card: NVIDIA GeForce MX230/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 531.79 **Blender Version** Broken: version: 4.0.0 Alpha, branch: main, commit date: 2023-09-22 23:32, hash: `7c636c170273` Worked: (newest version of Blender that worked as expected) **Short description of error** when overriding the mesh datablock, it becomes possible to add and remove attributes. however, this is the only possibility, it is still impossible to change the name of attributes, add uv maps, vertex groups is this exactly how it should work? <video src="/attachments/922c0496-3f1e-487c-a084-406f70105791" title="2023-09-23 22-35-06.mp4" controls></video> **Exact steps for others to reproduce the error** 1. Link and override mesh object 2. Override mesh datablock
sanek122005 added the
Type
Report
Priority
Normal
Status
Needs Triage
labels 2023-09-23 21:39:16 +02:00
Member

Adding and removing should probably not be allowed even, this does not survive save/reload.
Probably the same as e.g. UVMaps or Vertex Groups where this is prohibited.

Will check on this.

Adding and removing should probably not be allowed even, this does not survive save/reload. Probably the same as e.g. UVMaps or Vertex Groups where this is prohibited. Will check on this.
Philipp Oeser added
Status
Confirmed
and removed
Status
Needs Triage
labels 2023-09-25 10:23:37 +02:00
Member

Not quite sure why geometry_attributes_poll / BKE_id_is_editable only checks with BKE_lib_override_library_is_system_defined whereas layers_poll is more strict and checks with ID_IS_OVERRIDE_LIBRARY(data)

CC @mont29

Not quite sure why `geometry_attributes_poll` / `BKE_id_is_editable` only checks with `BKE_lib_override_library_is_system_defined` whereas `layers_poll` is more strict and checks with `ID_IS_OVERRIDE_LIBRARY(data)` CC @mont29
Philipp Oeser changed title from Override mesh datablock works is incorrectly? to Override mesh datablock add/remove/edit attributes 2023-09-25 10:38:47 +02:00
Philipp Oeser added the
Interest
Overrides
Module
Core
labels 2023-09-25 10:39:01 +02:00

I have no idea, I did not write this code at all. Indeed, editing attributes in any way should be forbidden currently in mesh data. I guess geometry_attributes_poll is not doing a strict check enough (Mesh ID is editable, since it's not linked, but not all of its data!).

I have no idea, I did not write this code at all. Indeed, editing attributes in any way should be forbidden currently in mesh data. I guess `geometry_attributes_poll` is not doing a strict check enough (Mesh ID _is_ editable, since it's not linked, but not all of its data!).
Bastien Montagne added
Module
Modeling
Interest
Core
and removed
Module
Core
labels 2023-10-04 18:24:53 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#112791
No description provided.