Sculpt Mode - Draw Face Sets not working after choosing commands from Face Set menu #112817

New Issue

RumenBelev · 2023-09-24T21:51:35+02:00

RumenBelev commented

2023-09-24 21:51:35 +02:00

System Information
Operating system: Windows-8.1-6.3.9600-SP0 64 Bits
Graphics card: GeForce GTX 760M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 425.31

Blender Version
Broken: version: 3.6.3, branch: blender-v3.6-release, commit date: 2023-09-21 06:06, hash: d3e6b08276ba
Worked: Unknown

Short description of error
Sculpt Mode - Draw Face Sets not working after choosing commands from Face Set menu

Exact steps for others to reproduce the error

Start with new file.
Add Icosphere with 4-5 subdivisions (any mesh for sculpting would do)
Switch to Sculpt Mode
Select Draw Face Sets Tool and draw one or more strokes on the mesh (to confirm its working)
Applying any of the following operations will disable the Draw Face Sets Tool from further use:

5a. Use Shift+W or from the menu Face Sets > Expand Face Set by Topology
5b. Use Shift+Alt+W or from the menu Face Sets > Expand Active Face Set

The above operations are performed without problem, but after confirmation of the operation the Draw Face Sets Tool is no longer working - cannot draw any new face sets.

Observations:
Switching from any other interaction mode back to Sculpt mode re-enables the tool, but the issue can be reproduced if repeated steps 5a or 5b
Canceling these operation with Esc do not affect the Draw Face Sets Tool.
Changing to any sculpting tools and back to Draw Face Sets Tool - without leaving Sculpt mode does not clear the issue.
Some sculpting tools also do not work if enabled after the lock - like Grab, Pinch, Rotate, Smooth, Draw, etc. Some of them work - like Elastic Deform, Pose.

If you use Mask Tool before step 4 the above bug cannot be reproduced unless starting a new file.

**System Information** Operating system: Windows-8.1-6.3.9600-SP0 64 Bits Graphics card: GeForce GTX 760M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 425.31 **Blender Version** Broken: version: 3.6.3, branch: blender-v3.6-release, commit date: 2023-09-21 06:06, hash: `d3e6b08276ba` Worked: Unknown **Short description of error** Sculpt Mode - Draw Face Sets not working after choosing commands from Face Set menu **Exact steps for others to reproduce the error** 1. Start with new file. 2. Add Icosphere with 4-5 subdivisions (any mesh for sculpting would do) 3. Switch to Sculpt Mode 4. Select Draw Face Sets Tool and draw one or more strokes on the mesh (to confirm its working) Applying any of the following **operations** will disable the Draw Face Sets Tool from further use: 5a. Use Shift+W or from the menu Face Sets > Expand Face Set by Topology 5b. Use Shift+Alt+W or from the menu Face Sets > Expand Active Face Set The above **operations** are performed without problem, but after confirmation of the operation the Draw Face Sets Tool is no longer working - cannot draw any new face sets. Observations: Switching from any other interaction mode back to Sculpt mode re-enables the tool, but the issue can be reproduced if repeated steps 5a or 5b Canceling these **operation** with Esc do not affect the Draw Face Sets Tool. Changing to any sculpting tools and back to Draw Face Sets Tool - without leaving Sculpt mode does not clear the issue. Some sculpting tools also do not work if enabled after the lock - like Grab, Pinch, Rotate, Smooth, Draw, etc. Some of them work - like Elastic Deform, Pose. If you use Mask Tool before step 4 the above bug cannot be reproduced unless starting a new file.

RumenBelev added the

labels 2023-09-24 21:51:35 +02:00

Omar-Mokhtar commented

2023-09-24 23:00:36 +02:00

I think this is still the behavior in the latest main.
Just tested it on:
Blender 4.0.0 Alpha
build date: 2023-09-24
build time: 20:41:55
build commit date: 2023-09-24
build commit time: 20:37
build hash: eef2a706b4
build platform: Linux

I think this is still the behavior in the latest main. Just tested it on: Blender 4.0.0 Alpha build date: 2023-09-24 build time: 20:41:55 build commit date: 2023-09-24 build commit time: 20:37 build hash: eef2a706b452 build platform: Linux

Omar-Mokhtar commented

2023-09-25 01:11:17 +02:00

It seems that it has something to do with:

node_update_mask_redraw(PBVH &pbvh, PBVHNode &node) in source/blender/blenkernel/intern/pbvh.cc

Where PBVHNode flags gets set with PBVH_FullyUnmasked and PBVH_FullyMasked but it doesn't get unset later.

And it worked properly when I added this at the end of sculpt_expand_finish in source/blender/editors/sculpt_paint/sculpt_expand.cc:

for (PBVHNode *node : nodes) {
BKE_pbvh_node_fully_masked_set(node, false);
BKE_pbvh_node_fully_unmasked_set(node, false);
}

Just resetting these flags after the expand operation (using Shift+W) is done.

It seems that it has something to do with: **node_update_mask_redraw(PBVH &pbvh, PBVHNode &node)** in **source/blender/blenkernel/intern/pbvh.cc** Where PBVHNode flags gets set with PBVH_FullyUnmasked and PBVH_FullyMasked but it doesn't get unset later. And it worked properly when I added this at the end of **sculpt_expand_finish** in **source/blender/editors/sculpt_paint/sculpt_expand.cc**: `for (PBVHNode *node : nodes) {` ` BKE_pbvh_node_fully_masked_set(node, false);` ` BKE_pbvh_node_fully_unmasked_set(node, false);` `}` Just resetting these flags after the expand operation (using Shift+W) is done.

👍 1

~~Omar-Mokhtar referenced this issue 2023-09-25 01:49:49 +02:00~~

Fix #112817: Draw Face Sets not working #112824

Iliya Katushenock referenced a pull request that will close this issue

2023-09-25 01:52:28 +02:00

Fix #112817: Draw Face Sets not working #112824

Pratik Borhade commented

2023-09-25 07:38:25 +02:00

Can confirm the regression (broke between 3.3 - 3.4)

👍 1

Pratik Borhade added

Module