bpy.ops undo argument doesn't work if the main operator has UNDO in bl_options #112851

New Issue

Andrej · 2023-09-25T14:39:22+02:00

Andrej commented

2023-09-25 14:39:22 +02:00

Blender 3.6.3

When I run some operator with bpy.ops.object.test_operator_undo(True) (with undo argument = True) from operator bpy.ops.object.test_operator that has "UNDO" in the bl_options, undo argument doesn't work - it doesn't create undo step and doesn't allow redo.

Steps to reproduce:

Default Blender scene
Run the code below
F3 - Test Operator
F9 (redo) shows "Test Operator" when bpy.ops.object.test_operator_undo was called with True as undo argument which suppose to create an undo step for this operator so that it will be possible to redo it.
If you remove UNDO from TestOperator bl_options (meaning commenting line 7 and uncomment line 8) and run the code and operator again
F9 now shows "Undo Test Operator" but now it's not possible to redo the TestOperator in case if it finishes without calling another operator (if some_condition was True).
I've found that I can add bpy.ops.ed.undo_push(message='Test Operator') to make sure it still will be possible to atleast undo it but redo is not available.

import bpy


class TestOperator(bpy.types.Operator):
    bl_idname = "object.test_operator"
    bl_label = "Test Operator"
    bl_options = {"REGISTER", "UNDO"}
#    bl_options = {"REGISTER"}

    def execute(self, context):
#        bpy.ops.ed.undo_push(message='Test Operator')
        some_condition = False
        if some_condition:
            context.object.location = (0,0,0)
        else:
            bpy.ops.object.test_operator_undo(True)
        return {'FINISHED'}
    
class TestOperatorUndo(bpy.types.Operator):
    bl_idname = "object.test_operator_undo"
    bl_label = "Undo Test Operator"
    bl_options = {"REGISTER", "UNDO"}
    test: bpy.props.IntProperty()

    def execute(self, context):
        print('hello')
        return {'FINISHED'}
    
def register():
    bpy.utils.register_class(TestOperator)
    bpy.utils.register_class(TestOperatorUndo)

def unregister():
    bpy.utils.unregister_class(TestOperator)
    bpy.utils.unregister_class(TestOperatorUndo)


if __name__ == "__main__":
    register()

Blender 3.6.3 When I run some operator with `bpy.ops.object.test_operator_undo(True)` (with undo argument = `True`) from operator `bpy.ops.object.test_operator` that has "UNDO" in the `bl_options`, undo argument doesn't work - it doesn't create undo step and doesn't allow redo. Steps to reproduce: 1) Default Blender scene 2) Run the code below 3) F3 - Test Operator 4) F9 (redo) shows "Test Operator" when` bpy.ops.object.test_operator_undo` was called with `True` as [undo argument](https://docs.blender.org/api/current/bpy.ops.html#keywords-and-positional-arguments) which suppose to create an undo step for this operator so that it will be possible to redo it. 5) If you remove UNDO from TestOperator bl_options (meaning commenting line 7 and uncomment line 8) and run the code and operator again F9 now shows "Undo Test Operator" but now it's not possible to redo the TestOperator in case if it finishes without calling another operator (if `some_condition` was `True`). I've found that I can add `bpy.ops.ed.undo_push(message='Test Operator')` to make sure it still will be possible to atleast undo it but redo is not available. ```python import bpy class TestOperator(bpy.types.Operator): bl_idname = "object.test_operator" bl_label = "Test Operator" bl_options = {"REGISTER", "UNDO"} # bl_options = {"REGISTER"} def execute(self, context): # bpy.ops.ed.undo_push(message='Test Operator') some_condition = False if some_condition: context.object.location = (0,0,0) else: bpy.ops.object.test_operator_undo(True) return {'FINISHED'} class TestOperatorUndo(bpy.types.Operator): bl_idname = "object.test_operator_undo" bl_label = "Undo Test Operator" bl_options = {"REGISTER", "UNDO"} test: bpy.props.IntProperty() def execute(self, context): print('hello') return {'FINISHED'} def register(): bpy.utils.register_class(TestOperator) bpy.utils.register_class(TestOperatorUndo) def unregister(): bpy.utils.unregister_class(TestOperator) bpy.utils.unregister_class(TestOperatorUndo) if __name__ == "__main__": register() ```

Andrej added the

labels 2023-09-25 14:39:23 +02:00

Germano Cavalcante commented

2023-09-26 00:17:48 +02:00

That undo parameter is confusing, but I can confirm that it doesn't seem to be working in this case.

This parameter was implemented in a09feb7386 by @ideasman42

That `undo` parameter is confusing, but I can confirm that it doesn't seem to be working in this case. This parameter was implemented in a09feb7386 by @ideasman42

Germano Cavalcante added

and removed

labels 2023-09-26 00:18:02 +02:00

Sign in to join this conversation.