Nodes: Can't select Reroute nodes #112856

New Issue

Open

opened 2023-09-25 15:16:04 +02:00 by Philipp Oeser · 7 comments

Philipp Oeser commented

2023-09-25 15:16:04 +02:00

Member

System Information
Operating system: Linux-6.4.15-200.fc38.x86_64-x86_64-with-glibc2.37 64 Bits, X11 UI
Graphics card: NVIDIA GeForce RTX 3080 Laptop GPU/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 535.104.05

Blender Version
Broken: version: 4.0.0 Alpha, branch: main, commit date: 2023-09-25 00:25, hash: 407e2b9f700f
Worked: (newest version of Blender that worked as expected)

It is caused by 271f34f77e

Short description of error
Cant select reroute nodes (always spawns context menu) in Geometry Nodes editor (Shader Editor is fine).

Exact steps for others to reproduce the error

Use Select With RMB in Preferences.
Turn on Developer Extras in Preferences.
Switch to the Geometry Nodes workspace.
Add a Reroute node.
Try to select it with the right mouse button.
A context menu is spawned (a single entry: Edit Source which never makes sense in the node editor since this is not py UI code).

**System Information** Operating system: Linux-6.4.15-200.fc38.x86_64-x86_64-with-glibc2.37 64 Bits, X11 UI Graphics card: NVIDIA GeForce RTX 3080 Laptop GPU/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 535.104.05 **Blender Version** Broken: version: 4.0.0 Alpha, branch: main, commit date: 2023-09-25 00:25, hash: `407e2b9f700f` Worked: (newest version of Blender that worked as expected) It is caused by 271f34f77e056611e5e227b60823dd94f76340df **Short description of error** Cant select reroute nodes (always spawns context menu) in Geometry Nodes editor (Shader Editor is fine). **Exact steps for others to reproduce the error** 1. Use Select With RMB in Preferences. 2. Turn on Developer Extras in Preferences. 3. Switch to the Geometry Nodes workspace. 4. Add a Reroute node. 5. Try to select it with the right mouse button. 6. A context menu is spawned (a single entry: `Edit Source` which never makes sense in the node editor since this is not py UI code).

Philipp Oeser added the

labels 2023-09-25 15:16:05 +02:00

Iliya Katushenock changed title from ~~Cant select Reroute nodes (always spawns context menu) in Geometry Nodes editor (Shader Editor is fine)~~ to Regression: Can't select Reroute nodes

2023-09-25 15:21:57 +02:00

Iliya Katushenock added the

Nodes & Physics

labels 2023-09-25 15:22:01 +02:00

YimingWu commented

2023-09-25 15:29:56 +02:00

Member

Additionally:

I can right click select reroute socket in shader editor
Right click on foldable ui lists in a shader node will also give me an "Edit Source" menu instead of selecting a node.

Additionally: - I can right click select reroute socket in shader editor - Right click on foldable ui lists in a shader node will also give me an "Edit Source" menu instead of selecting a node. ![图片](/attachments/a54d6c03-a51f-421c-acf0-175f442e6bd9)

16 KiB

Iliya Katushenock changed title from ~~Regression: Can't select Reroute nodes~~ to Nodes: Can't select Reroute nodes

2023-09-25 22:08:11 +02:00

Iliya Katushenock added

Nodes & Physics

and removed

Nodes & Physics

labels 2023-09-25 22:08:23 +02:00

Semen Komissarov commented

2023-09-27 21:17:52 +02:00

If it's not urgent I would try to make sense of it. I'm new to the codebase, probably will take some time.

If it's not urgent I would try to make sense of it. I'm new to the codebase, probably will take some time.

Semen Komissarov commented

2023-09-28 14:08:01 +02:00

I reproduced it yesterday.
It is also reproducable for release version: 3.6.1, branch: blender-v3.6-release, commit date: 2023-07-17 12:50, hash: 8bda729ef4dc, type: release

But after pulling latest changes from main branch issue dissapeared. Please confirm its gone?

I reproduced it yesterday. It is also reproducable for release `version: 3.6.1, branch: blender-v3.6-release, commit date: 2023-07-17 12:50, hash: 8bda729ef4dc, type: release` But after pulling latest changes from main branch issue dissapeared. Please confirm its gone?

Philipp Oeser commented

2023-09-28 14:48:06 +02:00

Author

Member

Nope, I can still repro.
Maybe your Preferences changed? (or were not correctly copied from 4.0 to 4.1?)
Please check again with the repro steps (these include stuff in Preferences)

Nope, I can still repro. Maybe your Preferences changed? (or were not correctly copied from 4.0 to 4.1?) Please check again with the repro steps (these include stuff in Preferences)

Semen Komissarov commented

2023-09-28 15:08:34 +02:00

yep, still reproducible for 4.1, its just preferences switched to default

yep, still reproducible for 4.1, its just preferences switched to default

Philipp Oeser commented

2023-09-29 16:48:35 +02:00

Author

Member

It is caused by 271f34f77e

Since above commit we now have an invisible and disabled button over the sockets (for the tooltips), maybe we can leverage the fact that it is disabled and invisible, so that context menus are not spawned on them @JacquesLucke ?

It is caused by 271f34f77e056611e5e227b60823dd94f76340df Since above commit we now have an invisible and disabled button over the sockets (for the tooltips), maybe we can leverage the fact that it is disabled and invisible, so that context menus are not spawned on them @JacquesLucke ?

Semen Komissarov referenced a pull request that will close this issue

2023-10-13 01:12:34 +02:00

WIP: Fix #112856: Remove "Edit Source" overwriting context menu for uneditable elements. #113635

Jacques Lucke commented

2024-03-10 15:36:46 +01:00

Member

Hm tricky, I think in general it should be possible to have context menus on sockets. We might need that at some point. Might be ok to have some special case here so that right click does not open the context menu when clicking the RMB, if RMB-selection is used.
For LMB-selection, the behavior shouldn't change.

Hm tricky, I think in general it should be possible to have context menus on sockets. We might need that at some point. Might be ok to have some special case here so that right click does not open the context menu when clicking the RMB, if RMB-selection is used. For LMB-selection, the behavior shouldn't change.

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

4 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#112856

No description provided.