Outliner: Bones appear in different places in different modes #112904

New Issue

Closed

opened 2023-09-26 14:35:01 +02:00 by Nika Kutsniashvili · 8 comments

Nika Kutsniashvili commented

2023-09-26 14:35:01 +02:00

Contributor

System Information
Operating system: Windows-10-10.0.19043-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1650/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 536.99

Blender Version
Broken: version: 4.0.0 Alpha, branch: main, commit date: 2023-09-19 08:47, hash: 78315faf8fbd
Worked: (newest version of Blender that worked as expected)

Short description of error

Incosistent behavior when bones appear under Armature in Object Mode, but under Pose in Pose mode. I don't know if it's by design but it's very confusing

Exact steps for others to reproduce the error
[Please describe the exact steps needed to reproduce the issue]
[Based on the default startup or an attached .blend file (as simple as possible)]

**System Information** Operating system: Windows-10-10.0.19043-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1650/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 536.99 **Blender Version** Broken: version: 4.0.0 Alpha, branch: main, commit date: 2023-09-19 08:47, hash: `78315faf8fbd` Worked: (newest version of Blender that worked as expected) **Short description of error** ![image](/attachments/c2359ecd-b317-4c39-9d34-f789451ee222) Incosistent behavior when bones appear under Armature in Object Mode, but under Pose in Pose mode. I don't know if it's by design but it's very confusing **Exact steps for others to reproduce the error** [Please describe the exact steps needed to reproduce the issue] [Based on the default startup or an attached .blend file (as simple as possible)]

29 KiB

Nika Kutsniashvili added the

labels 2023-09-26 14:35:02 +02:00

Pratik Borhade commented

2023-09-26 14:58:18 +02:00

Member

Thanks for the report. I can confirm

Thanks for the report. I can confirm

Pratik Borhade added

Animation & Rigging

and removed

labels 2023-09-26 14:58:39 +02:00

Julian Eisel added

Animation & Rigging

and removed

Animation & Rigging

labels 2023-09-26 15:43:11 +02:00

Julian Eisel commented

2023-09-26 15:44:15 +02:00

Member

The animation module recently introduced the new bone collections to the Outliner, assigning the report to them.

The animation module recently introduced the new bone collections to the Outliner, assigning the report to them.

Pratik Borhade commented

2023-09-26 15:52:22 +02:00

Member

Yeah. But bug seems to be related to tree drawing. I'll submit the PR
Quick fix to this will be (This will at least not change the order):
Current order is: edit bones -> bone collection -> pose base/channels
Old order was: edit bones -> pose base/ channels -> bone groups (this is because bone groups were created in expand_pose())

diff --git a/source/blender/editors/space_outliner/tree/tree_element_id_object.cc b/source/blender/editors/space_outliner/tree/tree_element_id_object.cc
index 1bd382ca772..3468b36cae7 100644
--- a/source/blender/editors/space_outliner/tree/tree_element_id_object.cc
+++ b/source/blender/editors/space_outliner/tree/tree_element_id_object.cc
@@ -40,9 +40,8 @@ void TreeElementIDObject::expand(SpaceOutliner & /*space_outliner*/) const
   object_.id.newid = (ID *)(&legacy_te_);

   expand_animation_data(object_.adt);
-
-  expand_data();
   expand_pose();
+  expand_data();
   expand_materials();
   expand_constraints();
   expand_modifiers();

Yeah. But bug seems to be related to tree drawing. I'll submit the PR Quick fix to this will be (This will at least not change the order): Current order is: edit bones -> bone collection -> pose base/channels Old order was: edit bones -> pose base/ channels -> bone groups (this is because bone groups were created in expand_pose()) ```Diff diff --git a/source/blender/editors/space_outliner/tree/tree_element_id_object.cc b/source/blender/editors/space_outliner/tree/tree_element_id_object.cc index 1bd382ca772..3468b36cae7 100644 --- a/source/blender/editors/space_outliner/tree/tree_element_id_object.cc +++ b/source/blender/editors/space_outliner/tree/tree_element_id_object.cc @@ -40,9 +40,8 @@ void TreeElementIDObject::expand(SpaceOutliner & /*space_outliner*/) const object_.id.newid = (ID *)(&legacy_te_); expand_animation_data(object_.adt); - - expand_data(); expand_pose(); + expand_data(); expand_materials(); expand_constraints(); expand_modifiers(); ```

Pratik Borhade self-assigned this 2023-09-26 15:59:46 +02:00

Pratik Borhade referenced a pull request that will close this issue

2023-09-26 16:02:23 +02:00

Fix #112904: Outliner: Bones appear in different places in different modes #112908

Pratik Borhade referenced this issue from a commit

2023-09-26 17:26:37 +02:00

Fix #112904: Outliner: Bones appear in different places in different modes

Pratik Borhade closed this issue

2023-09-26 17:26:39 +02:00

Blender Bot added

and removed

labels 2023-09-26 17:27:25 +02:00

Nika Kutsniashvili commented

2024-02-15 20:17:23 +01:00

Author

Contributor

@PratikPB2123 this is still present in 4.1 beta

@PratikPB2123 this is still present in 4.1 beta

Pratik Borhade commented

2024-02-19 10:40:44 +01:00

Member

Hi, don't think so. If you see change in "bones" order then this is expected. Bone collection are at same position since my fix

Edit mode	Pose mode

Hi, don't think so. If you see change in "bones" order then this is expected. Bone collection are at same position since my fix | Edit mode | Pose mode | | -- | -- | | ![bcol-edit-mode](/attachments/1260e6f8-0fb8-4742-986c-b04724983f30) | ![bcol-pose-mode](/attachments/4fbf6931-2813-4ec5-bc9b-ef5ba4533312) |

912 KiB

bcol-pose-mode.png

28 KiB

bcol-edit-mode.png

27 KiB

Nika Kutsniashvili commented

2024-02-19 10:49:45 +01:00

Author

Contributor

Why is that expected? Its very confusing seeing items jump in Outliner when you switch mode.

Why is that expected? Its very confusing seeing items jump in Outliner when you switch mode.

Pratik Borhade commented

2024-02-19 11:27:43 +01:00

Member

Because two different types of bones are displayed in outliner (edit-bone and pose-bone)
Edit-bones are drawn under Armature and Pose-bones are drawn below Pose tree-element.
This is same since many versions btw.

Because two different types of bones are displayed in outliner (edit-bone and pose-bone) Edit-bones are drawn under `Armature` and Pose-bones are drawn below `Pose` tree-element. This is same since many versions btw.

Nika Kutsniashvili commented

2024-02-19 11:30:22 +01:00

Author

Contributor

Understandable. But this doesn't seem something that concerns users tbh, thanks.

Understandable. But this doesn't seem something that concerns users tbh, thanks.

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#112904

No description provided.