Geometry Nodes: Subdivide Surface Node Performance Discrepancy Due to 'Use Limit Surface' Option #112912

New Issue

Open

opened 2023-09-26 16:40:31 +02:00 by baoyu · 7 comments

baoyu commented

2023-09-26 16:40:31 +02:00

System Information
Operating system: Windows-10-10.0.22621-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2080/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 536.99

Blender Version
Broken: version: 4.0.0 Alpha, branch: main, commit date: 2023-09-25 21:53, hash: 2aa393e72771
Worked: (newest version of Blender that worked as expected)

Short description of error
When using the subdivide surface node in geometry nodes (especially dealing with large amount of points), it slows down the whole peformance a lot compared to the Subdivision Modifier.
Around 3~5x slower from my personal observation.

Exact steps for others to reproduce the error
I made a demo file:
A mesh with 54121 points, subd level 2.
Enable one mesh and disable the other, then watch the play back fps
GN subd: ~0.6 fps / Subd modifier: ~2.7 fps

**System Information** Operating system: Windows-10-10.0.22621-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 2080/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 536.99 **Blender Version** Broken: version: 4.0.0 Alpha, branch: main, commit date: 2023-09-25 21:53, hash: `2aa393e72771` Worked: (newest version of Blender that worked as expected) **Short description of error** When using the subdivide surface node in geometry nodes (especially dealing with large amount of points), it slows down the whole peformance a lot compared to the Subdivision Modifier. Around 3~5x slower from my personal observation. **Exact steps for others to reproduce the error** I made a demo file: A mesh with 54121 points, subd level 2. Enable one mesh and disable the other, then watch the play back fps `GN subd: ~0.6 fps / Subd modifier: ~2.7 fps`

subd surface in GN VS Modifier.blend

4.0 MiB

baoyu added the

labels 2023-09-26 16:40:32 +02:00

Iliya Katushenock added the

Nodes & Physics

labels 2023-09-26 16:44:41 +02:00

YimingWu commented

2023-09-27 04:17:16 +02:00

Member

It is possible that the difference is caused by the viewport GPU subdivision, which isn't implemented in GN at the moment. Otherwise in my test it's not prominent enough.

Edit:

From your test file both mesh gives me around 0.3~0.5 fps.

It is possible that the difference is caused by the viewport GPU subdivision, which isn't implemented in GN at the moment. Otherwise in my test it's not prominent enough. Edit: From your test file both mesh gives me around 0.3~0.5 fps.

YimingWu added

Nodes & Physics

Needs Info from Developers

and removed

labels 2023-09-27 04:19:36 +02:00

baoyu commented

2023-09-27 08:55:56 +02:00

Author

It is possible that the difference is caused by the viewport GPU subdivision, which isn't implemented in GN at the moment. Otherwise in my test it's not prominent enough.

Edit:

From your test file both mesh gives me around 0.3~0.5 fps.

GPU subd requires that the modifier should at the tail of the stack.
the two meshes shouldn't exisit at the same time, while testing did you enable only one of them at once?

> It is possible that the difference is caused by the viewport GPU subdivision, which isn't implemented in GN at the moment. Otherwise in my test it's not prominent enough. > > Edit: > > From your test file both mesh gives me around 0.3~0.5 fps. 1. GPU subd requires that the modifier should at the tail of the stack. 2. the two meshes shouldn't exisit at the same time, while testing did you enable only one of them at once?

Richard Antalik commented

2023-09-29 05:02:25 +02:00

Member

I can confirm this, not sure if this is a bug, but will confirm the issue and let module decide,

I can confirm this, not sure if this is a bug, but will confirm the issue and let module decide,

Richard Antalik added

and removed

Needs Info from Developers

labels 2023-09-29 05:02:43 +02:00

Iliya Katushenock self-assigned this 2023-09-30 13:36:27 +02:00

Iliya Katushenock changed title from ~~Subdivide surface node in geometry nodes is significantly slower than the Subdivision Modifier~~ to Geometry Nodes: Subdivide surface node in geometry nodes is 8 time slower than Modifier without GPU

2023-09-30 14:31:02 +02:00

Iliya Katushenock commented

2023-09-30 15:31:26 +02:00

Member

This caused by the fact what use_limit_surface (is_adaptive == false) for geometry node version is always setted to false.

This caused by the fact what `use_limit_surface` (`is_adaptive == false`) for geometry node version is always setted to false.

Iliya Katushenock removed their assignment 2023-09-30 15:31:34 +02:00

Iliya Katushenock added

and removed

labels 2023-09-30 15:32:02 +02:00

Ludvik Koutny commented

2023-09-30 16:28:00 +02:00

Contributor

Is changing type to Know Issue really appropriate here? Reports labeled as Known Issue usually mean "It's a bug but we won't do anything about it in near future"

If the problem is one internal flag being hardcoded, then I don't think it's appropriate to categorize it as Known Issue. Known issues should be things that are hard to solve, or are waiting for some larger refactor of the code, and flipping one flag or exposing it to UI aren't anywhere near difficult solution. It's not really acceptable to have Subdivision in GN 8x slower than it could be.

Is changing type to Know Issue really appropriate here? Reports labeled as Known Issue usually mean "It's a bug but we won't do anything about it in near future" If the problem is one internal flag being hardcoded, then I don't think it's appropriate to categorize it as Known Issue. Known issues should be things that are hard to solve, or are waiting for some larger refactor of the code, and flipping one flag or exposing it to UI aren't anywhere near difficult solution. It's not really acceptable to have Subdivision in GN 8x slower than it could be.

Iliya Katushenock commented

2023-09-30 16:59:15 +02:00

Member

The result of the node operation is different. The fix would be a new socket. And I'm not sure what the status of this is. But this particular report is not a bug or a problem. It's just how it works. For the result to be identical to the modifier, you need to disable this option.

Probably this can be Good First Issues and Design to added this socket input, but not sure in this idea.

The result of the node operation is different. The fix would be a new socket. And I'm not sure what the status of this is. But this particular report is not a bug or a problem. It's just how it works. For the result to be identical to the modifier, you need to disable this option. ![image](/attachments/e477acda-a2ac-4f14-82ab-470d5f795198) Probably this can be `Good First Issues` and `Design` to added this socket input, but not sure in this idea.

36 KiB

YimingWu commented

2023-10-01 04:12:19 +02:00

Member

@mod_moder Good job locating the issue. I think Good First Issues would be fine, I'll notify in the chat

@mod_moder Good job locating the issue. I think `Good First Issues` would be fine, I'll notify in the chat

Iliya Katushenock referenced this issue

2023-12-05 09:13:25 +01:00

Geometry Node -> subdivison surface different from modifier-> subdivision. #115771

Germano Cavalcante changed title from ~~Geometry Nodes: Subdivide surface node in geometry nodes is 8 time slower than Modifier without GPU~~ to Geometry Nodes: Subdivide Surface Node Performance Discrepancy Due to 'Use Limit Surface' Option

2023-12-05 14:24:47 +01:00

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

5 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#112912

No description provided.