Command Click on title bar to reveal file path is gone in 4.0 #112978

New Issue

Christopher Tyler · 2023-09-27T21:47:15+02:00

Christopher Tyler commented

2023-09-27 21:47:15 +02:00

#System Information
Operating system: macOS-13.4.1-arm64-arm-64bit 64 Bits
Graphics card: Metal API Apple M1 Pro 1.2

Blender Version
Broken: version: 4.0.0 Alpha, branch: main, commit date: 2023-09-25 21:53, hash: 2aa393e72771
Worked: 3.6

Short description of error
In 3.6, you can Command+Click on the title bar to see a pathway to the file and then to reveal the file.
4.0 now shows a pathway to the file, but we've lost the useful ability to actually reveal the file in the finder.

Exact steps for others to reproduce the error

Open a .blend file in Blender 4.0
In the title bar, where the file name is, press the command key and LMB

Nothing happens.

#**System Information** Operating system: macOS-13.4.1-arm64-arm-64bit 64 Bits Graphics card: Metal API Apple M1 Pro 1.2 **Blender Version** Broken: version: 4.0.0 Alpha, branch: main, commit date: 2023-09-25 21:53, hash: `2aa393e72771` Worked: 3.6 **Short description of error** In 3.6, you can Command+Click on the title bar to see a pathway to the file and then to reveal the file. 4.0 now shows a pathway to the file, but we've lost the useful ability to actually reveal the file in the finder. **Exact steps for others to reproduce the error** - Open a .blend file in Blender 4.0 - In the title bar, where the file name is, press the command key and LMB Nothing happens.

Christopher Tyler added the

labels 2023-09-27 21:47:16 +02:00

kees roobol commented

2023-09-28 13:45:26 +02:00

This is also the case on an Intel iMac with macOS 12.6.9

Germano Cavalcante commented

2023-09-29 15:41:11 +02:00

I can confirm.
It appears to be a regression (otherwise it might be by design).
I'll look for the commit that introduced the problem.

I can confirm. It appears to be a regression (otherwise it might be by design). I'll look for the commit that introduced the problem.

Germano Cavalcante added

Module

Platforms, Builds & Tests

and removed

labels 2023-09-29 15:41:35 +02:00

Germano Cavalcante commented

2023-09-29 19:04:24 +02:00

The problem was introduced in 636f3697ee

To make it clearer, before it was like this:

After the commit it looked like this:

@Harley, can you take a look?

The problem was introduced in 636f3697ee To make it clearer, before it was like this: ![GIF.gif](/attachments/a4636514-d0b6-4a5d-81f1-2e4f13444e24) After the commit it looked like this: ![Captura de Tela 2023-09-29 às 14.01.54.png](/attachments/7af67689-88f0-4008-befe-57fee24fa84e) @Harley, can you take a look?

Captura de Tela 2023-09-29 às 14.01.54.png

196 KiB

GIF.gif

37 KiB

Harley Acheson commented

2023-09-29 19:47:43 +02:00

@mano-wii - It appears to be a regression (otherwise it might be by design)

Although this change of the title format was intentional (we wanted to show the dirty * mark for unsaved files, show "(Unsaved)" when unsaved, wanted the filename earlier in the title and to add the blender version later), this breaks some special formatting in the Apple ghost code.

In blender\intern\ghost\intern\GHOST_WindowCocoa.mm in GHOST_WindowCocoa::setTitle there is special behavior when setting the title. It appears that this command-click behavior is from the use of setRepresentedFilename

Current code is looking for the prefix "Blender" and then locating the full pathname within "[" and "]". It then alters the title to not include the path, and sends the full pathname to setRepresentedFilename. This now fails because "Blender" is no longer a prefix and it is only the path, not including file name, within [].

In order to get back to previous, or similar, result will require someone who compiles for Apple to alter this section of code. Probably altering the hasPrefix "Blender" to using firstIndex or something for a "Contains". Constructing the pathname from the portion between [] and appending the first part, sending that to setRepresentedFilename and altering the title to something that makes sense for the platform. Ideally still using "Unsaved", the dirty mark, and showing version, but personally I prefer whatever is most normal for the platform.

Is this something you are interested in @jenkm ?

> @mano-wii - It appears to be a regression (otherwise it might be by design) Although this change of the title format was intentional (we wanted to show the dirty * mark for unsaved files, show "(Unsaved)" when unsaved, wanted the filename earlier in the title and to add the blender version later), this breaks some special formatting in the Apple ghost code. In `blender\intern\ghost\intern\GHOST_WindowCocoa.mm` in `GHOST_WindowCocoa::setTitle` there is special behavior when setting the title. It appears that this command-click behavior is from the use of `setRepresentedFilename` Current code is looking for the prefix "Blender" and then locating the full pathname within "[" and "]". It then alters the title to not include the path, and sends the full pathname to `setRepresentedFilename`. This now fails because "Blender" is no longer a prefix and it is only the path, not including file name, within []. In order to get back to previous, or similar, result will require someone who compiles for Apple to alter this section of code. Probably altering the hasPrefix "Blender" to using firstIndex or something for a "Contains". Constructing the pathname from the portion between [] and appending the first part, sending that to `setRepresentedFilename` and altering the title to something that makes sense for the platform. Ideally still using "Unsaved", the dirty mark, and showing version, but personally I prefer whatever is most normal for the platform. Is this something you are interested in @jenkm ?

Christopher Tyler commented

2023-09-29 19:51:44 +02:00

I can say as a user that the Command+Click behavior revealing the path and showing the file is far more useful than simply having the path shown in the title bar. If solving this means going back to 3.6 behavior I'm all for that.

Harley Acheson commented

2023-09-29 19:56:41 +02:00

I can say as a user that the Command+Click behavior revealing the path and showing the file is far more useful than simply having the path shown in the title bar. If solving this means going back to 3.6 behavior I'm all for that.

For sure, and that is always an option. But let's try to fix it first.

> I can say as a user that the Command+Click behavior revealing the path and showing the file is far more useful than simply having the path shown in the title bar. If solving this means going back to 3.6 behavior I'm all for that. For sure, and that is always an option. But let's try to fix it first.

Germano Cavalcante commented

2023-09-29 20:36:07 +02:00

I think we could change the parameters from:

void GHOST_SetTitle(GHOST_WindowHandle windowhandle, const char *title)

to:

void GHOST_SetTitle(GHOST_WindowHandle windowhandle, const char *window_name, const char *file_dir)

and each implementation could handle the file_dir at its own way.

I think we could change the parameters from: - `void GHOST_SetTitle(GHOST_WindowHandle windowhandle, const char *title)` to: - `void GHOST_SetTitle(GHOST_WindowHandle windowhandle, const char *window_name, const char *file_dir)` and each implementation could handle the `file_dir` at its own way.

Germano Cavalcante referenced a pull request that will close this issue

2023-10-04 02:01:55 +02:00

Fix #112978: MacOS no longer has a path associated with the window #113227

Germano Cavalcante referenced this issue from a commit

2023-10-05 02:26:20 +02:00

Fix #112978: MacOS no longer has a path associated with the window

Germano Cavalcante closed this issue

2023-10-05 02:26:21 +02:00

Blender Bot added

Status

Resolved

and removed