Color pickers in Color Balance filter and node are not consistent #112996

New Issue

ichlubna · 2023-09-28T08:51:58+02:00

ichlubna commented

2023-09-28 08:51:58 +02:00

System Information
Operating system: Arch Linux

Blender Version
Broken: 3.6.2 (also present in 4.1 alpha)

When using the Color Balance effect, the user can pick a color by clicking into the color-picking circle. The selected color appears in the selected-color box. When clicking on the box, the same circle appears and is a bit larger. The position of the picking dot is not the same in the small and large circle. It looks like a different color is picked in both even though the position should be the same. It seems like the GUI is just scaled and the position is not recalculated. This issue happens in VSE with the Color Balance filter and in Compositor with the Color Balance node.

By the way, the "larger" circle is only a little bit larger. The difference is not significant. I know this is a design talk but maybe the picker opened after clicking on the color box might be even larger or of a different kind to make this more meaningful.

Exact steps for others to reproduce the error

Open Compositor
Add Color Balance node
Move the color picker position in the node
Open the color box and compare the color picker position of the new window with the node

Attaching images with the issue.

**System Information** Operating system: Arch Linux **Blender Version** Broken: 3.6.2 (also present in 4.1 alpha) When using the Color Balance effect, the user can pick a color by clicking into the color-picking circle. The selected color appears in the selected-color box. When clicking on the box, the same circle appears and is a bit larger. The position of the picking dot is not the same in the small and large circle. It looks like a different color is picked in both even though the position should be the same. It seems like the GUI is just scaled and the position is not recalculated. This issue happens in VSE with the Color Balance filter and in Compositor with the Color Balance node. By the way, the "larger" circle is only a little bit larger. The difference is not significant. I know this is a design talk but maybe the picker opened after clicking on the color box might be even larger or of a different kind to make this more meaningful. **Exact steps for others to reproduce the error** 1. Open Compositor 2. Add Color Balance node 3. Move the color picker position in the node 4. Open the color box and compare the color picker position of the new window with the node Attaching images with the issue.

comp.jpg

32 KiB

vse.jpg

27 KiB

ichlubna added the

labels 2023-09-28 08:51:59 +02:00

YimingWu commented

2023-09-28 11:29:08 +02:00

It does seems to be that Lift/Gamma/Gain uses a limited range of color picker with gamma, this way it reserves more precision in the middle for subtle adjustments.

See node_composit_buts_colorbalance where it uses cubic saturation factor in uiTemplateColorPicker. The apparent "clamping" is also due to that.

It's probably better if we draw the color picker with gamma along the radius. However this does not affect the resulting color being chosen.

It does seems to be that Lift/Gamma/Gain uses a limited range of color picker with gamma, this way it reserves more precision in the middle for subtle adjustments. See `node_composit_buts_colorbalance` where it uses cubic saturation factor in `uiTemplateColorPicker`. The apparent "clamping" is also due to that. It's probably better if we draw the color picker with gamma along the radius. However this does not affect the resulting color being chosen.

YimingWu added

Module

User Interface

Status

Needs Info from Developers

and removed

Status

Needs Triage

labels 2023-09-28 11:34:27 +02:00

Sign in to join this conversation.