Loop Cut and Slide from menu is waiting for cursor input #113112

New Issue

Closed

opened 2023-10-01 14:03:54 +02:00 by Julien Kaspar · 4 comments

Julien Kaspar commented

2023-10-01 14:03:54 +02:00

Member

System Information
Operating system: Linux-6.5.4-gentoo-x86_64-AMD_Ryzen_Threadripper_1950X_16-Core_Processor-with-glibc2.37 64 Bits, X11 UI
Graphics card: AMD Radeon RX 7900 XT (gfx1100, LLVM 16.0.6, DRM 3.54, 6.5.4-gentoo) AMD 4.6 (Core Profile) Mesa 23.3.0-devel (git-8d2dcd55d7)

Blender Version
Broken: version: 4.1.0 Alpha, branch: main, commit date: 2023-09-30 22:20, hash: 995aa08c7951
Worked:

Short description of error
When executing modal operators from menus they use an additional flag to have the modal wait for an additional cursor click before starting.
This is very useful.

The operator "Loop Cut and Slide" unfortunately also uses this even though it doesn't need to. This results in the user having to click twice to be able to cut & slide.

Exact steps for others to reproduce the error

Switch to edit mode
Use Header -> Edge -> Loop Cut and Slide
Try to insert a loop cut and slide

**System Information** Operating system: Linux-6.5.4-gentoo-x86_64-AMD_Ryzen_Threadripper_1950X_16-Core_Processor-with-glibc2.37 64 Bits, X11 UI Graphics card: AMD Radeon RX 7900 XT (gfx1100, LLVM 16.0.6, DRM 3.54, 6.5.4-gentoo) AMD 4.6 (Core Profile) Mesa 23.3.0-devel (git-8d2dcd55d7) **Blender Version** Broken: version: 4.1.0 Alpha, branch: main, commit date: 2023-09-30 22:20, hash: `995aa08c7951` Worked: **Short description of error** When executing modal operators from menus they use an additional flag to have the modal wait for an additional cursor click before starting. This is very useful. The operator "Loop Cut and Slide" unfortunately also uses this even though it doesn't need to. This results in the user having to click twice to be able to cut & slide. **Exact steps for others to reproduce the error** - Switch to edit mode - Use Header -> Edge -> Loop Cut and Slide - Try to insert a loop cut and slide

Julien Kaspar added the

labels 2023-10-01 14:03:55 +02:00

Pratik Borhade commented

2023-10-02 08:41:57 +02:00

Member

Can confirm. I'll check.

Can confirm. I'll check.

Pratik Borhade added

and removed

labels 2023-10-02 08:42:12 +02:00

Pratik Borhade self-assigned this 2023-10-02 08:42:20 +02:00

Pratik Borhade commented

2023-10-02 09:09:26 +02:00

Member

This is because TRANSFORM_OT_edge_slide operator has OPTYPE_DEPENDS_ON_CURSOR flag set.
That's why invoke call to this operator is not sent in WM_operator_name_call_ptr_with_depends_on_cursor.
Do we really need cursor input for edge slide operator? If no, then we can simply remove that flag (which will fix this bug too)
@JulienKaspar ^

This is because `TRANSFORM_OT_edge_slide` operator has `OPTYPE_DEPENDS_ON_CURSOR` flag set. That's why invoke call to this operator is not sent in `WM_operator_name_call_ptr_with_depends_on_cursor`. Do we really need cursor input for `edge slide` operator? If no, then we can simply remove that flag (which will fix this bug too) @JulienKaspar ^

Julien Kaspar commented

2023-10-02 10:32:28 +02:00

Author

Member

Yes.
Since edge slide is not relying on the exact cursor position and other transform operators are not using OPTYPE_DEPENDS_ON_CURSOR I think it's a good call to remove that flag for edge slide as well.

Yes. Since edge slide is not relying on the exact cursor position and other transform operators are not using `OPTYPE_DEPENDS_ON_CURSOR` I think it's a good call to remove that flag for edge slide as well.

Pratik Borhade commented

2023-10-02 11:27:09 +02:00

Member

Thanks. I'll make a quick PR then

Thanks. I'll make a quick PR then

Pratik Borhade referenced a pull request that will close this issue

2023-10-02 11:36:13 +02:00

Fix #113112: Loop Cut and Slide from menu is waiting for cursor input #113140

Pratik Borhade referenced this issue from a commit

2023-10-23 13:05:53 +02:00

Fix #113112: Loop Cut and Slide from menu is waiting for cursor input

Pratik Borhade closed this issue

2023-10-23 13:05:56 +02:00

Blender Bot added

and removed

labels 2023-10-23 13:05:58 +02:00

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#113112

No description provided.