Regresion: Can no longer infinite drag if the mouse hits an screen edge #113511

New Issue

Guillermo Venegas · 2023-10-10T18:49:14+02:00

Guillermo Venegas commented

2023-10-10 18:49:14 +02:00

System Information
Operating system: Windows-10-10.0.22621-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3070/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 537.42

Blender Version
Broken: version: 4.1.0 Alpha, commit date: 2023-10-10 16:27, hash: a565b586d912
Worked: (newest version of Blender that worked as expected)

Short description of error
Can no longer infinite drag if the mouse hits an screen edge

Exact steps for others to reproduce the error

**System Information** Operating system: Windows-10-10.0.22621-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3070/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 537.42 **Blender Version** Broken: version: 4.1.0 Alpha, commit date: 2023-10-10 16:27, hash: `a565b586d912` Worked: (newest version of Blender that worked as expected) **Short description of error** Can no longer infinite drag if the mouse hits an screen edge **Exact steps for others to reproduce the error** <video src="/attachments/8fea864f-46c2-487e-adcf-2724765105f0" title="2023-10-10 10-48-15.mp4" controls></video>

2023-10-10 10-48-15.mp4

2.1 MiB

Guillermo Venegas added the

labels 2023-10-10 18:49:15 +02:00

Guillermo Venegas commented

2023-10-10 18:51:03 +02:00

@Harley

Harley Acheson self-assigned this 2023-10-10 19:29:25 +02:00

Richard Antalik commented

2023-10-10 23:25:10 +02:00

Not sure if I can repro, there is some weird cursor wrapping behavior on linux though.

Pratik Borhade commented

2023-10-11 05:18:19 +02:00

I can confirm. Reverting 1d141e721c fixes the continuous grab

I can confirm. Reverting 1d141e721c62a0cccf7341238fd03da81343095b fixes the continuous grab

Pratik Borhade added

and removed

labels 2023-10-11 05:18:41 +02:00

Pratik Borhade added this to the 4.0 milestone 2023-10-11 05:19:26 +02:00

Harley Acheson commented

2023-10-11 23:22:32 +02:00

@guishe

Just making sure we are seeing the same things. This is a problem when the mouse hits the desktop edge right? As in if you have multiple monitors it works okay in a middle monitor, just not at the desktop edges. And this is when the blender window's edge is exactly on the edge? Because if I pull the blender window just a pixel or two away from the edge then it works okay. Sound the same?

@iss - I'm assuming that the changes in 1d141e721c couldn't affect Linux at all. Are you seeing otherwise?

@guishe Just making sure we are seeing the same things. This is a problem when the mouse hits the desktop edge right? As in if you have multiple monitors it works okay in a middle monitor, just not at the desktop edges. And this is when the blender window's edge is exactly on the edge? Because if I pull the blender window just a pixel or two away from the edge then it works okay. Sound the same? @iss - I'm assuming that the changes in 1d141e721c62a0cccf7341238fd03da81343095b couldn't affect Linux at all. Are you seeing otherwise?

Richard Antalik commented

2023-10-12 00:40:11 +02:00

@iss - I'm assuming that the changes in 1d141e721c couldn't affect Linux at all. Are you seeing otherwise?

I did check with older versions and the behavior is consistent. It seems to fail to wrap cursor when going in direction where 2nd monitor is too fast. Don't have windows machine with 2 monitors atm to check.

> @iss - I'm assuming that the changes in 1d141e721c62a0cccf7341238fd03da81343095b couldn't affect Linux at all. Are you seeing otherwise? I did check with older versions and the behavior is consistent. It seems to fail to wrap cursor when going in direction where 2nd monitor is too fast. Don't have windows machine with 2 monitors atm to check.

Harley Acheson referenced a pull request that will close this issue

2023-10-12 00:54:35 +02:00

Fix #113511: Win32 Warping Needs Screen Edge Margin #113565

Harley Acheson commented

2023-10-12 00:56:33 +02:00

@iss I did check with older versions and the behavior is consistent

Thank you so much for testing. I couldn't see any way the changes could affect Linux, but I've been wrong before.

> @iss I did check with older versions and the behavior is consistent Thank you so much for testing. I couldn't see any way the changes could affect Linux, but I've been wrong before.

Harley Acheson referenced this issue from a commit

2023-10-12 01:04:02 +02:00

Fix #113511: Win32 Warping Needs Screen Edge Margin

Harley Acheson closed this issue

2023-10-12 01:04:03 +02:00

Blender Bot added

and removed

labels 2023-10-12 01:04:05 +02:00

Guillermo Venegas commented

2023-10-12 01:21:20 +02:00

This is a problem when the mouse hits the desktop edge right?

And at the bottom too

Was the rectangle given by GetClientRect is used.
https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-getclientrect#remarks
It says that the bottom and right coordinates count an exclusive pixel.

>>This is a problem when the mouse hits the desktop edge right? And at the bottom too Was the rectangle given by `GetClientRect` is used. https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-getclientrect#remarks It says that the bottom and right coordinates count an exclusive pixel.

Harley Acheson commented

2023-10-12 01:50:45 +02:00

And at the bottom too

Perfect. Thanks!

It says that the bottom and right coordinates count an exclusive pixel.

Yes, that issue probably screws up by a pixel in a bunch of places.

Not strictly for this though. In a nutshell the warping can occur outside of our window but not outside of the desktop bounds. So when our window is right against the outer edge we need some margin, enough for the cursor warping to occur. Now we are using a value that is 10% of the warping bounds width - and that applies in all directions.

> And at the bottom too Perfect. Thanks! > It says that the bottom and right coordinates count an exclusive pixel. Yes, that issue probably screws up by a pixel in a bunch of places. Not strictly for this though. In a nutshell the warping can occur outside of our window but not outside of the desktop bounds. So when our window is right against the outer edge we need some margin, enough for the cursor warping to occur. Now we are using a value that is 10% of the warping bounds width - and that applies in all directions.

Guillermo Venegas referenced this issue

2023-10-12 21:54:08 +02:00

Walk Navigation: Cannot turn left #113627

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Regresion: Can no longer infinite drag if the mouse hits an screen edge #113511