Regression: "Search for nodes" field doesn't work for custom nodes. #113559

New Issue

Closed

opened 2023-10-11 20:50:41 +02:00 by asen.stoilov · 3 comments

asen.stoilov commented

2023-10-11 20:50:41 +02:00

System Information
Operating system: Windows
Graphics card:

Blender Version
Broken: (example: 3.6.4, c80b45f646, branch: blender-v3.6-release, 2023-10-10)
Worked: (blender 3.5)

Short description of error
When I register custom node and tree, open the tree editor, search for the node with SHIFT+A it won't appear in the list of nodes.

Exact steps for others to reproduce the error

Execute the code below from the scripting workspace.
Open "Test Node Tree" editor.
Press SHIFT+A then S.
"Test Node" won't appear.

import bpy
import nodeitems_utils

class TestNode(bpy.types.Node):
    bl_idname = 'TestNode'
    bl_label  = 'Test Node'

class TestNodeTree(bpy.types.NodeTree):
    bl_label  = "Test Node Tree"
    bl_idname = 'TestNodeTree'
    bl_icon   = 'OBJECT_DATAMODE'
    @classmethod
    def poll(cls, context):
        return True

class TestCategory(nodeitems_utils.NodeCategory):
    @classmethod
    def poll(cls, context):
        return context.space_data.tree_type.startswith('TestNodeTree')

TestCategories = [
    TestCategory(
        'TEST',
        "Test",
        items = [
            nodeitems_utils.NodeItem("TestNode", label = "Test Node")
        ]
    )
]

bpy.utils.register_class(TestNode)
bpy.utils.register_class(TestNodeTree)

nodeitems_utils.register_node_categories('TEST_NODES', TestCategories)

**System Information** Operating system: Windows Graphics card: **Blender Version** Broken: (example: 3.6.4, c80b45f64628, branch: blender-v3.6-release, 2023-10-10) Worked: (blender 3.5) **Short description of error** When I register custom node and tree, open the tree editor, search for the node with SHIFT+A it won't appear in the list of nodes. **Exact steps for others to reproduce the error** 1. Execute the code below from the scripting workspace. 2. Open "Test Node Tree" editor. 3. Press SHIFT+A then S. 4. "Test Node" won't appear. ```Py import bpy import nodeitems_utils class TestNode(bpy.types.Node): bl_idname = 'TestNode' bl_label = 'Test Node' class TestNodeTree(bpy.types.NodeTree): bl_label = "Test Node Tree" bl_idname = 'TestNodeTree' bl_icon = 'OBJECT_DATAMODE' @classmethod def poll(cls, context): return True class TestCategory(nodeitems_utils.NodeCategory): @classmethod def poll(cls, context): return context.space_data.tree_type.startswith('TestNodeTree') TestCategories = [ TestCategory( 'TEST', "Test", items = [ nodeitems_utils.NodeItem("TestNode", label = "Test Node") ] ) ] bpy.utils.register_class(TestNode) bpy.utils.register_class(TestNodeTree) nodeitems_utils.register_node_categories('TEST_NODES', TestCategories) ```

asen.stoilov added the

labels 2023-10-11 20:50:42 +02:00

Richard Antalik commented

2023-10-11 21:44:20 +02:00

Member

Seems that 3.6 is already broken, since search results are not relevant to context. Will confirm as this is regression.

Seems that 3.6 is already broken, since search results are not relevant to context. Will confirm as this is regression.

Richard Antalik added

Nodes & Physics

and removed

labels 2023-10-11 21:44:52 +02:00

Richard Antalik changed title from ~~"Search for nodes" field doesn't work for custom nodes.~~ to Regression: "Search for nodes" field doesn't work for custom nodes.

2023-10-11 21:45:08 +02:00

Harley Acheson commented

2023-10-18 18:13:46 +02:00

Member

If I follow these instructions exactly in 4.0 and in main (4.1) the node search includes the custom node:

The node search also includes the custom node in 3.4.1 and 3.5.1. But not in 3.6 only.

So this is something that broke between 3.5 and 3.6 but has since been fixed for 4.0 and newer. But... even in 3.6.1 I can still add the custom node because it is properly on the "Add" menu:

So this doesn't feel like an issue that deserves "High Priority" status, but I might not be aware of the process.

If I follow these instructions exactly in 4.0 and in main (4.1) the node search includes the custom node: ![image](/attachments/14fdc516-0a44-4f51-87fc-328e57a0c07a) The node search also includes the custom node in 3.4.1 and 3.5.1. But not in 3.6 only. So this is something that broke between 3.5 and 3.6 **but has since been fixed** for 4.0 and newer. But... even in 3.6.1 I can still _add_ the custom node because it is properly on the "Add" menu: ![image](/attachments/1c432711-69da-4a9a-af02-27ee8387f501) So this doesn't feel like an issue that deserves "High Priority" status, but I might not be aware of the process.

28 KiB

16 KiB

Richard Antalik commented

2023-10-19 04:09:36 +02:00

Member

This must have been fixed recently, since I can reproduce with a935701a87, but not with recent build. Will close then.

This must have been fixed recently, since I can reproduce with a935701a872d, but not with recent build. Will close then.

Richard Antalik closed this issue

2023-10-19 04:09:39 +02:00

Blender Bot added

and removed

labels 2023-10-19 04:09:40 +02:00

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#113559

No description provided.