bpy.ops.text.reload with overridden contxet crashes blender #113644

New Issue

Andrej · 2023-10-13T09:04:33+02:00

Andrej commented

2023-10-13 09:04:33 +02:00

Blender 3.6.4

Was trying to revive the old script for reloading text editor if file has changed and found that bpy.ops.text.reload with overridden crashes blender.

Steps to reproduce:

New blender session, open scripting tab
Open some test.py from your computer in text editor and change it outside blender so it will be need a reload.
Run the code below.
You can comment out bpy.ops.text.reload(context_override) to see that there is a same issue with temp_override.

context_override = {} 
context_override["edit_text"] = bpy.data.texts["test.py"]
area = next(area for area in bpy.context.screen.areas if area.type == "TEXT_EDITOR")
space = next(space for space in area.spaces if space.type == "TEXT_EDITOR")
context_override["space_data"] = space

print('old override method')
bpy.ops.text.reload(context_override)

print('new override method')
with bpy.context.temp_override(**context_override):
    bpy.ops.text.reload()

Also the same issue with text.resolve_conflict.

print('old override method')
bpy.ops.text.resolve_conflict(context_override, resolution="RELOAD")

print('new override method')
with bpy.context.temp_override(**context_override):
    bpy.ops.text.resolve_conflict(resolution="RELOAD")

Current workaround for me was to reload the data manually.

# using reloading operators causes crashes, therefore we reload the text manually
# saving text to file afterwards as it's the only way to flip `.is_modified`
# since reload doesn't work - https://projects.blender.org/blender/blender/issues/113644
with open(text.filepath, 'r') as fi:
    new_text = fi.read()
text.from_string(new_text)

def get_area():
    for screen in bpy.data.screens:
        for area in screen.areas:
            if area.type == "TEXT_EDITOR":
                return area
            
context_override = {} 
context_override["edit_text"] = text
space = next(space for space in get_area().spaces if space.type == "TEXT_EDITOR")
context_override["space_data"] = space

with bpy.context.temp_override(**context_override):
    bpy.ops.text.save()

Blender 3.6.4 Was trying to revive the [old script for reloading text editor](https://archive.blender.org/wiki/index.php/Extensions:2.5/Py/Scripts/Text_Editor/Reload_if_Modified/) if file has changed and found that `bpy.ops.text.reload` with overridden crashes blender. Steps to reproduce: 1) New blender session, open scripting tab 2) Open some `test.py` from your computer in text editor and change it outside blender so it will be need a reload. 3) Run the code below. 4) You can comment out `bpy.ops.text.reload(context_override)` to see that there is a same issue with `temp_override`. ```python context_override = {} context_override["edit_text"] = bpy.data.texts["test.py"] area = next(area for area in bpy.context.screen.areas if area.type == "TEXT_EDITOR") space = next(space for space in area.spaces if space.type == "TEXT_EDITOR") context_override["space_data"] = space print('old override method') bpy.ops.text.reload(context_override) print('new override method') with bpy.context.temp_override(**context_override): bpy.ops.text.reload() ``` Also the same issue with `text.resolve_conflict`. ```python print('old override method') bpy.ops.text.resolve_conflict(context_override, resolution="RELOAD") print('new override method') with bpy.context.temp_override(**context_override): bpy.ops.text.resolve_conflict(resolution="RELOAD") ``` Current workaround for me was to reload the data manually. ```python # using reloading operators causes crashes, therefore we reload the text manually # saving text to file afterwards as it's the only way to flip `.is_modified` # since reload doesn't work - https://projects.blender.org/blender/blender/issues/113644 with open(text.filepath, 'r') as fi: new_text = fi.read() text.from_string(new_text) def get_area(): for screen in bpy.data.screens: for area in screen.areas: if area.type == "TEXT_EDITOR": return area context_override = {} context_override["edit_text"] = text space = next(space for space in get_area().spaces if space.type == "TEXT_EDITOR") context_override["space_data"] = space with bpy.context.temp_override(**context_override): bpy.ops.text.save() ```

Andrej added the

labels 2023-10-13 09:04:34 +02:00

YimingWu commented

2023-10-13 11:36:54 +02:00

The with bpy.context.temp_override(**context_override): method seems to be working as it should in 4.1

3.6 also works here, could you try find the crash log?

The `with bpy.context.temp_override(**context_override):` method seems to be working as it should in 4.1 3.6 also works here, could you try find the crash log?

YimingWu added

Status

Needs Information from User

and removed

Status

Needs Triage

labels 2023-10-13 11:38:43 +02:00

Andrej commented

2023-10-13 14:46:46 +02:00

Attached the crash log.

Tested it now also with --factory-startup to make sure it's unrelated to any addons.

Attached the crash log. Tested it now also with `--factory-startup` to make sure it's unrelated to any addons.