Crash if you assign an empty name to the node group interface. #113860

New Issue

Closed

opened 2023-10-17 19:22:27 +02:00 by ugorek · 3 comments

ugorek commented

2023-10-17 19:22:27 +02:00

System Information
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1650/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 536.23

Blender Version
Broken: version: 4.1.0 Alpha, branch: main, commit date: 2023-10-17 09:01, hash: 6b0769c448c8

Short description of error
Setting the interface name via API to "" will lead to an immediate crash.

Exact steps for others to reproduce the error
Get a group of nodes and execute the code:

bpy.data.node_groups["Geometry Nodes"].interface.items_tree[0].name = ""

**System Information** Operating system: Windows-10-10.0.19045-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1650/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 536.23 **Blender Version** Broken: version: 4.1.0 Alpha, branch: main, commit date: 2023-10-17 09:01, hash: `6b0769c448c8` **Short description of error** Setting the interface name via API to `""` will lead to an immediate crash. **Exact steps for others to reproduce the error** Get a group of nodes and execute the code: ```Py bpy.data.node_groups["Geometry Nodes"].interface.items_tree[0].name = "" ```

ugorek added the

labels 2023-10-17 19:22:27 +02:00

Iliya Katushenock added the

Nodes & Physics

labels 2023-10-17 19:25:46 +02:00

Iliya Katushenock added

Nodes & Physics

and removed

Nodes & Physics

labels 2023-10-17 19:53:15 +02:00

Hans Goudey commented

2023-10-19 09:44:32 +02:00

Member

Thanks for the report!

@LukasTonne The crash is in declaration_for_interface_socket and can be fixed like this:

dst->name = io_socket.name ? io_socket.name : "";

However, then an assert checking that the name is not null fails. I wonder if we should protect from an empty name at a higher level? Or maybe it would be nice to just allow it.

Thanks for the report! --- @LukasTonne The crash is in `declaration_for_interface_socket` and can be fixed like this: `dst->name = io_socket.name ? io_socket.name : "";` However, then an assert checking that the name is not null fails. I wonder if we should protect from an empty name at a higher level? Or maybe it would be nice to just allow it.

Hans Goudey added

and removed

labels 2023-10-19 09:44:43 +02:00

Lukas Tönne self-assigned this 2023-10-19 10:00:36 +02:00

Lukas Tönne commented

2023-10-19 10:14:43 +02:00

Member

Thanks @HooglyBoogly, i will apply that fix. Neither the socket nor interface socket name have to be unique and they can be empty, so i don't think there's any point in higher level checks. The UI just generates nullptrs for empty strings, which is incompatible with std::string assignment. Unfortunate, but it is what it is.

Thanks @HooglyBoogly, i will apply that fix. Neither the socket nor interface socket name have to be unique and they can be empty, so i don't think there's any point in higher level checks. The UI just generates nullptrs for empty strings, which is incompatible with std::string assignment. Unfortunate, but it is what it is.

Lukas Tönne commented

2023-10-19 10:26:40 +02:00

Member

There are places in the code where name != nullptr is asserted and some more where dangerous assignment takes place. I guess i have to go over these and make sure nullptr is supported.

There are places in the code where `name != nullptr` is asserted and some more where dangerous assignment takes place. I guess i have to go over these and make sure nullptr is supported.

Lukas Tönne referenced a pull request that will close this issue

2023-10-19 11:05:45 +02:00

Fix #113860: Nullptr checks for node socket and panel name pointers #113924

Lukas Tönne referenced this issue from a commit

2023-10-19 11:48:18 +02:00

Fix #113860: Nullptr checks for node socket and panel name pointers

Lukas Tönne closed this issue

2023-10-19 11:48:21 +02:00

Blender Bot added

and removed

labels 2023-10-19 11:48:23 +02:00

Lukas Tönne referenced a pull request that will close this issue

2023-10-19 12:19:39 +02:00

Fix #113860: Incorrect conditionals for node group socket names #113929

Lukas Tönne referenced this issue from a commit

2023-10-19 12:21:56 +02:00

Fix #113860: Incorrect conditionals for node group socket names

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#113860

No description provided.