UI: Tree View double-clicking on arrows tries to rename item #114059

New Issue

Dalai Felinto · 2023-10-23T12:40:16+02:00

Dalai Felinto commented

2023-10-23 12:40:16 +02:00

Blender Version
Broken: version: 4.1.0 Alpha, branch: main, commit date: 2023-10-23 08:44, hash: 567cc7cf9ff8
Worked: -

Short description of error

If I double-click on a collapsable arrow it sometimes invoke the rename operation. Not only I believe this shouldn't be the case, but I also often get stuck in a "click to rename" loop, until I move my mouse away.

Exact steps for others to reproduce the error

Open double-click-rename.blend
Double-click on the Panel arrow.

Check the video (with audio) to hear, close to the end how I'm clearly clicking only once and yet it is triggering rename.

**Blender Version** Broken: version: 4.1.0 Alpha, branch: main, commit date: 2023-10-23 08:44, hash: `567cc7cf9ff8` Worked: - **Short description of error** If I double-click on a collapsable arrow it sometimes invoke the rename operation. Not only I believe this shouldn't be the case, but I also often get stuck in a "click to rename" loop, until I move my mouse away. **Exact steps for others to reproduce the error** * Open [double-click-rename.blend](/attachments/f30ca6f3-9769-45a0-aa98-fec8ca23a8d4) * Double-click on the Panel arrow. Check the video (with audio) to hear, close to the end how I'm clearly clicking only once and yet it is triggering rename.

double-click-rename.blend

104 KiB

double-click-2023-10-23_12.39.22.mp4

198 KiB

Dalai Felinto added the

labels 2023-10-23 12:41:14 +02:00

Dalai Felinto added this to the User Interface project 2023-10-23 12:41:14 +02:00

Dalai Felinto commented

2023-10-23 12:41:57 +02:00

This may be related to #114055.

Dalai Felinto commented

2023-10-23 12:44:02 +02:00

Interesting enough, I also get a lot of unfreed memory blocks when reproducing this issue:

Error: Not freed memory blocks: 10, total unfreed memory 0.000076 MB
Data from NT len: 8 0x7fde125d17e8
strdup len: 8 0x7fde273e9ac8
strdup len: 8 0x7fde273eb0f8
strdup len: 8 0x7fde628ad648
strdup len: 8 0x7fde273e87b8
strdup len: 8 0x7fde273eb0a8
strdup len: 8 0x7fde273eb238
strdup len: 8 0x7fde273e8ad8
strdup len: 8 0x7fde273eb058
strdup len: 8 0x7fde273e8768

Interesting enough, I also get a lot of unfreed memory blocks when reproducing this issue: ``` Error: Not freed memory blocks: 10, total unfreed memory 0.000076 MB Data from NT len: 8 0x7fde125d17e8 strdup len: 8 0x7fde273e9ac8 strdup len: 8 0x7fde273eb0f8 strdup len: 8 0x7fde628ad648 strdup len: 8 0x7fde273e87b8 strdup len: 8 0x7fde273eb0a8 strdup len: 8 0x7fde273eb238 strdup len: 8 0x7fde273e8ad8 strdup len: 8 0x7fde273eb058 strdup len: 8 0x7fde273e8768 ```

Dalai Felinto changed title from ~~UI: Grid Layout double-clicking on arrows tries to rename item~~ to UI: Tree View double-clicking on arrows tries to rename item

2023-10-23 15:47:44 +02:00

Julian Eisel commented

2023-10-23 21:37:02 +02:00

This seems fixed with 009c4b819c. Now the view item activation is done by simply applying the button, not by calling the regular button handling. This way side-effects like this are avoided.

This seems fixed with 009c4b819c. Now the view item activation is done by simply applying the button, not by calling the regular button handling. This way side-effects like this are avoided.

Julian Eisel closed this issue

2023-10-23 21:37:05 +02:00

Blender Bot added

and removed

labels 2023-10-23 21:37:22 +02:00

Julian Eisel referenced this issue

2023-10-23 23:56:10 +02:00

Fix memory leak when renaming node group sockets/panels #114083