GPv3: Port Bucket Fill operator #114069

New Issue

Antonio Vazquez · 2023-10-23T19:01:40+02:00

Antonio Vazquez commented

2023-10-23 19:01:40 +02:00

This task is related to convert old Fill tool to GPv3. The conversion will include some redesign.

Main planned changes:

Remove Fill Brushes and move options to Tool. The Fill is not really a Brush and is not used in other 2D softwares, so it's logic remove it.
Cleanup Advanced parameters that now are not needed.
Simplify UI.
Remove weird hacks in the actual code as invisible strokes to close gaps.
Try to expose flood fill algorithm as Python API and separate from modal operator. This would make easier for Studios to create their own fill tools, but using the flood fill algorithm.
Try to use the extend algorithm used in extend modifier to use the actual curve direction and get smoother results in the closing lines.

This task is related to convert old Fill tool to GPv3. The conversion will include some redesign. Main planned changes: * Remove Fill Brushes and move options to Tool. The Fill is not really a Brush and is not used in other 2D softwares, so it's logic remove it. * Cleanup Advanced parameters that now are not needed. * Simplify UI. * Remove weird hacks in the actual code as invisible strokes to close gaps. * Try to expose flood fill algorithm as Python API and separate from modal operator. This would make easier for Studios to create their own fill tools, but using the flood fill algorithm. * Try to use the extend algorithm used in extend modifier to use the actual curve direction and get smoother results in the closing lines.

👍 1

Antonio Vazquez added the

Type

To Do

label 2023-10-23 19:01:41 +02:00

Antonio Vazquez added this to the Grease Pencil project 2023-10-23 19:01:50 +02:00

Antonio Vazquez self-assigned this 2023-10-23 19:02:04 +02:00

Antonio Vazquez commented

2023-10-23 19:02:43 +02:00

@mendio you can subscribe to this task to work together in the design.

👍 1

Antonio Vazquez changed title from ~~GPv3: Port Fill operator~~ to GPv3: Port Bucket Fill operator

2023-10-24 09:55:21 +02:00

Sietse Brouwer commented

2023-10-24 16:30:38 +02:00

@antoniov I can't reach the Blender chat at the moment (it's reloading 5 times per second...), so I reply in the task here. I would say it's safe for you to work on a port of the Bucket Fill.
I'm working on a geometry-based fill and I have a version that is working on pretty clean drawings. But as soon as the drawings become a bit more sketchy, the algorithm is still struggling. I might be able to fix that in some way, but I think a flood-fill based operator will always be more robust in those cases. So for feature-parity it's good to have a port of the Bucket Fill.

@antoniov I can't reach the Blender chat at the moment (it's reloading 5 times per second...), so I reply in the task here. I would say it's safe for you to work on a port of the Bucket Fill. I'm working on a geometry-based fill and I have a version that is working on pretty clean drawings. But as soon as the drawings become a bit more sketchy, the algorithm is still struggling. I might be able to fix that in some way, but I think a flood-fill based operator will always be more robust in those cases. So for feature-parity it's good to have a port of the Bucket Fill.

Antonio Vazquez commented

2023-10-25 19:26:15 +02:00

@pepe-school-land You can add any idea here :-)

Antonio Vazquez removed their assignment 2024-01-08 16:40:05 +01:00

Lukas Tönne self-assigned this 2024-04-10 12:00:35 +02:00

Lukas Tönne commented

2024-04-16 12:07:04 +02:00

Implementation PR (WIP): #120693

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

GPv3: Port Bucket Fill operator #114069