Rotation of mirrored bones is wrapped to 180 degrees during transformation #114073

New Issue

Open

opened 2023-10-23 20:11:52 +02:00 by john · 5 comments

john commented

2023-10-23 20:11:52 +02:00

Blender Version
Broken: version: 3.5.0, branch: blender-v3.5-release, commit date: 2023-03-29 02:56, hash: 1be25cfff18b

Short description of error
When we transform a bone with X-mirror and use rotation values above 180 degrees, the equivalent mirrored bone has the rotations wrapped 180 degrees.

See:
https://youtu.be/21W7qyeqQrQ?feature=shared

Exact steps for others to reproduce the error

Open attached .blend file
Select any bone in Pose mode
Rotate the bone in the X axis to values above 360 (for example 720)
Check the X rotation of the mirrored bone

**Blender Version** Broken: version: 3.5.0, branch: blender-v3.5-release, commit date: 2023-03-29 02:56, hash: `1be25cfff18b` **Short description of error** When we transform a bone with X-mirror and use rotation values above 180 degrees, the equivalent mirrored bone has the rotations wrapped 180 degrees. See: https://youtu.be/21W7qyeqQrQ?feature=shared **Exact steps for others to reproduce the error** - Open attached .blend file - Select any bone in Pose mode - Rotate the bone in the X axis to values above 360 (for example 720) - Check the X rotation of the mirrored bone

x_mirror_rotation_wrapped__bug.blend

865 KiB

john added the

labels 2023-10-23 20:11:53 +02:00

Germano Cavalcante commented

2023-10-24 22:07:43 +02:00

Member

Thanks for the report, @keki-2.

I analyzed the .blend file attached and noticed that the real problem is that the Rotation of mirrored bones is wrapped to 360 degrees during transformation.

It has no real relationship with drivers.
The file can be greatly simplified.

I will edit the report to confirm...

Thanks for the report, @keki-2. I analyzed the .blend file attached and noticed that the real problem is that the Rotation of mirrored bones is wrapped to 360 degrees during transformation. It has no real relationship with drivers. The file can be greatly simplified. I will edit the report to confirm...

Germano Cavalcante changed title from ~~Rotation Drivers on an Armature have different behaviour if you move the driver bone directly or indirectly after rotating more than 180 degrees.~~ to Rotation of mirrored bones is wrapped to 360 degrees during transformation

2023-10-24 22:21:46 +02:00

Germano Cavalcante added

Animation & Rigging

and removed

labels 2023-10-24 22:22:43 +02:00

Germano Cavalcante changed title from ~~Rotation of mirrored bones is wrapped to 360 degrees during transformation~~ to Rotation of mirrored bones is wrapped to 180 degrees during transformation

2023-10-24 22:23:39 +02:00

john commented

2023-10-25 05:55:33 +02:00

Author

the problem also shows up if you use a constraint to move the driver bone, not just with the mirror.

the problem also shows up if you use a constraint to move the driver bone, not just with the mirror.

john commented

2023-10-25 06:03:49 +02:00

Author

https://youtu.be/EOmwlpKXCMc look

https://youtu.be/EOmwlpKXCMc look

Germano Cavalcante commented

2023-10-25 15:11:47 +02:00

Member

This is another issue @keki-2, and if I'm not mistaken it has already been reported before.

This is another issue @keki-2, and if I'm not mistaken it has already been reported before.

Germano Cavalcante commented

2023-10-27 15:17:50 +02:00

Member

I have been looking for solutions to this problem.
The one below works, but adds a lot of complexity to the code. Especially because of "Relative Mirror".

diff --git a/source/blender/editors/transform/transform_convert_armature.cc b/source/blender/editors/transform/transform_convert_armature.cc
index c4a628d0883..b11e1c9a251 100644
--- a/source/blender/editors/transform/transform_convert_armature.cc
+++ b/source/blender/editors/transform/transform_convert_armature.cc
@@ -1338,7 +1338,21 @@ static void pose_transform_mirror_update(TransInfo *t, TransDataContainer *tc, O
     if (pid) {
       mul_m4_m4m4(pchan_mtx_final, pid->offset_mtx, pchan_mtx_final);
     }
-    BKE_pchan_apply_mat4(pchan, pchan_mtx_final, false);
+
+    float rot[3][3];
+    mat4_to_loc_rot_size(pchan->loc, rot, pchan->size, pchan_mtx_final);
+
+    if (pchan->rotmode == ROT_MODE_EUL && pchan->rotmode == pchan_orig->rotmode) {
+      pchan->eul[0] = pchan_orig->eul[0];
+      pchan->eul[1] = -pchan_orig->eul[1];
+      pchan->eul[2] = -pchan_orig->eul[2];
+      if (pid) {
+        BKE_pchan_mat3_to_rot(pchan, rot, true);
+      }
+    }
+    else {
+      BKE_pchan_mat3_to_rot(pchan, rot, false);
+    }
 
     /* Set flag to let auto key-frame know to key-frame the mirrored bone. */
     pchan->bone->flag |= BONE_TRANSFORM_MIRROR;

There are certainly simpler ways to achieve this.
Maybe we could just set use_compat to true.

I have been looking for solutions to this problem. The one below works, but adds a lot of complexity to the code. Especially because of "Relative Mirror". ```diff diff --git a/source/blender/editors/transform/transform_convert_armature.cc b/source/blender/editors/transform/transform_convert_armature.cc index c4a628d0883..b11e1c9a251 100644 --- a/source/blender/editors/transform/transform_convert_armature.cc +++ b/source/blender/editors/transform/transform_convert_armature.cc @@ -1338,7 +1338,21 @@ static void pose_transform_mirror_update(TransInfo *t, TransDataContainer *tc, O if (pid) { mul_m4_m4m4(pchan_mtx_final, pid->offset_mtx, pchan_mtx_final); } - BKE_pchan_apply_mat4(pchan, pchan_mtx_final, false); + + float rot[3][3]; + mat4_to_loc_rot_size(pchan->loc, rot, pchan->size, pchan_mtx_final); + + if (pchan->rotmode == ROT_MODE_EUL && pchan->rotmode == pchan_orig->rotmode) { + pchan->eul[0] = pchan_orig->eul[0]; + pchan->eul[1] = -pchan_orig->eul[1]; + pchan->eul[2] = -pchan_orig->eul[2]; + if (pid) { + BKE_pchan_mat3_to_rot(pchan, rot, true); + } + } + else { + BKE_pchan_mat3_to_rot(pchan, rot, false); + } /* Set flag to let auto key-frame know to key-frame the mirrored bone. */ pchan->bone->flag |= BONE_TRANSFORM_MIRROR; ``` There are certainly simpler ways to achieve this. Maybe we could just set `use_compat` to `true`.

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#114073

No description provided.