Regression: GPU Compositor wrong scale when using stabilize 2d #114167

New Issue

Closed

opened 2023-10-26 10:20:03 +02:00 by Lucas · 7 comments

Lucas commented

2023-10-26 10:20:03 +02:00

System Information
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3060/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 537.42

Blender Version
Broken: version: 4.1.0 Alpha, branch: main, commit date: 2023-10-25 16:58, hash: 247491ef0f42
Worked: 4.0

Short description of error
GPU Compositor wrong scale when using stabilize 2d
This commit Link fixed the issue with translation but there's still an issue with the scaling.
If I use the Scale node behind the Stabilize 2d one then it wont render properly, if instead I reverse the order, the render will be fine but the gpu display scaling will be off.
Exact steps for others to reproduce the error
[Please describe the exact steps needed to reproduce the issue]
[Based on the default startup or an attached .blend file (as simple as possible)]

**System Information** Operating system: Windows-10-10.0.19045-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3060/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 537.42 **Blender Version** Broken: version: 4.1.0 Alpha, branch: main, commit date: 2023-10-25 16:58, hash: `247491ef0f42` Worked: 4.0 **Short description of error** GPU Compositor wrong scale when using stabilize 2d This commit [Link](https://projects.blender.org/blender/blender/commit/3f49d286ccf9dc120ec40bdf0d0a479cb3a50f42) fixed the issue with translation but there's still an issue with the scaling. If I use the Scale node behind the Stabilize 2d one then it wont render properly, if instead I reverse the order, the render will be fine but the gpu display scaling will be off. **Exact steps for others to reproduce the error** [Please describe the exact steps needed to reproduce the issue] [Based on the default startup or an attached .blend file (as simple as possible)]

StabilizeScaleFrame0.jpg

104 KiB

ScaleStabilezeFrame0.jpg

101 KiB

GPUCompositor2.rar

1.0 MiB

ScaleStabilizeFrame40.jpg

103 KiB

Lucas added the

labels 2023-10-26 10:20:03 +02:00

Richard Antalik added

and removed

labels 2023-10-26 16:52:50 +02:00

Richard Antalik commented

2023-10-26 16:52:56 +02:00

Member

CC @OmarEmaraDev

CC @OmarEmaraDev

Omar Emara commented

2023-10-26 18:07:34 +02:00

Member

The scale node should be first as I explained in the other issue. What exactly do you mean by:

but the gpu display scaling will be off.

How is it wrong exactly?

The scale node should be first as I explained in the other issue. What exactly do you mean by: > but the gpu display scaling will be off. How is it wrong exactly?

Omar Emara added

Needs Information from User

and removed

labels 2023-10-26 18:07:44 +02:00

Lucas commented

2023-10-26 20:54:01 +02:00

Author

@OmarEmaraDev Putting scale first as you suggest will not render correctly, see picture ScaleStabilizeFrame40 on the left is the cpu render and on the right the gpu, notice the blue dot I drew on the corner of the eye compared to frame 0.(Blue dot is not on the corner of the eye meaning the face moved which means it wont render properly)
Now if I apply scale after the Stabilize node then it will render correctly but on the GPU it looks small (See the last picture). Compare the size of the face against one another, they don't match.

@OmarEmaraDev Putting scale first as you suggest will not render correctly, see picture ScaleStabilizeFrame40 on the left is the cpu render and on the right the gpu, notice the blue dot I drew on the corner of the eye compared to frame 0.(Blue dot is not on the corner of the eye meaning the face moved which means it wont render properly) Now if I apply scale after the Stabilize node then it will render correctly but on the GPU it looks small (See the last picture). Compare the size of the face against one another, they don't match.

Omar Emara commented

2023-10-26 21:10:15 +02:00

Member

@Xorrito But wouldn't that imply that the CPU compositor is the one with the faulty behavior here?

@Xorrito But wouldn't that imply that the CPU compositor is the one with the faulty behavior here?

Lucas commented

2023-10-26 21:28:49 +02:00

Author

@OmarEmaraDev It worked as expected in 4.0, the gpu and the cpu matched. Scaling before stabilizing would have to modify the stabilization transforms too right?. You always stabilize a footage and then apply scale to crop. Doing it backwards might work as a workaround for the GPU but pressing F12 still renders with the cpu...

@OmarEmaraDev It worked as expected in 4.0, the gpu and the cpu matched. Scaling before stabilizing would have to modify the stabilization transforms too right?. You always stabilize a footage and then apply scale to crop. Doing it backwards might work as a workaround for the GPU but pressing F12 still renders with the cpu...

Omar Emara commented

2023-10-26 21:41:16 +02:00

Member

We intentionally changed the behavior in 4.1, so the GPU behavior is the one to expect in the future. This behavior is also consistent with the Full Frame compositor, which will likely replace the current CPU compositor soon.

Essentially, the new behavior realizes the scaling and rotation transformations after transform nodes like the Scale and Stabilize 2D nodes. What this means is that the resolution of the images will change after scaling and rotation. And since stabilization relies on the resolution of the images, it matters where you put your scale node.

So for now, I recommend you use the Full Frame compositor as your CPU compositor until we finalize this design.

We intentionally changed the behavior in 4.1, so the GPU behavior is the one to expect in the future. This behavior is also consistent with the Full Frame compositor, which will likely replace the current CPU compositor soon. Essentially, the new behavior realizes the scaling and rotation transformations after transform nodes like the Scale and Stabilize 2D nodes. What this means is that the resolution of the images will change after scaling and rotation. And since stabilization relies on the resolution of the images, it matters where you put your scale node. So for now, I recommend you use the Full Frame compositor as your CPU compositor until we finalize this design.

Lucas commented

2023-10-26 21:54:10 +02:00

Author

I recommend you use the Full Frame compositor as your CPU compositor

Or I could render the viewport from the view menu. Well thanks anyways, you are doing a fantastic job, GPU Compositor is very innovative and wanted it to work so bad.

> I recommend you use the Full Frame compositor as your CPU compositor Or I could render the viewport from the view menu. Well thanks anyways, you are doing a fantastic job, GPU Compositor is very innovative and wanted it to work so bad.

Omar Emara closed this issue

2023-10-27 08:19:45 +02:00

Blender Bot added

and removed

Needs Information from User

labels 2023-10-27 08:19:47 +02:00

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#114167

No description provided.