Blur attribute node face corner handling #114275

New Issue

Simon Thommes · 2023-10-30T15:27:26+01:00

Simon Thommes commented

2023-10-30 15:27:26 +01:00

Every iteration, each face corner should get the average value of:

The corners sharing the same vertex
The next and previous corner in the same face
Itself

Every iteration, each face corner should get the average value of: - The corners sharing the same vertex - The next and previous corner in the same face - Itself

Simon Thommes added the

Type

Design

label 2023-10-30 15:27:26 +01:00

Simon Thommes added this to the Nodes & Physics project 2023-10-30 15:27:28 +01:00

Iliya Katushenock added the

Interest

Geometry Nodes

label 2023-10-30 15:32:44 +01:00

Iliya Katushenock commented

2023-10-30 15:37:28 +01:00

What is better, add this new behavior, and versioning code to not change old files by new domain, or Jagged Field long time solution?

Simon Thommes referenced this issue

2023-10-30 16:30:06 +01:00

Overall usability checkup #114280

Hans Goudey commented

2023-10-30 17:40:32 +01:00

Implementing the blur attribute node as a node group that uses list fields internally is definitely a better long term solution. In the meantime though, I think implementing this mixing is reasonable, and would solve user frustration about this arbitrarily not working.

Blur might be a nice use case for list fields actually, it's fairly straightforward and the benefits of more flexible mixing are pretty clear.

Implementing the blur attribute node as a node group that uses list fields internally is definitely a better long term solution. In the meantime though, I think implementing this mixing is reasonable, and would solve user frustration about this arbitrarily not working. Blur might be a nice use case for list fields actually, it's fairly straightforward and the benefits of more flexible mixing are pretty clear.

Iliya Katushenock commented

2023-11-07 19:15:13 +01:00

New domain can be done as new separate code path. This require new blur function.
Function should contains main loop with parts:

Mixing values from other corners on self vertex. This can be done by creating new GroupedSpan of indices (via mesh topology processing functions (see BKE_mesh_mapping.hh, and function to build map of corner indices for each vertex).
Mixing values from next and previous corners. To do that, simply iterate in front and back for a loops and use face_corner_prev / face_corner_next functions from bke.
Default initialization by original span values will be done by default in case a mixer constructor is called with empty mask.

New domain can be done as new separate code path. This require new blur function. Function should contains main loop with parts: - Mixing values from other corners on self vertex. This can be done by creating new `GroupedSpan` of indices (via mesh topology processing functions (see `BKE_mesh_mapping.hh`, and function to build map of corner indices for each vertex). - Mixing values from next and previous corners. To do that, simply iterate in front and back for a loops and use `face_corner_prev` / `face_corner_next` functions from `bke`. - Default initialization by original span values will be done by default in case a mixer constructor is called with empty mask.

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Blur attribute node face corner handling #114275