Possible regression: Warning messages during startup about missing properties in keymap assignments #114321

New Issue

Ingo Clemens · 2023-10-31T12:31:23+01:00

Ingo Clemens commented

2023-10-31 12:31:23 +01:00

System Information
Operating system: macOS-13.5.2-arm64-arm-64bit 64 Bits
Graphics card: Metal API Apple M1 Max 1.2

Blender Version
Broken: version: 4.0.0 Beta, branch: blender-v4.0-release, commit date: 2023-10-30 23:38, hash: b27ff093caa0
Worked: 3.6.1 (possible latest 3.6.x but not tested)

Short description of error
When a custom keymap file contains entries which have been added by add-ons the current release gives a warning for each during startup.
This could look like this:

Warning: property 'with_menu' not found in item 'OperatorProperties'
Warning: property 'run_in_geometry_nodes' not found in item 'OperatorProperties'
Warning: property 'option' not found in item 'OperatorProperties'

These properties are related to the Node Wrangler add-on.
All warnings occur multiple times. The number of repeats is the same and probably related to re-saving the existing keymap file after making some keymap adjustments. The assumption is, that when an add-on gets registered and adds its keymaps these are added even though they already might exist. If the user then saved the keymaps to a file he saves the data already doubled up.
I tried to replicate this behaviour but without success. Nevertheless, something like this must have happened in the past when carrying the keymaps file from one version of Blender to the next.

Check the attached keymap file and search for 'node.nw_merge_nodes' for example.

If all reported occurrences are removed from the file Blender doesn't report any warnings anymore.
This behaviour is new in the current 4.0 beta release.

This also leads to another question: Why does Blender add duplicate keymaps in the first place? The aforementioned Node Wrangler keymaps are occurring multiple times, you can even search for the entire data entry.
Shouldn't be Blender so smart to check if a keymap already exists with the exact properties before adding it? Because, if it exists there's no need to add another entry.
(This should probably be a separate bug report)

Exact steps for others to reproduce the error

Select the attached keymap file in the preferences.
Restart Blender and check the console output.

**System Information** Operating system: macOS-13.5.2-arm64-arm-64bit 64 Bits Graphics card: Metal API Apple M1 Max 1.2 **Blender Version** Broken: version: 4.0.0 Beta, branch: blender-v4.0-release, commit date: 2023-10-30 23:38, hash: `b27ff093caa0` Worked: 3.6.1 (possible latest 3.6.x but not tested) **Short description of error** When a custom keymap file contains entries which have been added by add-ons the current release gives a warning for each during startup. This could look like this: ``` Warning: property 'with_menu' not found in item 'OperatorProperties' Warning: property 'run_in_geometry_nodes' not found in item 'OperatorProperties' Warning: property 'option' not found in item 'OperatorProperties' ``` These properties are related to the Node Wrangler add-on. All warnings occur multiple times. The number of repeats is the same and probably related to re-saving the existing keymap file after making some keymap adjustments. The assumption is, that when an add-on gets registered and adds its keymaps these are added even though they already might exist. If the user then saved the keymaps to a file he saves the data already doubled up. I tried to replicate this behaviour but without success. Nevertheless, something like this must have happened in the past when carrying the keymaps file from one version of Blender to the next. Check the attached keymap file and search for 'node.nw_merge_nodes' for example. If all reported occurrences are removed from the file Blender doesn't report any warnings anymore. This behaviour is new in the current 4.0 beta release. This also leads to another question: Why does Blender add duplicate keymaps in the first place? The aforementioned Node Wrangler keymaps are occurring multiple times, you can even search for the entire data entry. Shouldn't be Blender so smart to check if a keymap already exists with the exact properties before adding it? Because, if it exists there's no need to add another entry. (This should probably be a separate bug report) **Exact steps for others to reproduce the error** 1. Select the attached keymap file in the preferences. 2. Restart Blender and check the console output.

customKeymap.py

436 KiB

👍 1

Ingo Clemens added the

labels 2023-10-31 12:31:24 +01:00

Germano Cavalcante commented

2023-10-31 19:30:03 +01:00

Warnings are not considered bugs. They inform the user that there is something wrong with their configuration. Different versions of the Node Wranger addon can cause this issue.

By the way, it doesn't seem ideal to save the Node Wrangler add-on keyitems. If I'm not mistaken they are added when enabling the addon. If the user already has these keyitems saved, could they create these duplicates?

Whatever the case, this seems to be an issue with the "Node Wrangler" add-on, so it should have been reported in the blender-addons repository instead of the blender repository.

Perhaps the addon should check if the keyitems already exists in the user's custom keymap before adding new ones.

@braverabbit, could you please use the following link to report the issue? https://projects.blender.org/blender/blender-addons/issues/new/choose

Also, make sure you find the steps to generate this weird customKeymap.py.

Warnings are not considered bugs. They inform the user that there is something wrong with their configuration. Different versions of the Node Wranger addon can cause this issue. By the way, it doesn't seem ideal to save the Node Wrangler add-on keyitems. If I'm not mistaken they are added when enabling the addon. If the user already has these keyitems saved, could they create these duplicates? Whatever the case, this seems to be an issue with the "Node Wrangler" add-on, so it should have been reported in the [blender-addons](https://projects.blender.org/blender/blender-addons) repository instead of the [blender](https://projects.blender.org/blender/blender) repository. Perhaps the addon should check if the keyitems already exists in the user's custom keymap before adding new ones. @braverabbit, could you please use the following link to report the issue? https://projects.blender.org/blender/blender-addons/issues/new/choose Also, make sure you find the steps to generate this weird `customKeymap.py`.

Germano Cavalcante added

Status

Needs Information from User

and removed

Status

Needs Triage

labels 2023-10-31 19:30:13 +01:00

Ingo Clemens commented

2023-10-31 20:43:56 +01:00

The main intention for the report lies within the fact that the warning report of Blender during startup is something new. The same keymap has been used in previous versions (with the same double entries) and there never has been any report or warning.
Therefore it doesn't matter what the add-on does or doesn't do, it's rather a matter of what Blender does when it reads the keymap file.

And this behaviour has changed. That's about all I wanted to report. I talked to a dev during BCON and he suggested to post this as a possible regression by the sound of it.

Therefore it would be interesting to see if something has been added as an improvement to check the keymaps while reading the file or if something has been changed which now leads to an "uncaught" warning report.

I have tried to replicate this "duplicating" behaviour but so far I haven't been successful. Even though saving the keymap with the enabled add-ons seems to be the only viable explanation.

Of course I would be happy to report the issue to the add-ons repository but it's more of a general issue. Node Wrangler has just been mentioned for the sake if simplicity but it basically affects all add-ons which come with their own keymap assignments.
All these add-ons work the same way when adding custom keymaps and there is no indication that any one of them has checks for existing assignments. Hence the thought that it maybe should be within the responsibility of the Blender core to check for doubles. Just a thought.

The main intention for the report lies within the fact that the warning report of Blender during startup is something new. The same keymap has been used in previous versions (with the same double entries) and there never has been any report or warning. Therefore it doesn't matter what the add-on does or doesn't do, it's rather a matter of what Blender does when it reads the keymap file. And this behaviour has changed. That's about all I wanted to report. I talked to a dev during BCON and he suggested to post this as a possible regression by the sound of it. Therefore it would be interesting to see if something has been added as an improvement to check the keymaps while reading the file or if something has been changed which now leads to an "uncaught" warning report. I have tried to replicate this "duplicating" behaviour but so far I haven't been successful. Even though saving the keymap with the enabled add-ons seems to be the only viable explanation. Of course I would be happy to report the issue to the add-ons repository but it's more of a general issue. Node Wrangler has just been mentioned for the sake if simplicity but it basically affects all add-ons which come with their own keymap assignments. All these add-ons work the same way when adding custom keymaps and there is no indication that any one of them has checks for existing assignments. Hence the thought that it maybe should be within the responsibility of the Blender core to check for doubles. Just a thought.

Germano Cavalcante commented

2023-10-31 20:59:32 +01:00

warning report of Blender during startup is something new.

This is not something new.
This is actually quite old (maybe before version 2.5).
If you import a keymap that sets a non-existing property to an operator, the same message appears in, for example, Blender 2.73.

Apparently, the properties 'with_menu', 'run_in_geometry_nodes' and 'option' previously existed for the "OperatorProperties" of the "Node Wrangler" add-on. They no longer appear to exist in the new version of the add-on.

The problem is that you have these hotkeys included in customKeymap.py.

I recommend deleting all hotkeys from "Node Wrangler". And export the keymap again.

> warning report of Blender during startup is something new. This is not something new. This is actually quite old (maybe before version 2.5). If you import a keymap that sets a non-existing property to an operator, the same message appears in, for example, Blender 2.73. Apparently, the properties 'with_menu', 'run_in_geometry_nodes' and 'option' previously existed for the "OperatorProperties" of the "Node Wrangler" add-on. They no longer appear to exist in the new version of the add-on. The problem is that you have these hotkeys included in `customKeymap.py`. I recommend deleting all hotkeys from "Node Wrangler". And export the keymap again.

Ingo Clemens commented

2023-10-31 21:31:58 +01:00

Yes, this seems to make sense. Thanks for looking into it.
I already cleaned up the file manually but wanted to report.
Thanks for your time.

Yes, this seems to make sense. Thanks for looking into it. I already cleaned up the file manually but wanted to report. Thanks for your time.

Ingo Clemens closed this issue

2023-10-31 21:32:00 +01:00

Blender Bot added

Status

Archived

and removed

Status

Needs Information from User