Colors in theme do not match in Shader Editor #114394

New Issue

Eugene Du · 2023-11-02T09:00:22+01:00

Eugene Du commented

2023-11-02 09:00:22 +01:00

System Information
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1650 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 537.58

Blender Version
Broken: version: 3.6.5, branch: blender-v3.6-release, commit date: 2023-10-16 14:30, hash: cf1e1ed46b7e
Worked: (newest version of Blender that worked as expected)

Short description of error
how to properly setup color in theme to match in Shader Editor?

Exact steps for others to reproduce the error
Default Blender Dark theme colors.
Try to compare color in Properties with output colors in Shader Editor

**System Information** Operating system: Windows-10-10.0.19045-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1650 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 537.58 **Blender Version** Broken: version: 3.6.5, branch: blender-v3.6-release, commit date: 2023-10-16 14:30, hash: `cf1e1ed46b7e` Worked: (newest version of Blender that worked as expected) **Short description of error** how to properly setup color in theme to match in Shader Editor? **Exact steps for others to reproduce the error** Default Blender Dark theme colors. Try to compare color in Properties with output colors in Shader Editor ![Match_Theme_Color_with_View.png](/attachments/6687a747-e9d7-4d03-b80b-2816740b702f)

Match_Theme_Color_with_View.png

194 KiB

Eugene Du added the

labels 2023-11-02 09:00:23 +01:00

Eugene Du changed title from ~~Colors in theme do not match in any view~~ to Colors in theme do not match in Shader Editor

2023-11-02 09:02:00 +01:00

Pratik Borhade commented

2023-11-02 10:18:13 +01:00

Hi, thanks for the report. This is not a bug AFAICT. For header, color is mixed with the node color, see: https://projects.blender.org/blender/blender/src/branch/main/source/blender/editors/space_node/node_draw.cc#L2901

UI_GetThemeColorBlend4f(TH_NODE, color_id, 0.4f, color_header);

Hi, thanks for the report. This is not a bug AFAICT. For header, color is mixed with the node color, see: https://projects.blender.org/blender/blender/src/branch/main/source/blender/editors/space_node/node_draw.cc#L2901 `UI_GetThemeColorBlend4f(TH_NODE, color_id, 0.4f, color_header);`

Pratik Borhade closed this issue

2023-11-02 10:18:16 +01:00

Blender Bot added

and removed

labels 2023-11-02 10:18:18 +01:00

Philipp Oeser commented

2023-11-02 10:36:53 +01:00

The resulting colors are a blend with the Node Backdrop color

UI_GetThemeColorBlend4f(TH_NODE, color_id, 0.4f, result);

If that would read UI_GetThemeColorBlend4f(TH_NODE, color_id, 1.0f, result); you would get exactly the colors from the Theme Preferences. I assume this is made the way it is to make this [a] readable in most scenarios and [b] to still have some "common" ground between all nodes.

@pablovazquez could probably comment more on this.

I will close this issue already however, since this seems to all work as expected, thx reporting anyways!

The resulting colors are a blend with the `Node Backdrop` color ![image](/attachments/8b327a1d-a436-49cc-ad5e-d33365bc486b) `UI_GetThemeColorBlend4f(TH_NODE, color_id, 0.4f, result);` If that would read `UI_GetThemeColorBlend4f(TH_NODE, color_id, 1.0f, result);` you would get exactly the colors from the Theme Preferences. I assume this is made the way it is to make this [a] readable in most scenarios and [b] to still have some "common" ground between all nodes. @pablovazquez could probably comment more on this. I will close this issue already however, since this seems to all work as expected, thx reporting anyways!

image.png

37 KiB

Philipp Oeser commented

2023-11-02 10:37:29 +01:00

Ah, @PratikPB2123 was quicker, sorry for the duplicate efforts...

Pablo Vazquez commented

2023-11-03 13:00:01 +01:00

I assume this is made the way it is to make this [a] readable in most scenarios and [b] to still have some "common" ground between all nodes.

Exactly. Since there is only one color for text in the entire editor but nodes can have multiple colors and backgrounds, users can very easily run into cases where text is hard to read. We could try to find a way to solve this but not a high priority right now.

> I assume this is made the way it is to make this [a] readable in most scenarios and [b] to still have some "common" ground between all nodes. Exactly. Since there is only one color for text in the entire editor but nodes can have multiple colors and backgrounds, users can very easily run into cases where text is hard to read. We could try to find a way to solve this but not a high priority right now.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Colors in theme do not match in Shader Editor #114394