Regression: After clean 4.0 unpack Blender did not grab my theme from 3.6 #114432

New Issue

Vyacheslav Kobozev · 2023-11-03T02:33:08+01:00

2023-11-03 02:33:08 +01:00

System Information
Operating system: Windows-10-10.0.17763-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3060/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 537.42

Blender Version
Broken: version: 4.0.0 Beta, branch: blender-v4.0-release, commit date: 2023-11-01 18:27, hash: 0b81a163e256
Worked: 3.6.5

Short description of error
I use zip version. When I started, I restored settings from 3.6. Looks like all settings are fine except theme.
So i was forced to install theme from .xml on my own.

Exact steps for others to reproduce the error

Download zip-version of 4.0 beta
Clear configs of 4.0 and 3.6
Unzip attached file and paste it in 3.6 configs
Launch 3.6 to check the new theme
Launch 4.0 then restore 3.6 settings

Here is my config folder to test. Is there anything else i can provide?
AFAIK theme and keymap are baked into userpref.blend

**System Information** Operating system: Windows-10-10.0.17763-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3060/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 537.42 **Blender Version** Broken: version: 4.0.0 Beta, branch: blender-v4.0-release, commit date: 2023-11-01 18:27, hash: `0b81a163e256` Worked: 3.6.5 **Short description of error** I use zip version. When I started, I restored settings from 3.6. Looks like all settings are fine except theme. So i was forced to install theme from .xml on my own. **Exact steps for others to reproduce the error** - Download zip-version of 4.0 beta - Clear configs of 4.0 and 3.6 - Unzip attached file and paste it in 3.6 configs - Launch 3.6 to check the new theme - Launch 4.0 then restore 3.6 settings Here is my config folder to test. Is there anything else i can provide? AFAIK theme and keymap are baked into userpref.blend

config.zip

358 KiB

Vyacheslav Kobozev added the

labels 2023-11-03 02:33:09 +01:00

Pratik Borhade commented

2023-11-03 06:10:28 +01:00

Hi, thanks for the report. Where should I unzip the config.zip?
Well I unzip it in 3.6 folder, cleared 4.0 configs then launched 4.0 to load 3.6 settings and indeed the theme is not restored
This is due to the 86ccbc4353
Now the fix looks incorrect to me. Instead of restoring the complete theme, fix should be just changing the UIList color

Hi, thanks for the report. Where should I unzip the `config.zip`? Well I unzip it in 3.6 folder, cleared 4.0 configs then launched 4.0 to load 3.6 settings and indeed the theme is not restored This is due to the 86ccbc43532001eae3704144eddab24e31c8761a Now the fix looks incorrect to me. Instead of restoring the complete theme, fix should be just changing the UIList color

Pratik Borhade added

Status

Needs Information from User

and removed

Status

Needs Triage

labels 2023-11-03 06:12:28 +01:00

Pratik Borhade commented

2023-11-04 07:16:08 +01:00

Where should I unzip the config.zip?

I'll change the tag to need info for now to know whether my understanding is correct or not. (Should be high prio bug if above findings are correct)

> Where should I unzip the `config.zip`? I'll change the tag to `need info` for now to know whether my understanding is correct or not. (Should be high prio bug if above findings are correct)

Vyacheslav Kobozev commented

2023-11-04 07:41:00 +01:00

Hi, thanks for the report. Where should I unzip the config.zip?
Well I unzip it in 3.6 folder, cleared 4.0 configs then launched 4.0 to load 3.6 settings and indeed the theme is not restored
This is due to the 86ccbc4353
Now the fix looks incorrect to me. Instead of restoring the complete theme, fix should be just changing the UIList color

config should exist for b3.6 in the AppData\Roaming\Blender Foundation\Blender\3.6
so it is supposed to be taken from there

> Hi, thanks for the report. Where should I unzip the `config.zip`? > Well I unzip it in 3.6 folder, cleared 4.0 configs then launched 4.0 to load 3.6 settings and indeed the theme is not restored > This is due to the 86ccbc43532001eae3704144eddab24e31c8761a > Now the fix looks incorrect to me. Instead of restoring the complete theme, fix should be just changing the UIList color config should exist for b3.6 in the AppData\Roaming\Blender Foundation\Blender\3.6 so it is supposed to be taken from there

Pratik Borhade commented

2023-11-06 09:48:20 +01:00

Thanks. So the assumption was right. Raising the priority.

Pratik Borhade changed title from ~~After clean unpack Blender did not grab my theme from 3.6~~ to Regression: After clean 4.0 unpack Blender did not grab my theme from 3.6

2023-11-06 09:48:48 +01:00

Pratik Borhade added

and removed

Needs Information from User

labels 2023-11-06 09:50:30 +01:00

Pratik Borhade commented

2023-11-06 09:50:51 +01:00

This is due to the 86ccbc4353
Now the fix looks incorrect to me. Instead of restoring the complete theme, fix should be just changing the UIList color

cc @pablovazquez

> This is due to the 86ccbc4353 Now the fix looks incorrect to me. Instead of restoring the complete theme, fix should be just changing the UIList color cc @pablovazquez

Pratik Borhade added this to the 4.0 milestone 2023-11-06 10:12:49 +01:00

Julian Eisel commented

2023-11-06 21:15:18 +01:00

Now the fix looks incorrect to me. Instead of restoring the complete theme, fix should be just changing the UIList color

Indeed, we should avoid resetting all theme customization, I see no need for that here.

> Now the fix looks incorrect to me. Instead of restoring the complete theme, fix should be just changing the UIList color Indeed, we should avoid resetting all theme customization, I see no need for that here.

👍 1

Germano Cavalcante referenced this issue

2023-11-08 20:44:54 +01:00

UserPref theme colors ignored to draw UI #114642

Pratik Borhade referenced this issue

2023-11-09 10:39:10 +01:00

the same userpref File is loaded to give different results in the same blender version from different commit dates #114405

Julian Eisel referenced a pull request that will close this issue

2023-11-09 16:50:12 +01:00

Fix #114432: Custom themes overridden by default theme #114675

Julian Eisel referenced this issue from a commit

2023-11-10 11:33:26 +01:00