Crash when right clicking certain, nested, popup dialogs #114436

New Issue

Jesse Yurkovich · 2023-11-03T06:25:33+01:00

Jesse Yurkovich commented

2023-11-03 06:25:33 +01:00

System Information
Operating system: Windows-10-10.0.22621-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 4090/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 528.24

Blender Version
Broken: version: 4.0.0 Beta, branch: blender-v4.0-release, commit date: 2023-11-03 01:01, hash: 5d765a0d31a1
Worked: 3.6.5

Caused by 088d7a0bdd

Short description of error
Crash when right clicking certain, nested, popup dialogs. Unsure how far-reaching this is or if it's only limited to the dialog below.

Exact steps for others to reproduce the error

Open blender
Click File -> Defaults -> Save Startup File
A popup asking for confirmation will appear with "Save Startup File" as the only entry
Right click that entry

Stack trace:
blender.exe         :0x00007FF65CD32030  ui_region_winrct_get_no_margin
blender.exe         :0x00007FF65CD97E80  ui_region_contains_point_px
blender.exe         :0x00007FF65CD980B0  ui_view_item_find_mouse_over
blender.exe         :0x00007FF65CD58F40  ui_do_button
blender.exe         :0x00007FF65CD5A730  ui_handle_button_event
blender.exe         :0x00007FF65CD5B5F0  ui_handle_menu_button
blender.exe         :0x00007FF65CD5B790  ui_handle_menu_event
blender.exe         :0x00007FF65CD5C8D0  ui_handle_menus_recursive
blender.exe         :0x00007FF65CD617D0  ui_popup_handler

**System Information** Operating system: Windows-10-10.0.22621-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 4090/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 528.24 **Blender Version** Broken: version: 4.0.0 Beta, branch: blender-v4.0-release, commit date: 2023-11-03 01:01, hash: `5d765a0d31a1` Worked: 3.6.5 Caused by 088d7a0bdd8e341830f015c82834749ef90ed2ff **Short description of error** Crash when right clicking certain, nested, popup dialogs. Unsure how far-reaching this is or if it's only limited to the dialog below. **Exact steps for others to reproduce the error** - Open blender - Click `File` -> `Defaults` -> `Save Startup File` - A popup asking for confirmation will appear with "Save Startup File" as the only entry - Right click that entry ``` Stack trace: blender.exe :0x00007FF65CD32030 ui_region_winrct_get_no_margin blender.exe :0x00007FF65CD97E80 ui_region_contains_point_px blender.exe :0x00007FF65CD980B0 ui_view_item_find_mouse_over blender.exe :0x00007FF65CD58F40 ui_do_button blender.exe :0x00007FF65CD5A730 ui_handle_button_event blender.exe :0x00007FF65CD5B5F0 ui_handle_menu_button blender.exe :0x00007FF65CD5B790 ui_handle_menu_event blender.exe :0x00007FF65CD5C8D0 ui_handle_menus_recursive blender.exe :0x00007FF65CD617D0 ui_popup_handler ```

Jesse Yurkovich added the

labels 2023-11-03 06:25:34 +01:00

Pratik Borhade commented

2023-11-03 07:33:19 +01:00

Yes, can confirm the crash.

Caused by 088d7a0bdd

@JulianEisel ^

Yes, can confirm the crash. > Caused by 088d7a0bdd @JulianEisel ^

Pratik Borhade added

and removed

labels 2023-11-03 07:33:33 +01:00

Pratik Borhade added this to the 4.0 milestone 2023-11-03 07:45:16 +01:00

Philipp Oeser commented

2023-11-03 09:25:18 +01:00

Not sure if this is fine for all scenarios, but using uiHandleButtonData's region seems to work fine here

diff --git a/source/blender/editors/interface/interface_handlers.cc b/source/blender/editors/interface/interface_handlers.cc
index 0284ef5b700..5465d14f8c0 100644
--- a/source/blender/editors/interface/interface_handlers.cc
+++ b/source/blender/editors/interface/interface_handlers.cc
@@ -8054,9 +8054,9 @@ static int ui_do_button(bContext *C, uiBlock *block, uiBut *but, const wmEvent *
        * Apply the button immediately, so context menu polls get the right active item. */
       uiBut *clicked_view_item_but = but->type == UI_BTYPE_VIEW_ITEM ?
                                          but :
-                                         ui_view_item_find_mouse_over(region, event->xy);
+                                         ui_view_item_find_mouse_over(but->active->region, event->xy);
       if (clicked_view_item_but) {
-        UI_but_execute(C, region, clicked_view_item_but);
+        UI_but_execute(C, but->active->region, clicked_view_item_but);
       }
 
       /* RMB has two options now */

Not sure if this is fine for all scenarios, but using `uiHandleButtonData`'s region seems to work fine here ``` diff --git a/source/blender/editors/interface/interface_handlers.cc b/source/blender/editors/interface/interface_handlers.cc index 0284ef5b700..5465d14f8c0 100644 --- a/source/blender/editors/interface/interface_handlers.cc +++ b/source/blender/editors/interface/interface_handlers.cc @@ -8054,9 +8054,9 @@ static int ui_do_button(bContext *C, uiBlock *block, uiBut *but, const wmEvent * * Apply the button immediately, so context menu polls get the right active item. */ uiBut *clicked_view_item_but = but->type == UI_BTYPE_VIEW_ITEM ? but : - ui_view_item_find_mouse_over(region, event->xy); + ui_view_item_find_mouse_over(but->active->region, event->xy); if (clicked_view_item_but) { - UI_but_execute(C, region, clicked_view_item_but); + UI_but_execute(C, but->active->region, clicked_view_item_but); } /* RMB has two options now */ ```

Philipp Oeser commented

2023-11-03 09:26:30 +01:00

Similar to !114363 ^^

Julian Eisel was assigned by Dalai Felinto

2023-11-03 16:29:26 +01:00

Julian Eisel commented

2023-11-06 10:55:56 +01:00

Not sure if this is fine for all scenarios, but using uiHandleButtonData's region seems to work fine here

diff --git a/source/blender/editors/interface/interface_handlers.cc b/source/blender/editors/interface/interface_handlers.cc
index 0284ef5b700..5465d14f8c0 100644
--- a/source/blender/editors/interface/interface_handlers.cc
+++ b/source/blender/editors/interface/interface_handlers.cc
@@ -8054,9 +8054,9 @@ static int ui_do_button(bContext *C, uiBlock *block, uiBut *but, const wmEvent *
        * Apply the button immediately, so context menu polls get the right active item. */
       uiBut *clicked_view_item_but = but->type == UI_BTYPE_VIEW_ITEM ?
                                          but :
-                                         ui_view_item_find_mouse_over(region, event->xy);
+                                         ui_view_item_find_mouse_over(but->active->region, event->xy);
       if (clicked_view_item_but) {
-        UI_but_execute(C, region, clicked_view_item_but);
+        UI_but_execute(C, but->active->region, clicked_view_item_but);
       }
 
       /* RMB has two options now */

That seems mostly correct, except that data->region should be used, instead of but->active->region. This way events can be sent to buttons that are not active (by passing custom uiHandleButtonData as data for a non-active button). We're not strict enough about this yet though.

> Not sure if this is fine for all scenarios, but using `uiHandleButtonData`'s region seems to work fine here > > > ``` > diff --git a/source/blender/editors/interface/interface_handlers.cc b/source/blender/editors/interface/interface_handlers.cc > index 0284ef5b700..5465d14f8c0 100644 > --- a/source/blender/editors/interface/interface_handlers.cc > +++ b/source/blender/editors/interface/interface_handlers.cc > @@ -8054,9 +8054,9 @@ static int ui_do_button(bContext *C, uiBlock *block, uiBut *but, const wmEvent * > * Apply the button immediately, so context menu polls get the right active item. */ > uiBut *clicked_view_item_but = but->type == UI_BTYPE_VIEW_ITEM ? > but : > - ui_view_item_find_mouse_over(region, event->xy); > + ui_view_item_find_mouse_over(but->active->region, event->xy); > if (clicked_view_item_but) { > - UI_but_execute(C, region, clicked_view_item_but); > + UI_but_execute(C, but->active->region, clicked_view_item_but); > } > > /* RMB has two options now */ > ``` That seems mostly correct, except that `data->region` should be used, instead of `but->active->region`. This way events can be sent to buttons that are not active (by passing custom `uiHandleButtonData` as `data` for a non-active button). We're not strict enough about this yet though.

Philipp Oeser commented

2023-11-06 11:17:21 +01:00

@JulianEisel : do you want to handle? (otherwise I can try to make a PR -- not sure though if you mean passing in uiHandleButtonData from everywhere to ui_do_button? atm. data is just retrieved as but->active at the beginning of ui_do_button)

@JulianEisel : do you want to handle? (otherwise I can try to make a PR -- not sure though if you mean passing in `uiHandleButtonData` from everywhere to `ui_do_button`? atm. data is just retrieved as `but->active` at the beginning of `ui_do_button`)

Julian Eisel referenced this issue from a commit

2023-11-06 21:53:49 +01:00

Fix #114436: Crash when right clicking certain, nested, popup dialogs

Julian Eisel closed this issue

2023-11-06 21:54:41 +01:00

Blender Bot added

and removed

labels 2023-11-06 21:54:43 +01:00