New Node interface API is ambiguous on socket removal #114481

New Issue

Open

opened 2023-11-04 13:10:15 +01:00 by Simarilius · 4 comments

Simarilius commented

2023-11-04 13:10:15 +01:00

Blender Version
Broken: 4.0
Worked: 3.6

Short description of error
the python api has changed from tree.inputs.new(name="My Input") to tree.interface.new_socket(name="My Input", in_out='INPUT'), and tree.inputs.remove(socket) to tree.interface.remove(socket)
without requiring the socket type in the removal means if you have an input and output with the same name, then you cant tell what it will delete.

**Blender Version** Broken: 4.0 Worked: 3.6 **Short description of error** the python api has changed from tree.inputs.new(name="My Input") to tree.interface.new_socket(name="My Input", in_out='INPUT'), and tree.inputs.remove(socket) to tree.interface.remove(socket) without requiring the socket type in the removal means if you have an input and output with the same name, then you cant tell what it will delete.

Simarilius added the

labels 2023-11-04 13:10:16 +01:00

Pratik Borhade commented

2023-11-06 11:42:01 +01:00

Member

Hi, thanks for the report. I agree with the idea to have one parameter to distinguish input/output sockets for remove operator
I'll update the description with example.

Hi, thanks for the report. I agree with the idea to have one parameter to distinguish input/output sockets for remove operator I'll update the description with example.

Pratik Borhade added

Nodes & Physics

and removed

labels 2023-11-06 11:42:19 +01:00

Pratik Borhade commented

2023-11-06 11:50:24 +01:00

Member

Before that, I would be interested to know the method you used for obtaining the desired socket. I'll share my code with you:

node_tree = D.node_groups['Geometry Nodes']
node_tree.interface.new_socket(name="new-socket", in_out='INPUT')
node_tree.interface.new_socket(name="new-socket", in_out='OUTPUT')

socket_to_remove = node_tree.interface.items_tree['new-socket'] #get socket to delete (this is returning the recent socket with matching name)

node_tree.interface.remove(socket_to_remove)

Before that, I would be interested to know the method you used for obtaining the desired socket. I'll share my code with you: ``` node_tree = D.node_groups['Geometry Nodes'] node_tree.interface.new_socket(name="new-socket", in_out='INPUT') node_tree.interface.new_socket(name="new-socket", in_out='OUTPUT') socket_to_remove = node_tree.interface.items_tree['new-socket'] #get socket to delete (this is returning the recent socket with matching name) node_tree.interface.remove(socket_to_remove) ```

Pratik Borhade added

Needs Information from User

and removed

labels 2023-11-06 11:50:33 +01:00

Simarilius commented

2023-11-10 15:32:50 +01:00

Author

I think I'd misunderstood the example to be honest, I was assuming the socket in the remove was the key, rather than you having to find it. The whole update to the interfaces is kind of a clusterf to be honest, its a lot worse to work with than the old interface. Everything takes longer more verbose commands to do, and several ops are now ambiguous and require iterating over things before you can use them usefully.

Think you'd have to do
socket_to_remove = [s for s in node_tree.interface.items_tree if s.name=='new-socket' and s.in_out=='INPUT'][0]
or something along those lines to be sure

I think I'd misunderstood the example to be honest, I was assuming the socket in the remove was the key, rather than you having to find it. The whole update to the interfaces is kind of a clusterf to be honest, its a lot worse to work with than the old interface. Everything takes longer more verbose commands to do, and several ops are now ambiguous and require iterating over things before you can use them usefully. Think you'd have to do socket_to_remove = [s for s in node_tree.interface.items_tree if s.name=='new-socket' and s.in_out=='INPUT'][0] or something along those lines to be sure

Pratik Borhade commented

2023-11-14 12:16:44 +01:00

Member

yes, the issue is not related to interface.remove, instead obtaining desired socket looks more lengthy than the old method.
I'll poke GN devs for awareness (they might be aware already 🙂 ). cc @HooglyBoogly @JacquesLucke

yes, the issue is not related to `interface.remove`, instead obtaining desired socket looks more lengthy than the old method. I'll poke GN devs for awareness (they might be aware already 🙂 ). cc @HooglyBoogly @JacquesLucke

Pratik Borhade added

Needs Info from Developers

and removed

Needs Information from User

labels 2023-11-14 12:16:59 +01:00

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#114481

No description provided.