Face Nearest snapping broken #114596

New Issue

Closed

opened 2023-11-07 19:32:18 +01:00 by Julien Kaspar · 7 comments

Julien Kaspar commented

2023-11-07 19:32:18 +01:00

Member

System Information
Operating system: Linux-6.5.6-gentoo-x86_64-AMD_Ryzen_Threadripper_1950X_16-Core_Processor-with-glibc2.37 64 Bits, X11 UI
Graphics card: AMD Radeon RX 7900 XT (gfx1100, LLVM 16.0.6, DRM 3.54, 6.5.6-gentoo) AMD 4.6 (Core Profile) Mesa 23.2.1

Blender Version
Broken: version: 4.1.0 Alpha, branch: main, commit date: 2023-11-07 11:49, hash: 869372ffc335
Worked: (newest version of Blender that worked as expected)

Short description of error
I only had this happen in specific work files. I don't know how to reproduce this from a new file but I included a simplified example .blend.
Altering the objects or collections can sometimes fix the issue.

Exact steps for others to reproduce the error

Open the example file
Move the sphere mesh (See the broken face nearest snapping)

**System Information** Operating system: Linux-6.5.6-gentoo-x86_64-AMD_Ryzen_Threadripper_1950X_16-Core_Processor-with-glibc2.37 64 Bits, X11 UI Graphics card: AMD Radeon RX 7900 XT (gfx1100, LLVM 16.0.6, DRM 3.54, 6.5.6-gentoo) AMD 4.6 (Core Profile) Mesa 23.2.1 **Blender Version** Broken: version: 4.1.0 Alpha, branch: main, commit date: 2023-11-07 11:49, hash: `869372ffc335` Worked: (newest version of Blender that worked as expected) **Short description of error** I only had this happen in specific work files. I don't know how to reproduce this from a new file but I included a simplified example .blend. Altering the objects or collections can sometimes fix the issue. **Exact steps for others to reproduce the error** - Open the example file - Move the sphere mesh (See the broken face nearest snapping)

projection_snap.blend

1.5 MiB

Julien Kaspar added the

labels 2023-11-07 19:32:18 +01:00

Iliya Katushenock added the

label 2023-11-07 19:42:49 +01:00

Germano Cavalcante added

and removed

labels 2023-11-07 22:13:02 +01:00

Germano Cavalcante self-assigned this 2023-11-07 22:13:13 +01:00

Germano Cavalcante commented

2023-11-07 22:25:25 +01:00

Member

I can confirm. The problem appears depending on the number of Face Nearest Steps and the order in which the objects are tested.

Simple fix coming...

Analyzing the code, I still wonder what "better results" this Face Nearest Steps option return. BLI_bvhtree_find_nearest seems to already get the closest point. Do we really need these steps?

I can confirm. The problem appears depending on the number of `Face Nearest Steps` and the order in which the objects are tested. Simple fix coming... --- Analyzing the code, I still wonder what "better results" this `Face Nearest Steps` option return. `BLI_bvhtree_find_nearest` seems to already get the closest point. Do we really need these steps? @gfxcoder ^

Germano Cavalcante referenced this issue from a commit

2023-11-07 22:31:29 +01:00

Fix #114596: Face Nearest with steps sometimes breaks

Germano Cavalcante closed this issue

2023-11-07 22:31:55 +01:00

Blender Bot added

and removed

labels 2023-11-07 22:31:57 +01:00

jon denning commented

2023-11-07 22:49:19 +01:00

Member

will take a look as soon as I can (later tonight?).

in general, the snapping steps is useful for breaking a large transformation into smaller ones, with snapping happening after each small step. this can have better results when the target surface is curved, especially when moving a bunch of verts with a falloff, as it helps in maintaining the relative distances. it's a feature that helps in specific situations. this specific context might not play well with the algorithm.

will take a look as soon as I can (later tonight?). in general, the snapping steps is useful for breaking a large transformation into smaller ones, with snapping happening after each small step. this can have better results when the target surface is curved, especially when moving a bunch of verts with a falloff, as it helps in maintaining the relative distances. it's a feature that helps in specific situations. this specific context might not play well with the algorithm.

Julien Kaspar commented

2023-11-09 12:16:17 +01:00

Author

Member

The issue doesn't seem to be fixed in all cases. I can still reproduce this bug in other files. I'll try to get another simplified example file.

The issue doesn't seem to be fixed in all cases. I can still reproduce this bug in other files. I'll try to get another simplified example file.

Julien Kaspar commented

2023-11-21 12:58:54 +01:00

Author

Member

I managed to put together a file to show the bug that still exists. It wasn't fixed.
It only fails to snap on certain linked objects. I couldn't reproduce it on a new file but simplified a work file of mine instead.

If any changes to the linked objects are done, the issue is gone. But since these are linked meshes that's not an option in my work files.

@gfxcoder can you take a look at this?

I managed to put together a file to show the bug that still exists. It wasn't fixed. It only fails to snap on certain linked objects. I couldn't reproduce it on a new file but simplified a work file of mine instead. If any changes to the linked objects are done, the issue is gone. But since these are linked meshes that's not an option in my work files. @gfxcoder can you take a look at this?

bug_example.zip

2.0 MiB

Julien Kaspar reopened this issue

2023-11-21 12:58:57 +01:00

Blender Bot added

and removed

labels 2023-11-21 12:58:58 +01:00

Julien Kaspar commented

2023-11-21 13:00:09 +01:00

Author

Member

@mano-wii Also not sure what the procedure is for reopening a bug.
Since this bug was never properly fixed I didn't think it was needed to make a new report.

@mano-wii Also not sure what the procedure is for reopening a bug. Since this bug was never properly fixed I didn't think it was needed to make a new report.

Iliya Katushenock added

and removed

labels 2023-11-21 13:14:45 +01:00

Germano Cavalcante referenced this issue from a commit

2023-11-21 17:37:47 +01:00

Fix #114596: snap to face nearest failing with transformed objects

Germano Cavalcante closed this issue

2023-11-21 17:37:48 +01:00

Blender Bot added

and removed

labels 2023-11-21 17:39:12 +01:00

Germano Cavalcante commented

2023-11-21 17:42:51 +01:00

Member

In fact there is an error with transformed objects (moved, scaled or rotated). Fixed now.

I also analyzed a little better how face steps work.
If I understand correctly, it causes the distance of the original movement to be projected as a path on the surface of the object.

In fact there is an error with transformed objects (moved, scaled or rotated). Fixed now. I also analyzed a little better how face steps work. If I understand correctly, it causes the distance of the original movement to be projected as a path on the surface of the object. ![image](/attachments/ee4ef646-f10b-491d-878a-ae0111c7549f)

Germano Cavalcante referenced this issue

2023-11-21 17:44:08 +01:00

4.0: Candidates for corrective releases #114706

jon denning commented

2023-11-21 17:54:14 +01:00

Member

let me know if I need to take a look at it. thanks for your work, @mano-wii

let me know if I need to take a look at it. thanks for your work, @mano-wii

Thomas Dinges referenced this issue from a commit

2023-11-27 17:48:23 +01:00

Fix #114596: snap to face nearest failing with transformed objects

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#114596

No description provided.