Smooth by Angle doesn't always work with sharpness (I also fixed it with a new node setup) #114722
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#114722
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
System Information
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3060/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 546.01
Blender Version
Broken: version: 4.1.0 Alpha, branch: main, commit date: 2023-11-04 05:53, hash:
b177f27e6f50Worked: (newest version of Blender that worked as expected)
Short description of error
Smooth by Angle doesn't always work with objects using sharpness on edges/vertices unless you set your entire model to smooth, which in turn loses all the sharpness data on the model, thus defeating the purpose of using this modifier in the first place.
Exact steps for others to reproduce the error
Download the .blend-file and try my node solution vs the current one in 4.1. The node changes allow the modifier to work on meshes that are shaded flat with sharpness data without having to shade the entire mesh as smooth and then adding the sharpness back.
Broken Smooth by Angle + Fixed Node Solution.blend
Here's the node setup in detail. I only added a Switch node with different Set Shade Smooth options depending on if Ignore Sharpness is on or off.
I also suggest making a node version of Shade Smooth/Flat that allows the user to save the sharpness data as an alternative to erasing it all like it does now. Should be possible with Geometry Tools.
I am not able to find certain line in manual, but that seems to me as expected behavior. Sharpness is used to calculate smoothed normals, so this should works with smoothing by angle.
https://docs.blender.org/manual/en/2.80/modeling/meshes/editing/edges.html#mark-sharp-and-clear-sharp
So do you agree then that Smooth by Angle should work on flat shaded models with sharpness data? I was having issues getting this modifier to work the way I expected it to without having to make these manual changes in the node system. Shade Auto-Smooth in 4.1 is deleting sharpness data as well, so I think it is extra important that the Smooth by Angle modifier works on any type of model with sharpness data by smoothing models that are marked as flat shaded while keeping sharp edges/vertices sharp.
This documentation is 2.8, while the report appears to concern 4.1?
https://docs.blender.org/manual/en/4.1/modeling/meshes/editing/edge/edge_data.html#mark-sharp-clear-sharp
I can confirm. Sharp edges were preserved in Legacy "auto-smooth". So new "smooth by angle" is also expected to work like that :)
cc @HooglyBoogly
So, has any of the devs been able to take a look at my issue yet? Have they tried my solution?
Sorry this dropped off my radar.
The problem seems to be that "Ignore Sharpness" also applies to edge sharpness, so there's no way to ignore face sharpness but use edge sharpness from the input mesh as an "override" to the sharpness from edge angles?
I hope I understood that right, because I find your node group a bit confusing. I'd hope there's a way to do this without using a switch node. Also it looks like in the "not ignore sharpness" case, only face sharpness is set by the modifier. That doesn't seem quite right?
I wonder if it's worth changing the UI a bit. For example, we could have two options "Face Sharpness" and "Edge Sharpness" or something like that, to control whether to use the two attributes from the input mesh. I'd imagine these would both be off by default, so the modifier would have a complete effect everywhere by default.