Outliner Tree is rebuilt every time you scrub the timeline #114828

New Issue

Closed

opened 2023-11-14 10:20:09 +01:00 by Christoph Lendenfeld · 5 comments

Christoph Lendenfeld commented

2023-11-14 10:20:09 +01:00

Member

System Information
Operating system: Linux Mint
Graphics card: RTX 3070

Blender Version
Broken: latest main
Worked: didn't check yet

Short description of error
When scrubbing the timeline on heavy scenes the update rate is significantly slower than when playing back.
After profiling the scene it turns out that the outliner tree is rebuilt on every frame when scrubbing.

Exact steps for others to reproduce the error
Based on the default startup or an attached .blend file (as simple as possible).

Open the attached file (it just has a bunch of instanced cubes)
scrub the timeline, then play back. Scrubbing is a lot slower

I ran the scene through a profiler to see what the exact issue is. That's how I found out that rebuilding the outliner tree is the difference/issue. That also means closing the outliner makes scrubbing faster.

Here's the flame graph for scrubbing the timeline

It may be, that rebuilding the tree is needed for some reason. But if possible we should really avoid doing it.

**System Information** Operating system: Linux Mint Graphics card: RTX 3070 **Blender Version** Broken: latest main Worked: didn't check yet **Short description of error** When scrubbing the timeline on heavy scenes the update rate is significantly slower than when playing back. After profiling the scene it turns out that the outliner tree is rebuilt on every frame when scrubbing. **Exact steps for others to reproduce the error** Based on the default startup or an attached .blend file (as simple as possible). * Open the attached file (it just has a bunch of instanced cubes) * scrub the timeline, then play back. Scrubbing is a lot slower I ran the scene through a profiler to see what the exact issue is. That's how I found out that rebuilding the outliner tree is the difference/issue. That also means closing the outliner makes scrubbing faster. Here's the flame graph for scrubbing the timeline ![image](/attachments/cd543c32-551e-4483-b8fc-8e7e0ae962fd) It may be, that rebuilding the tree is needed for some reason. But if possible we should really avoid doing it.

lots_of_objects.blend

17 MiB

274 KiB

Christoph Lendenfeld added the

Animation & Rigging

labels 2023-11-14 10:20:10 +01:00

Pratik Borhade commented

2023-11-14 11:27:30 +01:00

Member

Can confirm, I'll check

Can confirm, I'll check

Pratik Borhade added

and removed

labels 2023-11-14 11:27:45 +01:00

Pratik Borhade commented

2023-11-14 11:51:16 +01:00

Member

It seems this is due to the ND_FRAME notifier in change_frame_apply and change_frame_modal
Simple fix would be to remove ND_FRAME to avoid redraw in outliner_main_region_listener:
I think the purpose of redraw is to update outliner when object visibility is animated (cc @JulianEisel ).

diff --git a/source/blender/editors/space_outliner/space_outliner.cc b/source/blender/editors/space_outliner/space_outliner.cc
index c2a05ede58a..f26b679a44d 100644
--- a/source/blender/editors/space_outliner/space_outliner.cc
+++ b/source/blender/editors/space_outliner/space_outliner.cc
@@ -127,7 +127,6 @@ static void outliner_main_region_listener(const wmRegionListenerParams *params)
         case ND_OB_RENDER:
         case ND_MODE:
         case ND_KEYINGSET:
-        case ND_FRAME:
         case ND_RENDER_OPTIONS:
         case ND_SEQUENCER:
         case ND_LAYER_CONTENT:

It seems this is due to the `ND_FRAME` notifier in `change_frame_apply` and `change_frame_modal` Simple fix would be to remove `ND_FRAME` to avoid redraw in `outliner_main_region_listener`: I think the purpose of redraw is to update outliner when object visibility is animated (cc @JulianEisel ). ``` diff --git a/source/blender/editors/space_outliner/space_outliner.cc b/source/blender/editors/space_outliner/space_outliner.cc index c2a05ede58a..f26b679a44d 100644 --- a/source/blender/editors/space_outliner/space_outliner.cc +++ b/source/blender/editors/space_outliner/space_outliner.cc @@ -127,7 +127,6 @@ static void outliner_main_region_listener(const wmRegionListenerParams *params) case ND_OB_RENDER: case ND_MODE: case ND_KEYINGSET: - case ND_FRAME: case ND_RENDER_OPTIONS: case ND_SEQUENCER: case ND_LAYER_CONTENT: ```

Christoph Lendenfeld commented

2023-11-14 12:39:44 +01:00

Author

Member

redrawing the outliner is fine, and we need that if e.g. the visibility is animated.
I am just wondering if we need to rebuild the whole tree for that

redrawing the outliner is fine, and we need that if e.g. the visibility is animated. I am just wondering if we need to rebuild the whole tree for that

Julian Eisel commented

2023-11-14 13:02:36 +01:00

Member

Redrawing the outliner on frame changes is definitely needed, not just for visibility changes, we also show animated properties in the Data API and library overrides display mode for example.

If there is no case where the tree actually changes on frame changes (like items added/removed or reordered), we can tag the region with ED_region_tag_redraw_no_rebuild() instead. Then the region would be redrawn but the tree not rebuilt.

We used to rebuild the tree a lot, nowadays we try to be more careful since it can have a significant performance impact.

Redrawing the outliner on frame changes is definitely needed, not just for visibility changes, we also show animated properties in the Data API and library overrides display mode for example. If there is no case where the tree actually changes on frame changes (like items added/removed or reordered), we can tag the region with `ED_region_tag_redraw_no_rebuild()` instead. Then the region would be redrawn but the tree not rebuilt. We used to rebuild the tree a lot, nowadays we try to be more careful since it can have a significant performance impact.

Christoph Lendenfeld commented

2023-11-14 14:22:50 +01:00

Author

Member

thanks, that makes sense. Off the top of my head I can't think of anything that would modify the scene during scrubbing but not playback, but I'll do some digging.

thanks, that makes sense. Off the top of my head I can't think of anything that would modify the scene during scrubbing but not playback, but I'll do some digging.

Christoph Lendenfeld referenced a pull request that will close this issue

2023-11-14 15:39:24 +01:00

Fix #114828: Don't rebuild outliner tree when frame scrubbing #114845

Christoph Lendenfeld self-assigned this 2023-11-14 15:50:13 +01:00

sanek122005 referenced this issue

2023-12-03 15:08:19 +01:00

UV Editor is slowed down by an open Outliner, when scene is complex, but edited mesh is very simple #115662

Christoph Lendenfeld referenced this issue from a commit

2023-12-05 11:04:35 +01:00

Fix #114828: Don't rebuild outliner tree when frame scrubbing

Christoph Lendenfeld closed this issue

2023-12-05 11:04:36 +01:00

Blender Bot added

and removed

labels 2023-12-05 11:04:37 +01:00

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#114828

No description provided.