Principled shader clearcoat roughness inconsistent change from 0.0265 to 0.0266 (Cycles only) #114940

Open
opened 2023-11-15 22:56:58 +01:00 by Tomás Cejas · 2 comments

Windows-10-10.0.19041-SP0 64 Bits
NVIDIA GeForce GTX 1050/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 546.01

Broken: version: 4.0.0, branch: blender-v4.0-release, commit date: 2023-11-13 17:26, hash: 878f71061b8e.
Version 4.1 alpha.
3.X versions presented a similar issue (#53038).

Worked: unknown

Below a clearcoat roughness value of 0.0266, it seemingly drops to zero, impeding the making of very (but not perfectly) glossy clearcoats. In EEVEE this issue is not present, the clearcoat roughness smoothly transitions to zero. The issue is similar to #53038.

The following image ilustrates the problem, indicating clearcoat roughness values on a principled shader. Base roughness is set to 0 to better visualize the clearcoat reflections.
image

To visualize the problem, simply observe how the glossy reflection of a light changes as the clearcoat roughness value or a principled BSDF shader approaches 0. The file used to make the image is provided.

Windows-10-10.0.19041-SP0 64 Bits NVIDIA GeForce GTX 1050/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 546.01 Broken: version: 4.0.0, branch: blender-v4.0-release, commit date: 2023-11-13 17:26, hash: `878f71061b8e`. Version 4.1 alpha. 3.X versions presented a similar issue (https://projects.blender.org/blender/blender/issues/53038). Worked: unknown Below a clearcoat roughness value of 0.0266, it seemingly drops to zero, **impeding the making of very (but not perfectly) glossy clearcoats**. In EEVEE this issue is not present, the clearcoat roughness smoothly transitions to zero. The issue is similar to https://projects.blender.org/blender/blender/issues/53038. The following image ilustrates the problem, indicating clearcoat roughness values on a principled shader. Base roughness is set to 0 to better visualize the clearcoat reflections. ![image](/attachments/e4a13130-36d3-4603-8d1d-011af61b6b84) To visualize the problem, simply observe how the glossy reflection of a light changes as the clearcoat roughness value or a principled BSDF shader approaches 0. The file used to make the image is provided.
Tomás Cejas added the
Priority
Normal
Type
Report
Status
Needs Triage
labels 2023-11-15 22:56:58 +01:00
Iliya Katushenock added the
Interest
Render & Cycles
label 2023-11-16 19:21:02 +01:00
Richard Antalik added
Module
Render & Cycles
Status
Confirmed
and removed
Status
Needs Triage
labels 2023-12-07 19:07:23 +01:00

I think I have seen very similar recent report, but it could be concerning different property.

I think I have seen very similar recent report, but it could be concerning different property.
Member

This is because we have a threshold where we decide the surface is effectively smooth. Currently the value is 5e-7, which corresponds to 0.02659 in the UI. Apparently this value is not small enough.
According to my experiment 1e-10 is a good value so that the switching is not obvious for bsdf_eval(), I can change that easily, however this value causes numerical issues for bsdf_sample(). The solution is to return eval / pdf instead of eval in bsdf_sample(). Seems that a lot of places need to be changed accordingly, but we should do that anyway. I will find some time to address this.
Also, this is not only a problem for coat, but all closures using microfacet distribution.

This is because we have a threshold where we decide the surface is effectively smooth. Currently the value is `5e-7`, which corresponds to `0.02659` in the UI. Apparently this value is not small enough. According to my experiment `1e-10` is a good value so that the switching is not obvious for `bsdf_eval()`, I can change that easily, however this value causes numerical issues for `bsdf_sample()`. The solution is to return `eval / pdf` instead of `eval` in `bsdf_sample()`. Seems that a lot of places need to be changed accordingly, but we should do that anyway. I will find some time to address this. Also, this is not only a problem for coat, but all closures using microfacet distribution.
Weizhen Huang self-assigned this 2024-02-19 20:33:21 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#114940
No description provided.