ID property's id_type enum is missing the SCREEN type #115151

New Issue

Closed

opened 2023-11-19 22:01:37 +01:00 by dima glib · 4 comments

dima glib commented

2023-11-19 22:01:37 +01:00

Member

Blender Version
Broken: 4.0, 4.1 alpha
Worked: never

Short description of error
In Blender 4.0, UI support for IDBlock-referencing custom properties was introduced. In the corresponding popup dialog, there is the "ID Type" selector that determines the specific IDBlock type which can be used as the property's value. The corresponding enum seems to include options for all IDBlock types (even for Grease Pencil v3, which is not shipped in Blender 4.0), except for the Screen type.
However, Screen objects can still be assigned to custom properties via scripting, and trying to open the pop-up for such a property results in a crash.

Exact steps for others to reproduce the error

Open attached .blend file (the object "Cube" has a custom property of IDBlock of type Screen set with C.object["s"] = D.screens[0])
Try edit the custom property through the UI

**Blender Version** Broken: 4.0, 4.1 alpha Worked: never **Short description of error** In Blender 4.0, UI support for IDBlock-referencing custom properties was introduced. In the corresponding popup dialog, there is the "ID Type" selector that determines the specific IDBlock type which can be used as the property's value. The corresponding enum seems to include options for all IDBlock types (even for Grease Pencil v3, which is not shipped in Blender 4.0), except for the Screen type. However, Screen objects can still be assigned to custom properties via scripting, and trying to open the pop-up for such a property results in a crash. ![image](/attachments/3d3e0ff7-60c2-423e-981d-eb3361a16569) **Exact steps for others to reproduce the error** - Open attached .blend file (the object "Cube" has a custom property of IDBlock of type Screen set with `C.object["s"] = D.screens[0]`) - Try edit the custom property through the UI

114 KiB

id_type_bug_screen.blend

904 KiB

dima glib added the

labels 2023-11-19 22:01:38 +01:00

Iliya Katushenock added the

label 2023-11-20 11:52:17 +01:00

Germano Cavalcante commented

2023-11-20 23:21:00 +01:00

Member

Thank you for the report, @dairin0d.

I can notice that not all IDs were put into the enum. (Whether it is intentional or an accident, I still need to check).
https://projects.blender.org/blender/blender/src/branch/main/source/blender/makesrna/intern/rna_ID.cc#L35-L75

But the crash really isn't ideal. So confirming the bug.

Thank you for the report, @dairin0d. I can notice that not all IDs were put into the enum. (Whether it is intentional or an accident, I still need to check). https://projects.blender.org/blender/blender/src/branch/main/source/blender/makesrna/intern/rna_ID.cc#L35-L75 But the crash really isn't ideal. So confirming the bug. @mont29 ^

Germano Cavalcante added

and removed

labels 2023-11-20 23:21:18 +01:00

Bastien Montagne commented

2023-11-21 14:16:38 +01:00

Owner

@mano-wii DId you find where that omission in rna_enum_id_type_items comes from?

In any case, this is a good test-case for forward-compatibility, when we introduce new ID types in the future ;)

@mano-wii DId you find where that omission in `rna_enum_id_type_items` comes from? In any case, this is a good test-case for forward-compatibility, when we introduce new ID types in the future ;)

Germano Cavalcante commented

2023-11-21 16:28:54 +01:00

Member

It was removed in 2e635b6500
I noticed that the screen icon started to be used for the workspace ID.

@brecht, do you remember why ID Screen was removed from the rna enum?

It was removed in 2e635b6500 I noticed that the screen icon started to be used for the workspace ID. @brecht, do you remember why ID Screen was removed from the rna enum?

Bastien Montagne commented

2023-11-21 18:17:44 +01:00

Owner

Talked with Brecht, this was likely an 'optimistic' change during 2.8 dev when Screen id type was expected to be fully removed and replaced by workspaces.

Will add it back for the time being, we should not have ID types accessible to users/scripters that are not listed in the IDTypes enum.

Will also add some new id_type member to RNA ID struct, which returns the ID identifier as listed in rna_enum_id_type_items, and some python testing to ensure there is no ID exposed in bpy.data that cannot be properly 'typed' from rna_enum_id_type_items enum.

Talked with Brecht, this was likely an 'optimistic' change during 2.8 dev when `Screen` id type was expected to be fully removed and replaced by workspaces. Will add it back for the time being, we should not have ID types accessible to users/scripters that are not listed in the IDTypes enum. Will also add some new `id_type` member to RNA ID struct, which returns the ID identifier as listed in `rna_enum_id_type_items`, and some python testing to ensure there is no ID exposed in `bpy.data` that cannot be properly 'typed' from `rna_enum_id_type_items` enum.

Bastien Montagne referenced this issue from a commit

2023-11-21 18:54:39 +01:00

Fix #115151, step one: Fallback to `ID_OB` in case of defined unknown ID type.

Bastien Montagne closed this issue

2023-11-21 18:54:40 +01:00

Blender Bot added

and removed

labels 2023-11-21 18:54:42 +01:00

Bastien Montagne referenced this issue from a commit

2023-11-21 18:54:42 +01:00

Fix #115151: ID property's id_type enum is missing the SCREEN type.

Bastien Montagne referenced this issue from a commit

2023-11-21 18:54:42 +01:00

RNA: Expose ID type identifier in ID structs, add coherence test.

Bastien Montagne referenced this issue

2023-11-21 18:57:25 +01:00

4.0: Candidates for corrective releases #114706

Thomas Dinges referenced this issue from a commit

2023-11-27 18:00:01 +01:00

Fix #115151, step one: Fallback to `ID_OB` in case of defined unknown ID type.

Thomas Dinges referenced this issue from a commit

2023-11-27 18:00:02 +01:00

Fix #115151: ID property's id_type enum is missing the SCREEN type.

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#115151

No description provided.