Missing node group update with linked + overridden node tree data blocks #115264

Open
opened 2023-11-22 12:13:51 +01:00 by Lukas Tönne · 2 comments
Member

System Information
Operating system:
Graphics card:

Blender Version
Broken: 4.1.0 alpha (5118f6f5)
Worked:

Short description of error
Adding override to a linked node group can leave group instances in a "desynced" state.

Exact steps for others to reproduce the error

  1. Make a library with a simple default geometry nodes modifier.
    Screenshot_20231122_120659
  2. Link the node tree in another file and make a group node with it.
    Screenshot_20231122_120752
  3. Add a library override on the group node.
    image
  4. Open the node group and remove the "Geometry" input. The socket on the node is removed as expected.
    Screenshot_20231122_121013
  5. Reload the file. Now the node group is reset to the library state (correct), but the group node is still missing the input socket.
    image
**System Information** Operating system: Graphics card: **Blender Version** Broken: 4.1.0 alpha (5118f6f5) Worked: **Short description of error** Adding override to a linked node group can leave group instances in a "desynced" state. **Exact steps for others to reproduce the error** 1. Make a library with a simple default geometry nodes modifier. ![Screenshot_20231122_120659](/attachments/e11c036b-13ee-4099-bf6f-27eda8c7e8b0) 2. Link the node tree in another file and make a group node with it. ![Screenshot_20231122_120752](/attachments/b6c8f4ca-b4ca-4ded-8287-fb6a08cc9094) 3. Add a library override on the group node. ![image](/attachments/3d01a1a9-873c-4879-bcd3-e987ee9c56d4) 4. Open the node group and remove the "Geometry" input. The socket on the node is removed as expected. ![Screenshot_20231122_121013](/attachments/e9ee9cd6-7669-41cb-bff9-23e523b6d9a4) 5. Reload the file. Now the node group is reset to the library state (correct), but the group node is still missing the input socket. ![image](/attachments/31d7550a-ecd3-44a3-96e0-8ec890bc8f44)
Lukas Tönne added the
Priority
Normal
Type
Report
Status
Needs Triage
labels 2023-11-22 12:13:51 +01:00
Lukas Tönne added this to the Nodes & Physics project 2023-11-22 12:14:09 +01:00
Author
Member

Forcing a node update (e.g. by muting the group node) fixes the sockets, so it's probably missing an update data after loading the linked node tree.

Forcing a node update (e.g. by muting the group node) fixes the sockets, so it's probably missing an update data after loading the linked node tree.
Member

Seems like the bug here is that we even allow changing the node group interface in the library override data-block if that change is not saved, or am I missing something?

Seems like the bug here is that we even allow changing the node group interface in the library override data-block if that change is not saved, or am I missing something?
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#115264
No description provided.