Graph editor selects keyframe on click down instead of click up and makes curve selection unexpectedly clunky #115448

New Issue

Loïc DAUTRY · 2023-11-26T18:27:35+01:00

Loïc DAUTRY commented

2023-11-26 18:27:35 +01:00

System Information
Operating system: Windows-10-10.0.22621-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 4090/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 531.79

Blender Version
Broken: version: 4.0.0, branch: blender-v4.0-release, commit date: 2023-11-13 17:26, hash: 878f71061b8e
Worked: seems to have always been the case?

Short description of error
Unlike in the 3D viewport, where selection happens on releasing the mouse button, selection in the graph happens on pressing down the button.

The problem is, if your goal is to select the curve via box selection but you click near a keyframe, the keyframe will be selected instead and start moving when you move your mouse thinking to do a box select.
The user can just go select from further away, but sometimes you have multiple curves and keys in a tight space so you really need to "get out of the current space", and either way it's a minor inconvenience that does get you out of your flow.

You can test it on this mock scene:
untitled.blend

**System Information** Operating system: Windows-10-10.0.22621-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 4090/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 531.79 **Blender Version** Broken: version: 4.0.0, branch: blender-v4.0-release, commit date: 2023-11-13 17:26, hash: `878f71061b8e` Worked: seems to have always been the case? **Short description of error** Unlike in the 3D viewport, where selection happens on releasing the mouse button, selection in the graph happens on pressing down the button. The problem is, if your goal is to select the curve via box selection but you click near a keyframe, the keyframe will be selected instead and start moving when you move your mouse thinking to do a box select. The user can just go select from further away, but sometimes you have multiple curves and keys in a tight space so you really need to "get out of the current space", and either way it's a minor inconvenience that does get you out of your flow. You can test it on this mock scene: [untitled.blend](/attachments/01cc9c55-47e0-4738-a3f2-8e0f828df4eb)

untitled.blend

108 KiB

Loïc DAUTRY added the

labels 2023-11-26 18:27:36 +01:00

Pratik Borhade commented

2023-11-27 05:27:18 +01:00

Hi, thanks for the report. I can confirm. This is true for other animation editors as well so I would guess this as intentional workflow.
Forwarding to A&R module devs for further decision.

Hi, thanks for the report. I can confirm. This is true for other animation editors as well so I would guess this as intentional workflow. Forwarding to A&R module devs for further decision.

❤️ 1

Pratik Borhade added

Module

Animation & Rigging

Status

Needs Info from Developers

and removed

Status

Needs Triage

labels 2023-11-27 05:27:38 +01:00

Pratik Borhade commented

2023-11-27 05:42:07 +01:00

Following diff will allow to invoke box select instead of select and tweak behavior for graph editor. This might be good for consistency but I don't know how animators wanted this.
cc @ChrisLend

diff --git a/scripts/presets/keyconfig/keymap_data/blender_default.py b/scripts/presets/keyconfig/keymap_data/blender_default.py
index 8271499c6d9..046c144a5ed 100644
--- a/scripts/presets/keyconfig/keymap_data/blender_default.py
+++ b/scripts/presets/keyconfig/keymap_data/blender_default.py
@@ -1830,7 +1830,7 @@ def km_graph_editor(params):
     items.extend([
         ("wm.context_toggle", {"type": 'H', "value": 'PRESS', "ctrl": True},
          {"properties": [("data_path", 'space_data.show_handles')]}),
-        ("graph.clickselect", {"type": params.select_mouse, "value": 'PRESS'},
+        ("graph.clickselect", {"type": params.select_mouse, "value": 'RELEASE'},
          {"properties": [("deselect_all", not params.legacy)]}),
         ("graph.clickselect", {"type": params.select_mouse, "value": 'PRESS', "alt": True},
          {"properties": [("column", True)]}),
@@ -1857,7 +1857,7 @@ def km_graph_editor(params):
         ("graph.select_box", {"type": 'B', "value": 'PRESS', "alt": True},
          {"properties": [("axis_range", True)]}),
         ("graph.select_box", {"type": params.select_mouse, "value": 'CLICK_DRAG'},
-         {"properties": [("tweak", True), ("mode", 'SET')]}),
+         {"properties": [("tweak", False), ("mode", 'SET')]}),
         ("graph.select_box", {"type": params.select_mouse, "value": 'CLICK_DRAG', "shift": True},
          {"properties": [("tweak", True), ("mode", 'ADD')]}),
         ("graph.select_box", {"type": params.select_mouse, "value": 'CLICK_DRAG', "ctrl": True},

@L0Lock , you can tweak the keymap yourself to achieve the behavior you wanted (Edit > preferences > keymap).

Following diff will allow to invoke box select instead of `select and tweak` behavior for graph editor. This might be good for consistency but I don't know how animators wanted this. cc @ChrisLend ``` diff --git a/scripts/presets/keyconfig/keymap_data/blender_default.py b/scripts/presets/keyconfig/keymap_data/blender_default.py index 8271499c6d9..046c144a5ed 100644 --- a/scripts/presets/keyconfig/keymap_data/blender_default.py +++ b/scripts/presets/keyconfig/keymap_data/blender_default.py @@ -1830,7 +1830,7 @@ def km_graph_editor(params): items.extend([ ("wm.context_toggle", {"type": 'H', "value": 'PRESS', "ctrl": True}, {"properties": [("data_path", 'space_data.show_handles')]}), - ("graph.clickselect", {"type": params.select_mouse, "value": 'PRESS'}, + ("graph.clickselect", {"type": params.select_mouse, "value": 'RELEASE'}, {"properties": [("deselect_all", not params.legacy)]}), ("graph.clickselect", {"type": params.select_mouse, "value": 'PRESS', "alt": True}, {"properties": [("column", True)]}), @@ -1857,7 +1857,7 @@ def km_graph_editor(params): ("graph.select_box", {"type": 'B', "value": 'PRESS', "alt": True}, {"properties": [("axis_range", True)]}), ("graph.select_box", {"type": params.select_mouse, "value": 'CLICK_DRAG'}, - {"properties": [("tweak", True), ("mode", 'SET')]}), + {"properties": [("tweak", False), ("mode", 'SET')]}), ("graph.select_box", {"type": params.select_mouse, "value": 'CLICK_DRAG', "shift": True}, {"properties": [("tweak", True), ("mode", 'ADD')]}), ("graph.select_box", {"type": params.select_mouse, "value": 'CLICK_DRAG', "ctrl": True}, ``` @L0Lock , you can tweak the keymap yourself to achieve the behavior you wanted (`Edit > preferences > keymap`).

🚀 1

Christoph Lendenfeld commented

2023-11-28 12:32:23 +01:00

that would mean that you can no longer drag keys around. I don't think we should be changing that behavior.
But I'll put it on the meeting agenda

that would mean that you can no longer drag keys around. I don't think we should be changing that behavior. But I'll put it on the meeting agenda

👍 1

Pratik Borhade commented

2023-11-28 14:39:18 +01:00

Thanks @ChrisLend . Yes, this will break the "tweak" thing :)

Christoph Lendenfeld added

and removed

Needs Info from Developers

labels 2023-11-30 19:00:45 +01:00

Christoph Lendenfeld commented

2023-11-30 19:02:47 +01:00

So this was discussed in the recent A&R meeting and we decided to put this down as a known issue.
Some people rely on that behavior, so we can't just change it.
The proper way to do it (which would be consistent with the rest of blender) is to have a toolbar in the animation editors so you can choose the tweak tool or the box select tool.

So this was discussed in the recent [A&R](https://devtalk.blender.org/t/2023-11-30-animation-rigging-module-meeting/32323#patch-review-decision-time-4) meeting and we decided to put this down as a known issue. Some people rely on that behavior, so we can't just change it. The proper way to do it (which would be consistent with the rest of blender) is to have a toolbar in the animation editors so you can choose the tweak tool or the box select tool.

Sybren A. Stüvel commented

2024-02-05 12:07:00 +01:00

Unlike in the 3D viewport, where selection happens on releasing the mouse button

I just wanted to provide some historical context here. Blender has always responded on mouse-down as much as possible, as that makes the application feel more responsive. Selection in the 3D Viewport was also on mouse-down. This only changed when introducing left-click select (LCS); with right-click select it's still immediately selecting on mouse-down. LCS has to distinguish between box-select and click-select, which can only be done by inspecting the distance traveled since the mouse-down event, and thus selection can only happen on mouse-up.

> Unlike in the 3D viewport, where selection happens on releasing the mouse button I just wanted to provide some historical context here. Blender has always responded on mouse-down as much as possible, as that makes the application feel more responsive. Selection in the 3D Viewport was also on mouse-down. This only changed when introducing left-click select (LCS); with right-click select it's still immediately selecting on mouse-down. LCS has to distinguish between box-select and click-select, which can only be done by inspecting the distance traveled since the mouse-down event, and thus selection can only happen on mouse-up.

👍 1

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Graph editor selects keyframe on click down instead of click up and makes curve selection unexpectedly clunky #115448