Regression: Poly Build does not update snapped geometry #115510
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#115510
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
System Information
Operating system: Windows 10
Blender Version
Broken: 4.0.1, 4.1.0 Alfa (2023-11-28)
Worked: 3.6.5
Caused by
91b27ab637
Short description of error
Poly Build Tool not working properly after move vertexes.
Exact steps for others to reproduce the error
Thank you for the report, @gtitaev.
I can confirm the issue. It seems to be a regression.
I will try to find the commit that has introduced the issue.
Caused by
91b27ab637
(Refactor: Simplify mesh edit mode modifier evaluation)Some coordinate update seems to be missing in source/blender/editors/space_view3d/view3d_gizmo_preselect_type.cc
@HooglyBoogly ^
Bug in Poly Build Tool in Blender 4.xto Regression: Poly Build does not update snapped geometryI looked into this for a while and didn't find the problem yet.
Also, I can only seems to reproduce the issue until I add some geometry with the tool, then it doesn't happen anymore.
@HooglyBoogly, it looks like that commit only revealed the previous error-prone code.
Apparently, both the drawing and the selection are using the wrong Mesh to access the coordinates.
I tested this change and it seems to work. But maybe we don't even need to use
DEG_get_evaluated_object
here.Huh, nice! I tried using evaluated coordinates in more places but I didn't get the chance to check if they were correct yet.
A combination of
DEG_get_evaluated_object
andBKE_object_get_evaluated_mesh
sounds nice to me, to avoid relying on theObject::data
pointer. If you want to commit that, go ahead, otherwise I'll take a look a bit later.