Animation Editors - Channel Context Menu mis-labeled. #115581

Closed
opened 2023-11-29 17:59:37 +01:00 by Andres Stephens · 13 comments
Contributor

System Information
Operating system: Windows-10-10.0.22635-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 4090/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 546.01

Blender Version
Broken: version: 4.1.0 Alpha, branch: Unknown, commit date: Unknown Unknown, hash: Unknown
Worked: (newest version of Blender that worked as expected)

Short description of error
Channel context menu has conditional operators but label remains the same in Timeline and Dopesheet and Graph editor. This makes a UX that you're calling the wrong channel context menu in the wrong editor though it's the right one.

Exact steps for others to reproduce the error

  1. Switch to Animation workspace
  2. Switch Dopesheet to Graph Editor
  3. Right click on channels area
  4. Notice that it's the Dopesheet Channel Context Menu - but in the wrong editor.

Fix:

Name the context menu it "Channel" for all editors.

**System Information** Operating system: Windows-10-10.0.22635-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 4090/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 546.01 **Blender Version** Broken: version: 4.1.0 Alpha, branch: Unknown, commit date: Unknown Unknown, hash: `Unknown` Worked: (newest version of Blender that worked as expected) **Short description of error** Channel context menu has conditional operators but label remains the same in Timeline and Dopesheet and Graph editor. This makes a UX that you're calling the wrong channel context menu in the wrong editor though it's the right one. **Exact steps for others to reproduce the error** 1. Switch to Animation workspace 2. Switch Dopesheet to Graph Editor 3. Right click on channels area 4. Notice that it's the Dopesheet Channel Context Menu - but in the wrong editor. # Fix: Name the context menu it "Channel" for all editors.
Andres Stephens added the
Priority
Normal
Type
Report
Status
Needs Triage
labels 2023-11-29 17:59:38 +01:00
Author
Contributor

image

New label on Line 736 in space_dopesheet.py would clarify that this is a "Channel" context menu.

![image](/attachments/afe9681a-2a5c-48bc-8d94-e1515b8a9d35) New label on Line 736 in space_dopesheet.py would clarify that this is a "Channel" context menu.
Author
Contributor

I could commit to do this, but still trying to understand how to make the SSH security system to work.... might need a day to try make it work.

I could commit to do this, but still trying to understand how to make the SSH security system to work.... might need a day to try make it work.
Member

New label on Line 736 in space_dopesheet.py would clarify that this is a "Channel" context menu.

Hi, thanks for the report, Make sense. I'll assign this to you (edit: unable to find your name in list).

> New label on Line 736 in space_dopesheet.py would clarify that this is a "Channel" context menu. Hi, thanks for the report, Make sense. I'll assign this to you (edit: unable to find your name in list).

@AndresStephens It took me like eight friggin' hours. One key note is that if you're in Windows, you need to commit the Gitea key verification with the ssh-keygen in Git Bash or Windows Subsystem for Linux. It returns different values than the Windows native ssh-keygen, and Gitea developers don't seem to mind 🙄.

@AndresStephens It took me like eight friggin' hours. One key note is that if you're in Windows, you need to commit the Gitea key verification with the ssh-keygen in Git Bash or Windows Subsystem for Linux. It returns different values than the Windows native ssh-keygen, and Gitea developers don't seem to mind 🙄.
Author
Contributor

Still haven't had luck with the system - documentation is assuming a lot with the system.

Still haven't had luck with the system - documentation is assuming a lot with the system.

@AndresStephens Where are you stuck; are you getting the username/password popup trying to auth on a push?

@AndresStephens Where are you stuck; are you getting the username/password popup trying to auth on a push?
Author
Contributor

image

Getting a "Could not read from remote repository" permission denied (public key)

  1. Generated keygen in Git Bash
  2. Created two files in the repository
  3. Added and verified the SSH key on the projects.blender.org website, it's green.
  4. Copied the 2 new key files to /c/Users/USER/.ssh/id_rsa
  5. Made Update, all good
  6. Tried to pull, hit a permission denied
![image](/attachments/f2d816b2-f9e1-4225-ab5f-366111a514ae) Getting a "Could not read from remote repository" permission denied (public key) 1. Generated keygen in Git Bash 2. Created two files in the repository 3. Added and verified the SSH key on the projects.blender.org website, it's green. 4. Copied the 2 new key files to `/c/Users/USER/.ssh/id_rsa` 5. Made Update, all good 6. Tried to pull, hit a permission denied
Author
Contributor

image

Seems the server address from documentation is a bit off?

![image](/attachments/911c3d2c-dc2a-4f34-aacf-8436287f9c11) Seems the server address from documentation is a bit off?

@AndresStephens "Is a directory" looks super suspicious to me. https://duckduckgo.com/?q=%22load+key%22+%22is+a+directory maybe? File access rights? Hammer the first half dozen results there.

@AndresStephens "Is a directory" looks super suspicious to me. https://duckduckgo.com/?q=%22load+key%22+%22is+a+directory maybe? File access rights? Hammer the first half dozen results there.
Author
Contributor

Looks like my SSH generation process is really not right. Personally I haven't done this with git before, Github authentication is very simple to setup - but this in command line and the sparse Blender documentation hasn't helped. I guess I might be generating my key incorrectly? Though it verifies with the server here, now the local ~/.ssh/id_rsa is.. not setup right I assume

Should I copy the 2 new files to these folders? Should they be renamed differently? How do I add them correctly? Which is which?

Looks like my SSH generation process is really not right. Personally I haven't done this with git before, Github authentication is very simple to setup - but this in command line and the sparse Blender documentation hasn't helped. I guess I might be generating my key incorrectly? Though it verifies with the server here, now the local `~/.ssh/id_rsa` is.. not setup right I assume Should I copy the 2 new files to these folders? Should they be renamed differently? How do I add them correctly? Which is which?
Author
Contributor

Ok, thanks to bing, got it. I was not setting it up correctly:

For future reference, you have to set permissions and move the keys you generated (in the repository, as in my case) and there you go. They also have to be named correctly.
image

Ok, thanks to bing, got it. I was not setting it up correctly: For future reference, you have to set permissions and move the keys you generated (in the repository, as in my case) and there you go. They also have to be named correctly. ![image](/attachments/6c8475ec-b037-4693-b84c-efc96aa4bd22)
7.6 KiB
Author
Contributor

image

Ah, looks like my user has no write access. Will pause here.

![image](/attachments/e2ed55ce-52a0-4a12-b311-acfcf4972285) Ah, looks like my user has no write access. Will pause here.
Member

Hi, we're going off-topic here. For further assistance, I would suggest to ask in #blender-coders

Ah, looks like my user has no write access. Will pause here.

What command you ran to create pull request (or to push your local changes to remote repo). Is it git push me branch-name
Have you setup repo links for origin and your fork?

Hi, we're going off-topic here. For further assistance, I would suggest to ask in [#blender-coders](https://blender.chat/channel/blender-coders) > Ah, looks like my user has no write access. Will pause here. What command you ran to create pull request (or to push your local changes to remote repo). Is it `git push me branch-name` Have you setup repo links for origin and your fork?
Blender Bot added
Status
Resolved
and removed
Status
Confirmed
labels 2023-12-14 09:09:44 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#115581
No description provided.