Regression: Problems with adding keys #115789

New Issue

Steffen Dünner · 2023-12-05T11:04:38+01:00

Steffen Dünner commented

2023-12-05 11:04:38 +01:00

System Information
Operating system: Linux-6.2.0-37-generic-x86_64-with-glibc2.35 64 Bits, X11 UI
Graphics card: NVIDIA GeForce RTX 2070 Super/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 535.129.03

Blender Version
Broken: version: 4.1.0 Alpha, branch: main, commit date: 2023-12-05 08:17, hash: 689040db2f77
Worked: 4.0.1 Release

Short description of error
Adding keys by pressing "i" is not behaving as before. Also adding keys in the Graph Editor is acting weird.

Exact steps for others to reproduce the error

Open Blender, add a cube (or use the default cube or any other animatable object) and select it
Press "i" to add a keyframe. What should happen:

Now there is no dialogue any more. A key is added to all SRT channels.
Now press "i" again. The same dialogue as above should appear again. But now this error message appears instead:

The other (very likely related) problem is in the Graph Editor:

Continue with the Blender session from above. The Graph Editor shows the added keys.
Now move the Timeline Cursor to another frame and press "i". This dialogue appears:
In 4.0.1 and before every single option worked. Now in 4.1 Alpha (main) the first 3 options don't do anything, no key is added. Only the last 2 ("Active Channel at Cursor" and "Selected Channel at Cursor") do actually add keys.

**System Information** Operating system: Linux-6.2.0-37-generic-x86_64-with-glibc2.35 64 Bits, X11 UI Graphics card: NVIDIA GeForce RTX 2070 Super/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 535.129.03 **Blender Version** Broken: version: 4.1.0 Alpha, branch: main, commit date: 2023-12-05 08:17, hash: `689040db2f77` Worked: 4.0.1 Release **Short description of error** Adding keys by pressing "i" is not behaving as before. Also adding keys in the Graph Editor is acting weird. **Exact steps for others to reproduce the error** - Open Blender, add a cube (or use the default cube or any other animatable object) and select it - Press "i" to add a keyframe. What should happen: ![image](/attachments/08c1ac22-ce58-4499-9842-33b32e45d7e0) Now there is no dialogue any more. A key is added to all SRT channels. - Now press "i" again. The same dialogue as above should appear again. But now this error message appears instead: ![image](/attachments/8d7f501f-3a91-4ad8-a09d-d3f86ef3d6c1) The other (very likely related) problem is in the Graph Editor: - Continue with the Blender session from above. The Graph Editor shows the added keys. - Now move the Timeline Cursor to another frame and press "i". This dialogue appears: ![image](/attachments/605e8058-ed1b-4a39-8b08-bff53e1f6d79) - In 4.0.1 and before every single option worked. Now in 4.1 Alpha (main) the first 3 options don't do anything, no key is added. Only the last 2 ("Active Channel at Cursor" and "Selected Channel at Cursor") do actually add keys.

image.png

27 KiB

image.png

48 KiB

image.png

10 KiB

Steffen Dünner added the

labels 2023-12-05 11:04:38 +01:00

Pratik Borhade commented

2023-12-05 11:07:44 +01:00

Hi, pasting my comment from #115436 (comment):
Behavior changed in a99e419b6e
Now pressing I key will add keyframes to selected keying set. If nothing is selected in keying set, userpref will be used to add keyframe.
Older panel can still be invoked by RMB/context menu > insert keyframe with keying set (when keying set is not selected)

Hi, pasting my comment from https://projects.blender.org/blender/blender/issues/115436#issuecomment-1077709: Behavior changed in a99e419b6e841d673a3542c372d5faec82c0d138 Now pressing `I` key will add keyframes to selected keying set. If nothing is selected in keying set, userpref will be used to add keyframe. Older panel can still be invoked by `RMB/context menu > insert keyframe with keying set` (when keying set is not selected)

Steffen Dünner commented

2023-12-05 11:08:58 +01:00

OMG, sorry. Didn't know this was a new feature. Sorry for the noise.

EDIT: OK, I can totally live with having to select a Keying Set before adding a key with the "i" key (or just add keys to the channels selected in the Preferences). Will take a while to get used to but OK.

But adding keys in the Graph Editor is still being very weird now, as all of what I wrote above is still true there. No matter what Keying Set I select, the 3 first options in the dialogue don't add any keys. Or did I miss something there as well?

OMG, sorry. Didn't know this was a new feature. Sorry for the noise. EDIT: OK, I can totally live with having to select a Keying Set before adding a key with the "i" key (or just add keys to the channels selected in the Preferences). Will take a while to get used to but OK. But adding keys in the Graph Editor is still being very weird now, as all of what I wrote above is still true there. No matter what Keying Set I select, the 3 first options in the dialogue don't add any keys. Or did I miss something there as well?

Pratik Borhade commented

2023-12-05 12:02:27 +01:00

No problem, closing 🙂

Pratik Borhade closed this issue

2023-12-05 12:02:31 +01:00

Blender Bot added

and removed

labels 2023-12-05 12:03:21 +01:00

Pratik Borhade commented

2023-12-05 12:04:41 +01:00

Oh, did not notice the post you edited, reopening (Also: I haven't checked the "graph editor" part yet)

Pratik Borhade reopened this issue

2023-12-05 12:04:45 +01:00

Blender Bot added

and removed

labels 2023-12-05 12:04:48 +01:00

Philipp Oeser commented

2023-12-05 12:06:53 +01:00

But adding keys in the Graph Editor is still being very weird now, as all of what I wrote above is still true there. No matter what Keying Set I select, the 3 first options in the dialogue don't add any keys. Or did I miss something there as well?

Cant replicate in current main

> But adding keys in the Graph Editor is still being very weird now, as all of what I wrote above is still true there. No matter what Keying Set I select, the 3 first options in the dialogue don't add any keys. Or did I miss something there as well? Cant replicate in current main

Steffen Dünner commented

2023-12-05 12:08:17 +01:00

Oh, did not notice the post you edited, reopening (Also: I haven't checked the "graph editor" part yet)

Thanks a lot. I guess the whole topic of keying etc. is under heavy construction right now.

> Oh, did not notice the post you edited, reopening (Also: I haven't checked the "graph editor" part yet) Thanks a lot. I guess the whole topic of keying etc. is under heavy construction right now.

Steffen Dünner commented

2023-12-05 12:16:35 +01:00

But adding keys in the Graph Editor is still being very weird now, as all of what I wrote above is still true there. No matter what Keying Set I select, the 3 first options in the dialogue don't add any keys. Or did I miss something there as well?

Cant replicate in current main

OK, I can add keys in the Graph Editor now after trying "--factory-startup" but not with my current user config. Trying to find the problem now.
When trying to add a key in the Graph Editor with my config I'm getting this:

Error: Failed to insert keys on F-Curve with path 'location[0]', ensure that it is not locked or sampled, and try removing F-Modifiers
Error: Failed to insert keys on F-Curve with path 'location[1]', ensure that it is not locked or sampled, and try removing F-Modifiers
Error: Failed to insert keys on F-Curve with path 'location[2]', ensure that it is not locked or sampled, and try removing F-Modifiers
Error: Failed to insert keys on F-Curve with path 'rotation_euler[0]', ensure that it is not locked or sampled, and try removing F-Modifiers
Error: Failed to insert keys on F-Curve with path 'rotation_euler[1]', ensure that it is not locked or sampled, and try removing F-Modifiers
Error: Failed to insert keys on F-Curve with path 'rotation_euler[2]', ensure that it is not locked or sampled, and try removing F-Modifiers
Error: Failed to insert keys on F-Curve with path 'scale[0]', ensure that it is not locked or sampled, and try removing F-Modifiers
Error: Failed to insert keys on F-Curve with path 'scale[1]', ensure that it is not locked or sampled, and try removing F-Modifiers
Error: Failed to insert keys on F-Curve with path 'scale[2]', ensure that it is not locked or sampled, and try removing F-Modifiers

The curves are not locked or sampled and there is no Fcurve-Modifier on them.

EDIT: I had "Only Insert Needed" active in my prefs. By toggling it to off, keying now works in the Graph Editor. Strange though because if I manually add keys, they should be "needed", right?

> > But adding keys in the Graph Editor is still being very weird now, as all of what I wrote above is still true there. No matter what Keying Set I select, the 3 first options in the dialogue don't add any keys. Or did I miss something there as well? > > Cant replicate in current main OK, I can add keys in the Graph Editor now after trying "--factory-startup" but not with my current user config. Trying to find the problem now. When trying to add a key in the Graph Editor with my config I'm getting this: ``` Error: Failed to insert keys on F-Curve with path 'location[0]', ensure that it is not locked or sampled, and try removing F-Modifiers Error: Failed to insert keys on F-Curve with path 'location[1]', ensure that it is not locked or sampled, and try removing F-Modifiers Error: Failed to insert keys on F-Curve with path 'location[2]', ensure that it is not locked or sampled, and try removing F-Modifiers Error: Failed to insert keys on F-Curve with path 'rotation_euler[0]', ensure that it is not locked or sampled, and try removing F-Modifiers Error: Failed to insert keys on F-Curve with path 'rotation_euler[1]', ensure that it is not locked or sampled, and try removing F-Modifiers Error: Failed to insert keys on F-Curve with path 'rotation_euler[2]', ensure that it is not locked or sampled, and try removing F-Modifiers Error: Failed to insert keys on F-Curve with path 'scale[0]', ensure that it is not locked or sampled, and try removing F-Modifiers Error: Failed to insert keys on F-Curve with path 'scale[1]', ensure that it is not locked or sampled, and try removing F-Modifiers Error: Failed to insert keys on F-Curve with path 'scale[2]', ensure that it is not locked or sampled, and try removing F-Modifiers ``` The curves are not locked or sampled and there is no Fcurve-Modifier on them. EDIT: I had "Only Insert Needed" active in my prefs. By toggling it to off, keying now works in the Graph Editor. Strange though because if I manually add keys, they should be "needed", right?

Richard Antalik referenced this issue

2023-12-05 21:16:09 +01:00

removing shortcuts in the f3 menu doesn't work #115816

Pratik Borhade commented

2023-12-06 06:02:55 +01:00

Yes, can confirm keyframes are not added with that preference

Pratik Borhade commented

2023-12-06 06:24:03 +01:00

The working of Only Insert Needed has been changed in 83287624bc
Current behavior is now expected as described in code comment and commit description: No need to insert a key if the same value is already the value of the FCurve at that point.
But this is failing silently without user knowing about it, also an undo step is created even after the operation is skipped.
cc @ChrisLend

The working of `Only Insert Needed` has been changed in 83287624bc5d4c1e9ee52c8e794e0bdc166b058a Current behavior is now expected as described in code comment and commit description: `No need to insert a key if the same value is already the value of the FCurve at that point.` But this is failing silently without user knowing about it, also an undo step is created even after the operation is skipped. cc @ChrisLend

Pratik Borhade added

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Regression: Problems with adding keys #115789