Light linking remove button unlinks object from actual collection #115869

New Issue

Closed

opened 2023-12-07 04:56:44 +01:00 by aomay · 3 comments

aomay commented

2023-12-07 04:56:44 +01:00

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3090/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 537.34

Blender Version
Broken: version: 4.0.2, branch: blender-v4.0-release, commit date: 2023-12-05 07:41, hash: 9be62e85b727
Worked: (newest version of Blender that worked as expected)

Short description of error
Puts the entire Collection into a light excluded state.

Then slowly start to eliminate unnecessary objects,

The object will be completely deleted.

Exact steps for others to reproduce the error
Will contain objects collection
Put in light link
Then delete the objects in the directory
The object will be deleted

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3090/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 537.34 **Blender Version** Broken: version: 4.0.2, branch: blender-v4.0-release, commit date: 2023-12-05 07:41, hash: `9be62e85b727` Worked: (newest version of Blender that worked as expected) **Short description of error** Puts the entire Collection into a light excluded state. Then slowly start to eliminate unnecessary objects, The object will be completely deleted. **Exact steps for others to reproduce the error** Will contain objects collection Put in light link Then delete the objects in the directory The object will be deleted

967 KiB

aomay added the

labels 2023-12-07 04:56:44 +01:00

Pratik Borhade commented

2023-12-07 08:10:13 +01:00

Member

Hi, thanks for the report. Can confirm. With current implementation, this looks expected as object is unlinked from the collection: https://projects.blender.org/blender/blender/src/branch/main/source/blender/blenkernel/intern/light_linking.cc#L421
@Sergey , is this intended behavior?

Hi, thanks for the report. Can confirm. With current implementation, this looks expected as object is unlinked from the collection: https://projects.blender.org/blender/blender/src/branch/main/source/blender/blenkernel/intern/light_linking.cc#L421 @Sergey , is this intended behavior?

Pratik Borhade added

Needs Info from Developers

Render & Cycles

and removed

labels 2023-12-07 08:10:33 +01:00

Pratik Borhade changed title from ~~light excluded Kill Obj~~ to Light linking remove button unlinks object from actual collection

2023-12-07 08:11:31 +01:00

Sergey Sharybin commented

2024-01-02 14:33:09 +01:00

Owner

It is expected behavior indeed. The light and shadow linking collections are regular collections. They might or might not be linked to the scene.

If you want light/shadow linking collection to have different content from what it is in the scene the collection needs to be made single user.

It is expected behavior indeed. The light and shadow linking collections are regular collections. They might or might not be linked to the scene. If you want light/shadow linking collection to have different content from what it is in the scene the collection needs to be made single user.

Sergey Sharybin closed this issue

2024-01-02 14:33:12 +01:00

Blender Bot added

and removed

Needs Info from Developers

labels 2024-01-02 14:33:14 +01:00

Pratik Borhade referenced this issue

2024-02-15 10:00:21 +01:00

Removing Object from Light Linking Collection also deletes Object from Scene Collection #118301

Glen-Candle commented

2024-02-17 21:28:38 +01:00

I just had an ah ha moment with this functionality, though I still disagree with the approach:

If you choose the collection you want to enable/disable light links in, and then delete an object from that collection (in light linking) then it also deletes the object in the scene.
But if you create a new light linking collection, deleting an object from this collection does not delete the object in the scene

This distinction is the clincher with this whole thing, and because this functionality is not intuitive the user is left to their own frustration and must learn the hard way.

Personally, an intuitive approach to software should be paramount to functional programming. Any user would assume that a light linking collection is not an actual collection, so deleting items from here should be safe. How many people are going to hit that minus button only to find out, often when it's far too late to fix, that they've actually deleted the object from their scene? It just really makes no sense.

I just had an ah ha moment with this functionality, though I still disagree with the approach: - If you choose the collection you want to enable/disable light links in, and then delete an object from that collection (in light linking) then it also deletes the object in the scene. - But if you create a new light linking collection, deleting an object from this collection does not delete the object in the scene This distinction is the clincher with this whole thing, and because this functionality is not intuitive the user is left to their own frustration and must learn the hard way. Personally, an intuitive approach to software should be paramount to functional programming. Any user would assume that a light linking collection is not an actual collection, so deleting items from here should be safe. How many people are going to hit that minus button only to find out, often when it's far too late to fix, that they've actually deleted the object from their scene? It just really makes no sense.

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

4 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#115869

No description provided.