Overrides: Overridable Python Properties don't get saved #115941

New Issue

Demeter Dzadik · 2023-12-08T13:36:28+01:00

Demeter Dzadik commented

2023-12-08 13:36:28 +01:00

System Information
Operating system: Linux-6.6.4-gentoo-x86_64-Intel-R-_Core-TM-i9-9900K_CPU@_3.60GHz-with-glibc2.37 64 Bits, X11 UI
Graphics card: NVIDIA GeForce RTX 2080/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 545.29.06

Blender Version
Broken: version: 4.1.0 Alpha, branch: main, commit date: 2023-12-08 00:25, hash: 2b0448c91d7a

Repro

Download both files and place side-by-side:
python_property_override_test_linked.blend
python_property_override_test.blend
Open _linked.blend.
A short script auto-registers a sidebar panel called "My Category".
In it, you see the armature's bone collections, with a Python BoolProperty that was registered on bpy.types.BoneCollection
Edit the toggles
Save & Reload
Your changes get lost.

CC @mont29 Any ideas?

**System Information** Operating system: Linux-6.6.4-gentoo-x86_64-Intel-R-_Core-TM-_i9-9900K_CPU_@_3.60GHz-with-glibc2.37 64 Bits, X11 UI Graphics card: NVIDIA GeForce RTX 2080/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 545.29.06 **Blender Version** Broken: version: 4.1.0 Alpha, branch: main, commit date: 2023-12-08 00:25, hash: `2b0448c91d7a` **Repro** - Download both files and place side-by-side: [python_property_override_test_linked.blend](/attachments/47710414-16b2-4d20-ba56-9c9c8f93cbad) [python_property_override_test.blend](/attachments/175b634c-96a1-4237-812f-7fc8fd383c86) - Open _linked.blend. - A short script auto-registers a sidebar panel called "My Category". - In it, you see the armature's bone collections, with a Python BoolProperty that was registered on bpy.types.BoneCollection - Edit the toggles - Save & Reload - Your changes get lost. CC @mont29 Any ideas?

python_property_override_test.blend

755 KiB

python_property_override_test_linked.blend

751 KiB

Demeter Dzadik added the

labels 2023-12-08 13:36:29 +01:00

Demeter Dzadik commented

2023-12-08 13:38:42 +01:00

Sorry, I don't think this is specific to BoneCollections, seems to happen for properties registered on bpy.types.Object too. Edited task accordingly.

Demeter Dzadik changed title from ~~Overrides/BoneCollections: Overridable Python Properties don't get saved~~ to Overrides: Overridable Python Properties don't get saved

2023-12-08 14:14:37 +01:00

Bastien Montagne commented

2023-12-08 14:29:03 +01:00

This won´t work for sure if you do not set the my_pointer to be overridable as well:

    bpy.types.BoneCollection.my_pointer = bpy.props.PointerProperty(type=MyElement, override={'LIBRARY_OVERRIDABLE'})

But I think the main issue comes from the fact that this RNA data is created by the script when opening the library file, so from blender PoV, that data does not exists before that point, and is not read?
Would need more time (which I do not have right now) to investigate and be sure, but would (very strongly) recommend ensuring all expected data model to exist before loading any override. LibOverrides are fully based on RNA data model. Working around it may be possible, either with existing code of adding more trickery to it, but I highly doubt this would lead to any reliable solution.

This won´t work for sure if you do not set the `my_pointer` to be overridable as well: ``` bpy.types.BoneCollection.my_pointer = bpy.props.PointerProperty(type=MyElement, override={'LIBRARY_OVERRIDABLE'}) ``` But I think the main issue comes from the fact that this RNA data is created by the script when opening the library file, so from blender PoV, that data does not exists before that point, and is not read? Would need more time (which I do not have right now) to investigate and be sure, but would (very _strongly_) recommend ensuring all expected data model to exist _before_ loading any override. LibOverrides are fully based on RNA data model. Working around it may be possible, either with existing code of adding more trickery to it, but I highly doubt this would lead to any reliable solution.

Bastien Montagne commented

2023-12-08 14:31:57 +01:00

But I think the main issue comes from the fact that this RNA data is created by the script when opening the library file, so from blender PoV, that data does not exists before that point, and is not read?

To be more specific, it would be read as 'vanilla' IDProperty, without any RNA information behind it, so the RNA paths it was 'saved' with by liboverride would be invalid.

One possible workaround could be to try and reload the library a second time afterwards, but this could actually lead to other issues (like attempt to re-register the RNA props a second time, ...).

> But I think the main issue comes from the fact that this RNA data is created by the script when opening the library file, so from blender PoV, that data does not exists before that point, and is not read? To be more specific, it would be read as 'vanilla' IDProperty, without any RNA information behind it, so the RNA paths it was 'saved' with by liboverride would be invalid. ------------- One possible workaround could be to try and reload the library a second time afterwards, but this could actually lead to other issues (like attempt to re-register the RNA props a second time, ...).

Demeter Dzadik commented

2023-12-08 15:31:39 +01:00