Regression: 'toggle visibility' mode of no longer works #116000

New Issue

michael campbell · 2023-12-10T11:39:51+01:00

michael campbell commented

2023-12-10 11:39:51 +01:00

System Information
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 537.58

Blender Version
Broken: version: 4.1.0 Alpha, branch: main, commit date: 2023-12-09 00:52, hash: 76bf43f44d0c
Worked: (previous build of 4.1)

Short description of error
operator sculpt.face_set_change_visibility no longer works in 'toggle visibility' mode. It now hides the hovered face set instead of the un-hovered face sets.

I'm aware that the shortcut has changed, but that's not the issue.

Extremely problematic because it means you now have to hide one face set at a time which takes ages if you have a lot of face sets.

Exact steps for others to reproduce the error

select cube
press ctrl 5
right click and convert to mesh
go to sculpt mode and select the paint face sets tool
draw 3 face sets
hover over the one you want to keep and press Shift + H
it will hide it, previous behavior was to hide the ones not hovered over.

**System Information** Operating system: Windows-10-10.0.19045-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 537.58 **Blender Version** Broken: version: 4.1.0 Alpha, branch: main, commit date: 2023-12-09 00:52, hash: `76bf43f44d0c` Worked: (previous build of 4.1) **Short description of error** operator sculpt.face_set_change_visibility no longer works in 'toggle visibility' mode. It now hides the hovered face set instead of the un-hovered face sets. I'm aware that the shortcut has changed, but that's not the issue. Extremely problematic because it means you now have to hide one face set at a time which takes ages if you have a lot of face sets. **Exact steps for others to reproduce the error** 1. select cube 2. press ctrl 5 3. right click and convert to mesh 4. go to sculpt mode and select the paint face sets tool 5. draw 3 face sets 6. hover over the one you want to keep and press `Shift + H` 7. it will hide it, previous behavior was to hide the ones not hovered over.

image.png

71 KiB

👍 1

michael campbell added the

labels 2023-12-10 11:39:52 +01:00

Pratik Borhade commented

2023-12-11 08:38:08 +01:00

Hi, thanks for the report. Shortcut for toggle visibility has been changed to Shift H
Re: crash with mask enum option, I can confirm

Hi, thanks for the report. Shortcut for toggle visibility has been changed to `Shift H` Re: crash with mask enum option, I can confirm

Pratik Borhade added

Module

Sculpt, Paint & Texture

and removed

labels 2023-12-11 08:38:20 +01:00

Pratik Borhade commented

2023-12-11 08:44:56 +01:00

Crash likely introduced with 841864406f (unable to redo in earlier builds with hide_show operator)

Crash likely introduced with 841864406f1f204e3f23948a611d5df198f2ae46 (unable to redo in earlier builds with `hide_show` operator)

Pratik Borhade added

and removed

labels 2023-12-11 08:45:20 +01:00

michael campbell commented

2023-12-11 09:06:55 +01:00

Morning @PratikPB2123 , thanks. I'm aware the shortcut has changed, the issue is that it hides the face set under the mouse rather than the face sets that aren't under the mouse. Both H and shift H now do the same thing, even though they're both calling the correct operators.

Pratik Borhade commented

2023-12-11 10:10:31 +01:00

I see, toggle visibility is hiding the active face sets which is different than old behavior.
I've not bisected but I suspect 251069ae5b
cc @HooglyBoogly

I see, toggle visibility is hiding the active face sets which is different than old behavior. I've not bisected but I suspect 251069ae5b71efcc85b5177de40cc8dd60d8913a cc @HooglyBoogly

Pratik Borhade changed title from ~~'toggle visibility' mode of sculpt.face_set_change_visibility no longer works. hard crash when attempting to emulate with new paint.hide_show operator~~ to Regression: 'toggle visibility' mode of no longer works

2023-12-11 10:16:57 +01:00

Pratik Borhade commented

2023-12-11 10:21:10 +01:00

Submitted new report for crash #116024

Pratik Borhade commented

2023-12-11 10:31:18 +01:00

Following change will restore the old behavior of hiding all face sets except active when shift h (i.e. toggle visibility) is pressed:

diff --git a/source/blender/editors/sculpt_paint/sculpt_face_set.cc b/source/blender/editors/sculpt_paint/sculpt_face_set.cc
index b0bff9299bf..bfd858f635e 100644
--- a/source/blender/editors/sculpt_paint/sculpt_face_set.cc
+++ b/source/blender/editors/sculpt_paint/sculpt_face_set.cc
@@ -1028,7 +1028,7 @@ static int sculpt_face_set_change_visibility_exec(bContext *C, wmOperator *op)
       else {
         face_hide_update(object, nodes, [&](const Span<int> faces, MutableSpan<bool> hide) {
           for (const int i : hide.index_range()) {
-            hide[i] = face_sets[faces[i]] == active_face_set;
+            hide[i] = face_sets[faces[i]] != active_face_set;
           }
         });
       }

Following change will restore the old behavior of hiding all face sets except active when shift h (i.e. toggle visibility) is pressed: ```Diff diff --git a/source/blender/editors/sculpt_paint/sculpt_face_set.cc b/source/blender/editors/sculpt_paint/sculpt_face_set.cc index b0bff9299bf..bfd858f635e 100644 --- a/source/blender/editors/sculpt_paint/sculpt_face_set.cc +++ b/source/blender/editors/sculpt_paint/sculpt_face_set.cc @@ -1028,7 +1028,7 @@ static int sculpt_face_set_change_visibility_exec(bContext *C, wmOperator *op) else { face_hide_update(object, nodes, [&](const Span<int> faces, MutableSpan<bool> hide) { for (const int i : hide.index_range()) { - hide[i] = face_sets[faces[i]] == active_face_set; + hide[i] = face_sets[faces[i]] != active_face_set; } }); } ```

👍 1

Pratik Borhade self-assigned this 2023-12-11 10:50:36 +01:00

Pratik Borhade referenced a pull request that will close this issue

2023-12-11 11:44:28 +01:00

Fix #116000: Face set toggle visibility not working correctly #116026

Pratik Borhade referenced this issue from a commit

2023-12-12 12:34:10 +01:00

Fix #116000: Face set toggle visibility not working correctly

Pratik Borhade closed this issue

2023-12-12 12:34:12 +01:00

Blender Bot added

Status