Changing the broken group results in a crash. #116082

New Issue

Open

opened 2023-12-12 07:23:05 +01:00 by ugorek · 7 comments

ugorek commented

2023-12-12 07:23:05 +01:00

System Information
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1650/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 536.23

Blender Version
Broken: version: 4.1.0 Alpha, branch: main, commit date: 2023-11-10 13:41, hash: cb5f650a5aa1

Short description of error
I coding a script to convert trees between editor types, and something went wrong in the process...
I didn't notice, but using the api I was able to somehow make a group whose name change would lead to instant crash.
Also, deleting a group or unlink a material will result in a crash.
curse.blend

Exact steps for others to reproduce the error
Open the file and delete the node.

**System Information** Operating system: Windows-10-10.0.19045-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1650/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 536.23 **Blender Version** Broken: version: 4.1.0 Alpha, branch: main, commit date: 2023-11-10 13:41, hash: `cb5f650a5aa1` **Short description of error** I coding a script to convert trees between editor types, and something went wrong in the process... I didn't notice, but using the api I was able to somehow make a group whose name change would lead to instant crash. Also, deleting a group or unlink a material will result in a crash. [curse.blend](/attachments/df7dc4fa-cebb-4f5c-a4a4-5368520de8eb) **Exact steps for others to reproduce the error** Open the file and delete the node.

curse.blend

913 KiB

ugorek added the

labels 2023-12-12 07:23:06 +01:00

Iliya Katushenock commented

2023-12-12 13:42:57 +01:00

Member

I can confirm crash, but there is nothing that we can do without simple way to reproduce this from scratch with short script.

I can confirm crash, but there is nothing that we can do without simple way to reproduce this from scratch with short script.

Iliya Katushenock added

Needs Information from User

Nodes & Physics

and removed

labels 2023-12-12 13:43:10 +01:00

ugorek commented

2023-12-12 20:55:00 +01:00

Author

Okay, I think I've managed to restore it.

import bpy

treeFrom = bpy.data.node_groups["Geometry Nodes"]
treeTo = bpy.data.node_groups.get("Aaa") or bpy.data.node_groups.new("Aaa", 'ShaderNodeTree')

treeTo.interface.clear()
for skfFrom in treeFrom.interface.items_tree:
    skfTo = treeTo.interface.new_socket(skfFrom.bl_socket_idname, in_out=skfFrom.in_out)
    try:
        skfTo.socket_type = skfFrom.socket_type
    except:
        pass
    for pr in skfFrom.bl_rna.properties:
        if (not pr.is_readonly)and(pr.identifier!='socket_type'):
            txt = "."+pr.identifier
            txt = repr(skfTo)+txt+" = "+repr(skfFrom)+txt
            exec(txt)
            #setattr(skfTo, pr.identifier, getattr(skfFrom, pr.identifier))

Okay, I think I've managed to restore it. ```py import bpy treeFrom = bpy.data.node_groups["Geometry Nodes"] treeTo = bpy.data.node_groups.get("Aaa") or bpy.data.node_groups.new("Aaa", 'ShaderNodeTree') treeTo.interface.clear() for skfFrom in treeFrom.interface.items_tree: skfTo = treeTo.interface.new_socket(skfFrom.bl_socket_idname, in_out=skfFrom.in_out) try: skfTo.socket_type = skfFrom.socket_type except: pass for pr in skfFrom.bl_rna.properties: if (not pr.is_readonly)and(pr.identifier!='socket_type'): txt = "."+pr.identifier txt = repr(skfTo)+txt+" = "+repr(skfFrom)+txt exec(txt) #setattr(skfTo, pr.identifier, getattr(skfFrom, pr.identifier)) ``` @mod_moder ^

ugorek commented

2023-12-12 22:26:20 +01:00

Author

I have a suspicion that the installation for the shader tree .interface.items_tree[0].bl_socket_idname = 'NodeSocketGeometry' has something to do with the crash.

I have a suspicion that the installation for the shader tree `.interface.items_tree[0].bl_socket_idname = 'NodeSocketGeometry'` has something to do with the crash.

Iliya Katushenock commented

2023-12-13 11:24:52 +01:00

Member

Okay, I think I've managed to restore it.

Not able to confirm crash in my default file / can't run this in factory startup.

> Okay, I think I've managed to restore it. Not able to confirm crash in my default file / can't run this in factory startup.

ugorek commented

2023-12-13 13:13:02 +01:00

Author

Factory Settings
Geometry nodes > +New
Scripnig > +New
Paste and Run
Shading > Shift+A
Add "Aaa"
Factory Settings
Crash!!

1. Factory Settings 2. Geometry nodes > +New 3. Scripnig > +New 4. Paste and Run 5. Shading > Shift+A 6. Add "Aaa" 7. Factory Settings 8. Crash!! @mod_moder <video src="/attachments/a5ec8a91-87ec-48e8-b75f-5c1865521ac2" title="2023-12-13 19-05-18.mp4" controls></video>

2023-12-13 19-05-18.mp4

2.7 MiB

Iliya Katushenock commented

2023-12-13 13:46:42 +01:00

Member

@LukasTonne Is there a chance that new node tree interface items does not use pull function of tree type to validate socket type (on assignment)?

@LukasTonne Is there a chance that new node tree interface items does not use pull function of tree type to validate socket type (on assignment)?

Iliya Katushenock added

Needs Info from Developers

Nodes & Physics

and removed

Needs Information from User

Nodes & Physics

labels 2023-12-13 13:46:57 +01:00

Iliya Katushenock self-assigned this 2023-12-13 14:25:42 +01:00

Iliya Katushenock added

and removed

Needs Info from Developers

labels 2023-12-13 14:25:47 +01:00

Iliya Katushenock referenced a pull request that will close this issue

2023-12-13 15:38:10 +01:00

Fix #116082: Correct way to change bl_socket_idname #116146

Jacques Lucke referenced this issue from a commit

2024-02-19 21:02:07 +01:00

Fix #116082: support changing interface socket bl_socket_idname

Jacques Lucke closed this issue

2024-02-19 21:02:09 +01:00

Blender Bot added

and removed

labels 2024-02-19 21:02:11 +01:00

Jacques Lucke referenced this issue from a commit

2024-02-21 22:24:10 +01:00

Revert "Fix #116082: support changing interface socket bl_socket_idname"

Iliya Katushenock reopened this issue

2024-02-22 04:48:01 +01:00

Blender Bot added

and removed

labels 2024-02-22 04:48:03 +01:00

Iliya Katushenock added

and removed

labels 2024-02-22 04:48:12 +01:00

Iliya Katushenock commented

2024-04-26 14:16:43 +02:00

Member

I can't reproduce this error anymore, but now i have memory leak.

I can't reproduce this error anymore, but now i have memory leak.

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#116082

No description provided.