"Show Hidden Objects" operator's options missing, which is inconsistent with "Reveal Hidden" operator #116339

New Issue

Weasel On a Stick · 2023-12-19T14:01:06+01:00

Weasel On a Stick commented

2023-12-19 14:01:06 +01:00

System Information
Operating system:
Graphics card: AMD 5500U

Blender Version
Broken: 4.0.2
Worked: (newest version of Blender that worked as expected)

Short description of error
Unhiding objects doesn't bring up any options, thus selecting every objects that is un-hidden. Where as its Edit mode counterpart has a bool property to prevent that.

Exact steps for others to reproduce the error
Based on the default startup.

**System Information** Operating system: Graphics card: AMD 5500U **Blender Version** Broken: 4.0.2 Worked: (newest version of Blender that worked as expected) **Short description of error** Unhiding objects doesn't bring up any options, thus selecting every objects that is un-hidden. Where as its Edit mode counterpart has a bool property to prevent that. **Exact steps for others to reproduce the error** Based on the default startup. ![Screenshot 2023-12-19 195531](/attachments/d2521aab-795a-4804-a5b6-5441a7e5ae04) ![image](/attachments/59ecdeba-3c59-4204-825e-a92cf9f6b65d)

Screenshot 2023-12-19 195531.png

495 KiB

image.png

506 KiB

Weasel On a Stick added the

labels 2023-12-19 14:01:06 +01:00

Philipp Oeser commented

2023-12-19 15:40:08 +01:00

The property is actually there, but was marked PROP_SKIP_SAVE | PROP_HIDDEN in 4234cddda9

@brecht : do you recall why this was necessary? Seems to make sense to reactivate this?

The property is actually there, but was marked `PROP_SKIP_SAVE | PROP_HIDDEN` in 4234cddda9ed59e5a7fff7043a2add2aaf158d23 @brecht : do you recall why this was necessary? Seems to make sense to reactivate this?

Philipp Oeser commented

2023-12-19 15:44:13 +01:00

Talking about doing this

diff --git a/source/blender/editors/object/object_edit.cc b/source/blender/editors/object/object_edit.cc
index 86545c89647..176c512b5c5 100644
--- a/source/blender/editors/object/object_edit.cc
+++ b/source/blender/editors/object/object_edit.cc
@@ -329,7 +329,6 @@ void OBJECT_OT_hide_view_clear(wmOperatorType *ot)
   ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO;
 
   PropertyRNA *prop = RNA_def_boolean(ot->srna, "select", true, "Select", "");
-  RNA_def_property_flag(prop, PropertyFlag(PROP_SKIP_SAVE | PROP_HIDDEN));
 }
 
 static int object_hide_view_set_exec(bContext *C, wmOperator *op)

Talking about doing this ```diff diff --git a/source/blender/editors/object/object_edit.cc b/source/blender/editors/object/object_edit.cc index 86545c89647..176c512b5c5 100644 --- a/source/blender/editors/object/object_edit.cc +++ b/source/blender/editors/object/object_edit.cc @@ -329,7 +329,6 @@ void OBJECT_OT_hide_view_clear(wmOperatorType *ot) ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO; PropertyRNA *prop = RNA_def_boolean(ot->srna, "select", true, "Select", ""); - RNA_def_property_flag(prop, PropertyFlag(PROP_SKIP_SAVE | PROP_HIDDEN)); } static int object_hide_view_set_exec(bContext *C, wmOperator *op) ```

Philipp Oeser added

Status

Needs Info from Developers

and removed

labels 2023-12-19 15:57:35 +01:00

Brecht Van Lommel commented

2024-01-10 19:58:21 +01:00

I don't think it's really necessary.

It does change the behavior of menu entries and shortcuts, in the sense that it will now remember the select setting from the last time. That seems to be case already for the corresponding mesh operator, might as well follow that.

@lichtwerk, so I think you can just commit your proposed change.

I don't think it's really necessary. It does change the behavior of menu entries and shortcuts, in the sense that it will now remember the select setting from the last time. That seems to be case already for the corresponding mesh operator, might as well follow that. @lichtwerk, so I think you can just commit your proposed change.

Pratik Borhade commented

2024-03-06 07:24:56 +01:00