Regression: Editor Type Button always appears in a single column #116471

New Issue

Charles Wardlaw · 2023-12-22T17:58:34+01:00

Charles Wardlaw commented

2023-12-22 17:58:34 +01:00

System Information
Operating system: Sonoma 14.2
Graphics card: M3 Max 40 Core

Blender Version
Broken: 4.1 (build from main as of 22 Dec)
Worked: perhaps a month or two ago

Opening the Editor Type menu now presents the menu in a long single column. This is fine when the button is at the top of the Blender window, but if you split areas then you end up always scrolling.

This is a regression in usability, especially for laptop users. It seems to be related to #115275

I've attached two images of the issue, and one of how it was before, which was much preferred. If this was an intentional change and not a bug, please revert the commit.

**System Information** Operating system: Sonoma 14.2 Graphics card: M3 Max 40 Core **Blender Version** Broken: 4.1 (build from main as of 22 Dec) Worked: perhaps a month or two ago Opening the Editor Type menu now presents the menu in a long single column. This is fine when the button is at the top of the Blender window, but if you split areas then you end up always scrolling. This is a regression in usability, especially for laptop users. It seems to be related to https://projects.blender.org/blender/blender/issues/115275 I've attached two images of the issue, and one of how it was before, which was much preferred. If this was an intentional change and not a bug, please revert the commit.

correct_behavior.png

363 KiB

single_column_long.png

183 KiB

single_column_scrolling.png

440 KiB

Charles Wardlaw added the

labels 2023-12-22 17:58:35 +01:00

Brecht Van Lommel commented

2023-12-22 18:10:56 +01:00

I suspect this works:

diff --git a/source/blender/editors/interface/interface.cc b/source/blender/editors/interface/interface.cc
index 749cd6e..bba3a09 100644
--- a/source/blender/editors/interface/interface.cc
+++ b/source/blender/editors/interface/interface.cc
@@ -4377,7 +4377,7 @@ static void ui_def_but_rna__menu(bContext *C, uiLayout *layout, void *but_p)
   }
 
   /* If the estimated width is greater than available size, collapse to one column. */
-  if (columns > 1 && text_width > win->sizex) {
+  if (columns > 1 && text_width > WM_window_pixels_x(win)) {
     columns = 1;
     rows = totitems;
   }

I suspect this works: ``` diff --git a/source/blender/editors/interface/interface.cc b/source/blender/editors/interface/interface.cc index 749cd6e..bba3a09 100644 --- a/source/blender/editors/interface/interface.cc +++ b/source/blender/editors/interface/interface.cc @@ -4377,7 +4377,7 @@ static void ui_def_but_rna__menu(bContext *C, uiLayout *layout, void *but_p) } /* If the estimated width is greater than available size, collapse to one column. */ - if (columns > 1 && text_width > win->sizex) { + if (columns > 1 && text_width > WM_window_pixels_x(win)) { columns = 1; rows = totitems; } ```

Charles Wardlaw commented

2023-12-22 18:12:52 +01:00

Adding some more:

My resolution scale is 1.25 normally. At 1.0, I get the old menu behaviour when the window is nearly full screen.
Shrinking the window at all on the X axis returns the menu to narrow.

Adding some more: - My resolution scale is 1.25 normally. At 1.0, I get the old menu behaviour when the window is nearly full screen. - Shrinking the window at all on the X axis returns the menu to narrow.

Screenshot 2023-12-22 at 12.11.16 PM.png

2.2 MiB

Screenshot 2023-12-22 at 12.11.06 PM.png

2.0 MiB