Old node groups aren't working in asset browser when dragging and dropping them into GN #116571

Closed
opened 2023-12-27 06:36:06 +01:00 by RT · 10 comments

System Information
Ubuntu 20.04

Blender Version
4.02

Short description of error
Old node groups aren't working in asset browser when dragging and dropping

Exact steps for others to reproduce the error
Based on the default startup or an attached .blend file (as simple as possible).

I use to just drag and drop the node group into geometry nodes (from the asset browser) now the icon is there but when I drag and drop an old node group nothing happens.

screenshot-December-27-2023-00-28-25.png

bug drag - drop asset browser.gif

Attached blend file.

axis arrow grp_asset.blend

System info.txt file
system-info.txt

**System Information** Ubuntu 20.04 **Blender Version** 4.02 **Short description of error** Old node groups aren't working in asset browser when dragging and dropping **Exact steps for others to reproduce the error** Based on the default startup or an attached .blend file (as simple as possible). I use to just drag and drop the node group into geometry nodes (from the asset browser) now the icon is there but when I drag and drop an old node group nothing happens. ![screenshot-December-27-2023-00-28-25.png](/attachments/90838c13-2346-43a0-a6ca-dcf091e743f1) ![bug drag - drop asset browser.gif](/attachments/58c42183-b9e5-4051-9090-150cd74140ad) Attached blend file. [axis arrow grp_asset.blend](/attachments/bc8ab977-c494-464f-9eb3-c7f398ce4b4b) System info.txt file [system-info.txt](/attachments/82e464ed-c456-426e-b0f1-ddf45bb3383e)
RT added the
Priority
Normal
Type
Report
Status
Needs Triage
labels 2023-12-27 06:36:07 +01:00
Member

axis arrow grp_asset.blend does not seem to contain the group you are trying to drag and drop [Gin_AttrViewer]

Please share that one as well (seems to be in your Main Library Asset Library?) -- at last this is where you seem to drag it from?

image

`axis arrow grp_asset.blend` does not seem to contain the group you are trying to drag and drop [`Gin_AttrViewer`] Please share that one as well (seems to be in your `Main Library` Asset Library?) -- at last this is where you seem to drag it from? ![image](/attachments/4cd422ad-57a5-47b6-abea-9714de7afc63)
130 KiB
Philipp Oeser added
Status
Needs Information from User
and removed
Status
Needs Triage
labels 2023-12-27 10:21:27 +01:00
Author

@lichtwerk Ok here's the Blend file where the node group is located in. It's almost like a "pointer" to some of the old node groups aren't "transferring over / being used / was renamed" (but that's just a guess)

screenshot-December-27-2023-00-28-25.png

AttributeViewer_V3.blend

@lichtwerk Ok here's the Blend file where the node group is located in. It's almost like a "pointer" to some of the old node groups aren't "transferring over / being used / was renamed" (but that's just a guess) ![screenshot-December-27-2023-00-28-25.png](/attachments/0686b3bb-4082-4ec8-89cd-8c62251c236a) [AttributeViewer_V3.blend](/attachments/06468d31-cf3c-450b-9198-2afa2fb66d72)
Author

@lichtwerk Do you need more examples? I have several.

@lichtwerk Do you need more examples? I have several.
Philipp Oeser added
Status
Needs Triage
and removed
Status
Needs Information from User
labels 2024-01-01 14:01:50 +01:00
Member

I can confirm. Some commit between 3.6-4.0 affected this.

I can confirm. Some commit between 3.6-4.0 affected this.
Member

This is due to failing poll function which was updated in 30e3caaf82
metadata->properties is nullptr here.
cc @lichtwerk @JulianEisel

This is due to failing poll function which was updated in 30e3caaf8291811f9c86a5721a67a976d18e5af2 `metadata->properties` is nullptr here. cc @lichtwerk @JulianEisel
Member

Thx checking @PratikPB2123

Will look into a fix

Thx checking @PratikPB2123 Will look into a fix
Philipp Oeser self-assigned this 2024-01-02 09:25:06 +01:00
Member

Hm, not sure if this really has a proper "fix".

That asset file was saved with (3, 2, 14).

But looking at commit bdb5754147 (specifically the following from the commit message):

"To make that possible, metadata like the node tree type and its inputs
and outputs has to be saved in the file. This requires re-saving the
files that contain the assets with the patch applied."

makes me think that indeed, the proper solution to this issue is just re-saving the files that contain the assets with a version after bdb5754147 (so for example current 3.6 LTS). Tested this, this works as expected, the nodegroups can then be dropped as expected.

@HooglyBoogly : what do you think?

Hm, not sure if this really has a proper "fix". That asset file was saved with (3, 2, 14). But looking at commit bdb57541475f (specifically the following from the commit message): >"To make that possible, metadata like the node tree type and its inputs and outputs has to be saved in the file. This requires re-saving the files that contain the assets with the patch applied." makes me think that indeed, the proper solution to this issue is just re-saving the files that contain the assets with a version after bdb57541475f (so for example current 3.6 LTS). Tested this, this works as expected, the nodegroups can then be dropped as expected. @HooglyBoogly : what do you think?
Philipp Oeser removed their assignment 2024-01-02 10:10:32 +01:00
Member

I'm not totally sure yet. I started by trying to add the file to my asset library folder so I could test dragging it into a file. But it didn't show up in the asset library. Then I tried opening the file and I hit an assert in the asset system. But according to Pratik's point, I'd agree, yes, the solution is just re-saving the asset file, and I don't think this is a bug.

I'm not totally sure yet. I started by trying to add the file to my asset library folder so I could test dragging it into a file. But it didn't show up in the asset library. Then I tried opening the file and I hit an assert in the asset system. But according to Pratik's point, I'd agree, yes, the solution is just re-saving the asset file, and I don't think this is a bug.
Member

So my vote would also be to accept this as current behavior.

What we should have done though is mention this in the release notes (otherwise not sure if there is a good way on the blender code side to take care of this).
https://wiki.blender.org/wiki/Reference/Release_Notes/3.4
https://developer.blender.org/docs/release_notes/3.4/
(under "Compatibility"?)

Suggested wording: "Since metadata like the node tree type and its inputs
and outputs has to be saved in the file (see bdb5754147), re-saving the
files that contain the assets is required"

So my vote would also be to accept this as current behavior. What we should have done though is mention this in the release notes (otherwise not sure if there is a good way on the blender code side to take care of this). https://wiki.blender.org/wiki/Reference/Release_Notes/3.4 https://developer.blender.org/docs/release_notes/3.4/ (under "Compatibility"?) Suggested wording: "Since metadata like the node tree type and its inputs and outputs has to be saved in the file (see bdb57541475f), re-saving the files that contain the assets is required"
Member

Thanks, good idea. I used slightly different wording, but it's mentioned in the new wiki now.

Thanks, good idea. I used slightly different wording, but it's mentioned in the new wiki now.
Blender Bot added
Status
Archived
and removed
Status
Confirmed
labels 2024-01-10 19:11:07 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#116571
No description provided.