Accessing curve points positions, in draw_handler + geo node mod == huge lag. #116763

New Issue

Open

opened 2024-01-03 21:23:33 +01:00 by Jose Conseco · 7 comments

Jose Conseco commented

2024-01-03 21:23:33 +01:00

System Information
Operating system: Linux-6.6.8-2-MANJARO-x86_64-with-glibc2.38 64 Bits, X11 UI
Graphics card: NVIDIA GeForce RTX 3060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 545.29.06

Blender Version
Broken: version: 3.6.7, branch: blender-v3.6-release, commit date: 2023-12-11 16:28, hash: cbd81f283d58
Worked: it never worked, and it does not work in blender 4.0.2 to.

Short description of error
Im using gpu module, to draw each curve point index. It works ok (fast), but as soon as we add any geo nodes modifier, to curve, moving points give huge lag (it can crash from time to time to, especially if just went edit mode, and try to move first point).
As far as my test go, this only affect new hair curves. No issues with meshes, or old curves.

Exact steps for others to reproduce the error

Run script from attached file curve_drawing_slow_b367.blend
Try to move curve point in edit mode - points lags a lot, they are stuck in their position.
Disable geonodes modifier - its fast again.

**System Information** Operating system: Linux-6.6.8-2-MANJARO-x86_64-with-glibc2.38 64 Bits, X11 UI Graphics card: NVIDIA GeForce RTX 3060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 545.29.06 **Blender Version** Broken: version: 3.6.7, branch: blender-v3.6-release, commit date: 2023-12-11 16:28, hash: `cbd81f283d58` Worked: it never worked, and it does not work in blender 4.0.2 to. **Short description of error** Im using gpu module, to draw each curve point index. It works ok (fast), but as soon as we add any geo nodes modifier, to curve, moving points give huge lag (it can crash from time to time to, especially if just went edit mode, and try to move first point). As far as my test go, this only affect new hair curves. No issues with meshes, or old curves. **Exact steps for others to reproduce the error** 1. Run script from attached file [curve_drawing_slow_b367.blend](/attachments/2be857b3-dadd-416c-8034-c6c5a62680d5) 2. Try to move curve point in edit mode - points lags a lot, they are stuck in their position. Disable geonodes modifier - its fast again.

curve_drawing_slow_b367.blend

101 KiB

Jose Conseco added the

labels 2024-01-03 21:23:33 +01:00

Iliya Katushenock added

EEVEE & Viewport

Nodes & Physics

and removed

labels 2024-01-03 21:53:41 +01:00

Iliya Katushenock commented

2024-01-03 21:54:42 +01:00

Member

Can't confirm crash in in debug, but lags is here.

Can't confirm crash in in debug, but lags is here.

Jose Conseco commented

2024-01-03 21:58:02 +01:00

Author

Well yes, the crashes are bit random. It does not happen 90% of time.

Well yes, the crashes are bit random. It does not happen 90% of time.

8fold commented

2024-01-04 18:34:10 +01:00

it seems even disabling the modifier sometimes it lags. for me in 4.0.1, after running the script, moving a point around a lot will cause it to "freeze" and stop moving.

it seems even disabling the modifier sometimes it lags. for me in 4.0.1, after running the script, moving a point around a lot will cause it to "freeze" and stop moving.

Carlo San commented

2024-01-05 19:05:56 +01:00

confirmed, lags and random crash.

confirmed, lags and random crash.

Shaun-Boundy commented

2024-01-08 14:45:28 +01:00

Tested, random crashes, editing is laggy and sticky.

Tested, random crashes, editing is laggy and sticky.

Hans Goudey commented

2024-01-08 21:08:24 +01:00

Member

This is a use after free. I didn't look into it for too long, but I think it's a design issue with the transform system which is holding onto pointers into the position custom data layer for too long. The layer is being reallocated on each update as we retrieve it for write access and it's shared somewhere else. Ideally the transform system would retrieve the layer just before writing back the data.

This is a use after free. I didn't look into it for too long, but I think it's a design issue with the transform system which is holding onto pointers into the position custom data layer for too long. The layer is being reallocated on each update as we retrieve it for write access and it's shared somewhere else. Ideally the transform system would retrieve the layer just before writing back the data.

Leonardo-Vieira-da-Silva commented

2024-01-09 17:52:32 +01:00

same issue here, lag and crashes while editing

same issue here, lag and crashes while editing

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

7 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#116763

No description provided.